Bug 26598 - task-gnome-minimal pulls gtk+2
Summary: task-gnome-minimal pulls gtk+2
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: Olav Vitters
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-07 15:09 CEST by Thierry Vignaud
Modified: 2020-05-07 18:07 CEST (History)
1 user (show)

See Also:
Source RPM: task-gnome, gnome-themes-extra
CVE:
Status comment:


Attachments
urpmi --root … --justdb task-gnome-minimal --auto (66.93 KB, application/gzip)
2020-05-07 15:11 CEST, Thierry Vignaud
Details

Description Thierry Vignaud 2020-05-07 15:09:47 CEST
task-gnome-minimal pulls gtk+2.
It should only pull gtk3 stuff.

gnome-control-center -> gnome-themes-standard -> gnome-themes-extra -> lib64gtk2-hc-engine -> lib64gtk+-x11-2.0_0

But there're other ways it's pulled:
* -> gsettings-desktop-schemas -> gnome-themes-standard -> …


See attachment generated by:
D=try1
urpmi --root $D --justdb basesystem-minimal --auto --media "Core Release"
urpmi --root $D --justdb task-gnome-minimal --auto --media "Core Release" --debug 2>&1|tee LOG.gnome3-vs-gtk2
Comment 1 Thierry Vignaud 2020-05-07 15:11:31 CEST
Created attachment 11620 [details]
urpmi --root … --justdb task-gnome-minimal --auto
Comment 2 Thierry Vignaud 2020-05-07 15:23:22 CEST
gtk2-hc-engine was added there: http://svnweb.mageia.org/packages?view=revision&revision=1371742
I don't think it should be there…
Comment 3 Thierry Vignaud 2020-05-07 15:33:37 CEST
Fixed in gnome-themes-extra-3.28-6.mga8

Resolution: (none) => FIXED
Source RPM: task-gnome => task-gnome, gnome-themes-extra
Status: NEW => RESOLVED

Comment 4 Olav Vitters 2020-05-07 16:28:30 CEST
As assignee I take all credit for the fix! :-D
Comment 5 Jani Välimaa 2020-05-07 17:19:28 CEST
(In reply to Thierry Vignaud from comment #2)
> gtk2-hc-engine was added there:
> http://svnweb.mageia.org/packages?view=revision&revision=1371742
> I don't think it should be there…

If we want HC theme to work as expected in gtk2 apps, it's needed.

$ grep engine /usr/share/themes/HighContrast/gtk-2.0/gtkrc
  engine "hcengine" {

Perhaps better way to fix this is to split out gtk2 theme parts.

CC: (none) => jani.valimaa

Comment 6 Thierry Vignaud 2020-05-07 17:22:05 CEST
This is not the right place.
A gtk3 package shouldn't pull gtk2.
Put it in the adwaita-gtk2-theme subpkg if you really must.

Interestingly, /usr/share/themes/HighContrast/gtk-2.0/gtkrc is in gnome-themes-extra on Mageia but in adwaita-gtk2-theme on Fedora.
We should probably move the files…
Comment 7 Jani Välimaa 2020-05-07 17:36:24 CEST
Yes, like I said. Perhaps it's better to split out the gtk2 parts.
Comment 8 Thierry Vignaud 2020-05-07 17:36:37 CEST
I've moved those files in the gtk2 subpkg.

As for hcengine, I would say:
- gtk2 is on its way out
- HC isn't the default them

So that don't really affect that much users and should not be a reason to pull the whole gtk2 stuff when installing gnome3.

If you really insist, add a Recommends in the gtk2 sub pkg
Comment 9 Thierry Vignaud 2020-05-07 17:37:32 CEST
I insist on the *recommends* part as it's not mandatory and hard requires just create new dep chains that tends to bloat minimal installations.
Comment 10 Jani Välimaa 2020-05-07 18:07:34 CEST
Requiring gtk2-hc-engine in adwaita-gtk2-theme doesn't really bring such much extra deps. 

And why to break functionality by removing dep that is needed for correct behavior? If one wants to use HC theme in gtk2, one should get working env after installing the pkg providing the theme.

Like when you buy a car, but you don't get any engine. You just need to know that you also need engine to run the car. :)

Note You need to log in before you can comment on or make changes to this bug.