Bug 24884 - audacity GUI broken
Summary: audacity GUI broken
Status: NEW
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal major
Target Milestone: ---
Assignee: All Packagers
QA Contact:
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2019-05-31 11:40 CEST by Giuseppe Ghibò
Modified: 2022-09-21 11:43 CEST (History)
3 users (show)

See Also:
Source RPM: audacity-2.3.1-1.mga7.src.rpm
CVE:
Status comment:


Attachments
how appears the audacity GUI in HiDPI (106.71 KB, image/png)
2019-05-31 11:42 CEST, Giuseppe Ghibò
Details
How the audacity GUI should appear with GDK_SCALE=1 (66.74 KB, image/png)
2019-05-31 11:44 CEST, Giuseppe Ghibò
Details
How the audacity GUI should appear with GDK_SCALE=2 (103.21 KB, image/png)
2019-05-31 11:45 CEST, Giuseppe Ghibò
Details
Quick fix (702 bytes, patch)
2019-05-31 11:57 CEST, Giuseppe Ghibò
Details | Diff
audacity 2.3.2 with the internal wxgtk (still to be fixed the Hz widget) (116.76 KB, image/png)
2019-05-31 12:02 CEST, Giuseppe Ghibò
Details
new spec file diff (1.38 KB, patch)
2019-05-31 13:33 CEST, Giuseppe Ghibò
Details | Diff
rediffed patch (1.92 KB, patch)
2019-05-31 13:34 CEST, Giuseppe Ghibò
Details | Diff
rediffed patch (1.06 KB, patch)
2019-05-31 13:34 CEST, Giuseppe Ghibò
Details | Diff
Screenshot after the new fixes (115.00 KB, image/png)
2019-05-31 13:35 CEST, Giuseppe Ghibò
Details
audacity-2.3.1-1.mga7 run from Konsole (15.60 KB, text/plain)
2019-06-19 21:26 CEST, Sébastien Morin
Details

Description Giuseppe Ghibò 2019-05-31 11:40:45 CEST
Description of problem:

In HiDPI mode, the GUI of audacity is broken. In particular all the buttons are overlapped each other. In this way it's not much usable, because you can't read what the button does. In mga6 the audacity UI (buttons and menu) was instead scaling correctly. 

In particular the previous versions supports GDK_SCALE env var, while current one totally ignores it. You could set for instance:

GDK_SCALE=2 audacity

and have the UI scaled by a factor of two. I attach the screenshot of current audacity and previous audacity to see the differences.

So probably the system wxgtk is broken too.
Comment 1 Giuseppe Ghibò 2019-05-31 11:42:12 CEST
Created attachment 11038 [details]
how appears the audacity GUI in HiDPI
Comment 2 Giuseppe Ghibò 2019-05-31 11:44:19 CEST
Created attachment 11039 [details]
How the audacity GUI should appear with GDK_SCALE=1
Comment 3 Giuseppe Ghibò 2019-05-31 11:45:08 CEST
Created attachment 11040 [details]
How the audacity GUI should appear with GDK_SCALE=2
Comment 4 Giuseppe Ghibò 2019-05-31 11:57:54 CEST
Created attachment 11041 [details]
Quick fix

Here is a quick fix. Reverting to internal wxgtk (and upgrade it to latest wxgtk 3.0.4 as well as to audacity 2.3.2) would fix the problem, though the old audacity-*-widgets-create-room.patch that was removed should be re-enabled and probably rediffed. Without that patch in fact the "Hz" widget in the bottom left is partially overlapped by the drop menu button (see screenshot in attach).
Comment 5 Giuseppe Ghibò 2019-05-31 12:02:27 CEST
Created attachment 11042 [details]
audacity 2.3.2 with the internal wxgtk (still to be fixed the Hz widget)
Comment 6 Giuseppe Ghibò 2019-05-31 13:33:28 CEST
Created attachment 11043 [details]
new spec file diff

New fix. This one adds a little bit more room for the project rate string

Attachment 11041 is obsolete: 0 => 1

Comment 7 Giuseppe Ghibò 2019-05-31 13:34:04 CEST
Created attachment 11044 [details]
rediffed patch
Comment 8 Giuseppe Ghibò 2019-05-31 13:34:26 CEST
Created attachment 11045 [details]
rediffed patch
Comment 9 Giuseppe Ghibò 2019-05-31 13:35:02 CEST
Created attachment 11046 [details]
Screenshot after the new fixes
Comment 10 Marja Van Waes 2019-05-31 20:09:59 CEST
Assigning to our registered audacity maintainer.

Assignee: bugsquad => lists.jjorge
CC: (none) => marja11
Keywords: (none) => PATCH

Comment 11 José Jorge 2019-06-18 18:07:14 CEST
Please Giuseppe, why use builtin wxgtk wchile it is the same version MGA7 provides?
Comment 12 Giuseppe Ghibò 2019-06-19 13:11:06 CEST
Because the system wxgtk is probably broken or compiled without GTK3 support. This bug occurs also in current audacity-2.3.2-1.mga7 in updates_testing.

The testing is simple even on a non-HiDPI desktop: just run from command line: "GDK_SCALE=2 audacity" or "GDK_SCALE=3 audacity", if the GUI scales then it's OK, if it doesn't then it's broken.
Comment 13 José Jorge 2019-06-19 14:41:29 CEST
(In reply to Giuseppe Ghibò from comment #12)
> Because the system wxgtk is probably broken or compiled without GTK3
> support. This bug occurs also in current audacity-2.3.2-1.mga7 in
> updates_testing.

Ok, but we package wxgtk, why don't you fix it's build options to enable GTK3?
We must remove as many bundled libs as we can...
Comment 14 Sébastien Morin 2019-06-19 21:25:50 CEST
I have no idea what could/should be done to fix the issue but I just wanted to confirm the bug described in Comment 1.
Also, audacity takes ages to start. This is what I get when running it from Konsole (see attached file).

$ rpm -qa | grep audacity
audacity-2.3.1-1.mga7

CC: (none) => sebsweb

Comment 15 Sébastien Morin 2019-06-19 21:26:27 CEST
Created attachment 11116 [details]
audacity-2.3.1-1.mga7 run from Konsole
Comment 16 Giuseppe Ghibò 2019-06-20 20:19:54 CEST
(In reply to José Jorge from comment #13)
> (In reply to Giuseppe Ghibò from comment #12)
> > Because the system wxgtk is probably broken or compiled without GTK3
> > support. This bug occurs also in current audacity-2.3.2-1.mga7 in
> > updates_testing.
> 
> Ok, but we package wxgtk, why don't you fix it's build options to enable
> GTK3?
> We must remove as many bundled libs as we can...

When I spotted the bug, there was already deep freeze, so I preferred to propagate the fixes only inside one single package.
Comment 17 José Jorge 2019-06-20 21:31:27 CEST
(In reply to Giuseppe Ghibò from comment #16)
> (In reply to José Jorge from comment #13)
> > (In reply to Giuseppe Ghibò from comment #12)
> > > Because the system wxgtk is probably broken or compiled without GTK3
> > > support. This bug occurs also in current audacity-2.3.2-1.mga7 in
> > > updates_testing.
> > 
> > Ok, but we package wxgtk, why don't you fix it's build options to enable
> > GTK3?
> > We must remove as many bundled libs as we can...
> 
> When I spotted the bug, there was already deep freeze, so I preferred to
> propagate the fixes only inside one single package.

AS this will not go before release, it will need to be an update. I prefer to do the changes in the MGA7 package, and keep in cauldron the current one, as system wxgtk3 is coming shortly.
Comment 18 Giuseppe Ghibò 2019-06-20 21:39:42 CEST
Ok, anyway I placed the whole fixed version with bundled wxgtk here: 

https://copr.fedorainfracloud.org/coprs/ghibo/audacity
Manuel Hiebel 2021-03-04 22:02:31 CET

Assignee: lists.jjorge => pkg-bugs

Comment 19 papoteur 2022-09-21 11:43:36 CEST
What is the state currently of the bug?
with GDK_SCALE=2, I see problems with 3 drop down lists for Recording device, Recording channels and Playback device.

CC: (none) => yves.brungard_mageia


Note You need to log in before you can comment on or make changes to this bug.