Bug 24848 - MCC and rpmdrake do not apply the dark mode in Plasma5, bug work fine in dark mode in Xfce
Summary: MCC and rpmdrake do not apply the dark mode in Plasma5, bug work fine in dark...
Status: RESOLVED WORKSFORME
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: KDE maintainers
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-21 10:02 CEST by Jose Manuel López
Modified: 2023-11-29 23:28 CET (History)
5 users (show)

See Also:
Source RPM: plasma? drakconf? rpmdrake?
CVE:
Status comment:


Attachments
main MCC window does not respect theme setting (130.17 KB, image/png)
2023-11-03 18:45 CET, sturmvogel
Details
only sub windows of MCC work (38.24 KB, image/png)
2023-11-03 18:47 CET, sturmvogel
Details
rpmdrake with dark theme (534.63 KB, image/png)
2023-11-03 18:55 CET, katnatek
Details

Description Jose Manuel López 2019-05-21 10:02:54 CEST
Description of problem: The aplications Rpmdrake and MCC no apply the dark mode in desktop Plasma Kde, but in de desktop Xfce work fine in the dark mode.


Version-Release number of selected component (if applicable): Mageia 7 Beta 3 Plasma Kde


How reproducible: Open the RpmDrake and MCC in Plasma dark mode.


Steps to Reproduce:
1. Change theme plasma or appearance at dark mode, and reboot
2. Open RpmDrake
3. Open MCC
Comment 1 Marja Van Waes 2019-05-21 12:16:05 CEST
(In reply to Jose Manuel López Díaz from comment #0)
> Description of problem: The aplications Rpmdrake and MCC no apply the dark
> mode in desktop Plasma Kde, but in de desktop Xfce work fine in the dark
> mode.

How exactly do you switch to dark mode in Plasma, and how exactly in Xfce?

In other words, which exact theme selection do you make in Plasma and which in Xfce?

Summary: These applications do not apply the dark mode => MCC and rpmdrake do not apply the dark mode in Plasma5, bug work fine in dark mode in Xfce
Source RPM: Rpmdrake and Mcc => plasma? drakconf? rpmdrake?
CC: (none) => kde, mageiatools, marja11
Keywords: (none) => NEEDINFO

Comment 2 Jose Manuel López 2019-05-21 14:51:23 CEST
(In reply to Marja Van Waes from comment #1)
> (In reply to Jose Manuel López Díaz from comment #0)
> > Description of problem: The aplications Rpmdrake and MCC no apply the dark
> > mode in desktop Plasma Kde, but in de desktop Xfce work fine in the dark
> > mode.
> 
> How exactly do you switch to dark mode in Plasma, and how exactly in Xfce?
> 
> In other words, which exact theme selection do you make in Plasma and which
> in Xfce?

I change to dark mode in Plasma Settings > Visual Aspect > Brisa dark

In XFCE, in settings, Adwaita Dark mode
Comment 3 Jose Manuel López 2019-05-21 15:00:23 CEST
It also occurs in Mageia 6.1
Comment 4 Jani Välimaa 2019-05-21 16:48:37 CEST
Plasma uses Qt and Mageia tools GTK+3. Mixing toolkits and unifying settings is always difficult.
Comment 5 Jose Manuel López 2019-05-21 17:13:37 CEST
(In reply to Jani Välimaa from comment #4)
> Plasma uses Qt and Mageia tools GTK+3. Mixing toolkits and unifying settings
> is always difficult.

Wow, I thought that having the default Plasma Kde, Mageia was also written in Qt.

Although I have put applications in Gtk3 in dark mode, this does not apply to Rpmdrake and MCC.

Appearance> Application style> Gnome / Gtk application style
Comment 6 katnatek 2019-05-21 19:19:51 CEST
I hope for the Mageia 8 cycle we can start the migration to manatools.
mantools have frontends for qt and gtk, so i think will exists less issues like this.

Sadly i think the problematic mageia 6 cycle make that mageia 7 will come with less new features of desired https://wiki.mageia.org/en/FeatureMageia7_Review , even our brother from another mother will come with dnf as replace of urpmi first than mageia, and mageia did work in that earlier.
Comment 7 Marja Van Waes 2019-05-24 17:15:30 CEST
@ kde team

What is needed for MCC and rpmdrake to have "dark mode" in Plasma5?

Assignee: bugsquad => kde
Keywords: NEEDINFO => (none)

Comment 8 Jose Manuel López 2020-01-02 12:23:51 CET
Any news on this?

Is there a development plan about it?

Greetings
Comment 9 Jose Manuel López 2021-02-15 17:22:56 CET
I don't think this will be ready for Mageia 8.

We can close this bug, for in a future change this enhancement?

Greetings!
Comment 10 Aurelien Oudelet 2021-02-15 17:29:05 CET
No, don't close this.

This is due that MCC and rpmdrake are run as root user. If your user account has set a dark theme, root user theme is not changed.

CC: (none) => ouaurelien

Comment 11 Jose Manuel López 2021-02-15 19:34:32 CET
Then, This isn't bug, because if I change the appeareance as root, the dark theme works?

Or we are waiting to modify something for this works whit the normal user?
Comment 12 Jose Manuel López 2023-10-31 16:18:21 CET
Hi,

I have tried to:

- Go to root session from login screen.
- Go to Systemsettings of Plasma and select Dark mode Global theme and Dark mode in Plasma Theme and save.
- Go to user session from login screen.
- Now, open Rpmdrake or "Install or remove applications", it appears in dark mode.
- Now, open Drakconf or "Mageia Control Center", It appears in dark mode, except the inside of the application which must be written with a white background.

Then, we can:

- Publish a note in the wiki with this process.
- Make that Mageia tools change their appearance when the user change his theme in systemsettings.
Comment 13 katnatek 2023-11-01 03:25:09 CET
You need to switch the theme for gtk applications, that's why works on xfce, gnome and maybe lxde, are gtk based desktops

In Plasma configurations on the Apparence -> Aplications Style 
You will see at right bottom the option to change the style for GNOME/GTK applications

Other thing that may help is if mageia make the switch to manatools as have native look for gtk and qt desktops
Comment 14 katnatek 2023-11-02 21:04:46 CET
(In reply to Jose Manuel López from comment #12)
> Hi,
> 
> I have tried to:
> 
> - Go to root session from login screen.
> - Go to Systemsettings of Plasma and select Dark mode Global theme and Dark
> mode in Plasma Theme and save.
> - Go to user session from login screen.
> - Now, open Rpmdrake or "Install or remove applications", it appears in dark
> mode.
> - Now, open Drakconf or "Mageia Control Center", It appears in dark mode,
> except the inside of the application which must be written with a white
> background.
> 
> Then, we can:
> 
> - Publish a note in the wiki with this process.
> - Make that Mageia tools change their appearance when the user change his
> theme in systemsettings.

Need a check https://wiki.mageia.org/en/Appearance_of_Mageia_Tools
Comment 15 sturmvogel 2023-11-03 01:02:05 CET
The wiki article misses the point that MCC does not respect the settings for dark themes under KDE Plasma. Also opening systemsettings5 via root and applying the theme changes does not work (which is pure nonsense and never should be done!)

So the content of this article for Plasma is plain wrong...
Comment 16 sturmvogel 2023-11-03 01:21:15 CET
(In reply to katnatek from comment #13)
> Other thing that may help is if mageia make the switch to manatools as have
> native look for gtk and qt desktops

manatools got deprecated and removed from Mageia as they are no longer maintained nor developed...
Comment 17 katnatek 2023-11-03 18:04:59 CET
(In reply to sturmvogel from comment #15)
> The wiki article misses the point that MCC does not respect the settings for
> dark themes under KDE Plasma. Also opening systemsettings5 via root and
> applying the theme changes does not work (which is pure nonsense and never
> should be done!)
> 
> So the content of this article for Plasma is plain wrong...

I change the procedure, I not focus the article on Dark theme, just thinking in users that not want to apply a Dark theme, but I give the example of set Breeze Dark, and make clear that I don't test with other themes.
Comment 18 katnatek 2023-11-03 18:05:44 CET
(In reply to sturmvogel from comment #16)
> (In reply to katnatek from comment #13)
> > Other thing that may help is if mageia make the switch to manatools as have
> > native look for gtk and qt desktops
> 
> manatools got deprecated and removed from Mageia as they are no longer
> maintained nor developed...

That is sad :(
Comment 19 sturmvogel 2023-11-03 18:41:04 CET
NEVER start a session as root! This is basic linux knowledge since ages! 
- it is dangerous
- it is never needed!
- it throws a bad shade on Mageia to have something like that in the wiki! 

Every linux distribution strongly warns their users (since ages) to run GUI applications as root or login into a session as root. Only Mageia recommends in the wiki to start a session as root. Really? This is a shame!

And btw, as already mentioned in comment 15, this procedure does not even work s the main MCC windows does not respect these settings!!! Only the sub MCC windows follow the theme settings.

So the wiki article is now worse than before: dangerous, untested and not even working instructions!
Comment 20 sturmvogel 2023-11-03 18:45:37 CET
Created attachment 14126 [details]
main MCC window does not respect theme setting

As can be seen in the screenshot, even after using your described dangerous, untested and not working procedure to log into a root session and change the the theme to a dark one, MCC does not respect the setting.
Comment 21 sturmvogel 2023-11-03 18:47:53 CET
Created attachment 14127 [details]
only sub windows of MCC work

Only sub windows (here rpmdrake) apply the dark theme after using the dangerous, untested and (overall) not working procedure of the wiki to login into a root session.
Comment 22 katnatek 2023-11-03 18:55:32 CET
Created attachment 14128 [details]
rpmdrake with dark theme

(In reply to sturmvogel from comment #20)
> Created attachment 14126 [details]
> main MCC window does not respect theme setting
> 
> As can be seen in the screenshot, even after using your described dangerous,
It's dangerous if the user do thing not in the procedure, but that is also valid for run as root in terminal lxappearance or any other application

> untested and not working procedure to log into a root session and change the
> the theme to a dark one, MCC does not respect the setting.

Watch your words, I write just after test, Yes the main window don't have full dark theme but by example with rpmdrake works, If I need to test tool by tool I'll do.
katnatek 2023-11-03 18:55:59 CET

CC: (none) => j.alberto.vc

Comment 23 sturmvogel 2023-11-03 19:02:53 CET
(In reply to katnatek from comment #22)
> Watch your words, I write just after test, Yes the main window don't have
> full dark theme but by example with rpmdrake works, If I need to test tool
> by tool I'll do.

Seems you missed the point. You added a dangerous, untested and not working procedure to the wiki which does not solve the original problem which was reported by Jose in the very first post of this bugreport:

(In reply to Jose Manuel López from comment #0)
> Description of problem: The aplications Rpmdrake and MCC no apply the dark
> mode in desktop Plasma Kde, but in de desktop Xfce work fine in the dark
> mode.

So you are risking the safety and system stability of users by adding a non working procedure to the wiki which does not even address the reported problem of Jose. He mentioned explicitely that MCC does not respect the dark mode which was verified (see screenshot) by me by applying the dangerous, untested and not working procedure from the wiki.
Comment 24 katnatek 2023-11-03 19:14:07 CET
(In reply to sturmvogel from comment #23)
Fine but in comment#12 Jose Manuel do the same, I will add a warning, recommend to use lxappearance, and make clear the main MCC window don't follow totally the selected theme
Comment 25 sturmvogel 2023-11-03 19:23:16 CET
It is a question of basic user education to not promote unsafe behaviour! 

If you see somebody doing it you should NEVER promote such behaviour. Thats maybe why my words sound harsh to you. 

Other linux distributions (as example Arch) have dedicated wiki pages that warn users to login as root or run GUI applications as root. Even desktop environment devs strongly warns their users to run GUI applications as root.

Since nearly two decades, safe and approved ways to elevate user rights (if needed) are existing and promoted by nearly all distributions. This includes policikit, kdesu, safe applications which are developed to run in GUI mode with elevated user rights and much much more..
Comment 26 katnatek 2023-11-03 19:32:18 CET
(In reply to sturmvogel from comment #25)
I don't believe in security by obscurity, I add the warning, but you can remove the unsafe procedure if you wish. 

(In reply to sturmvogel from comment #25)
> 
> Since nearly two decades, safe and approved ways to elevate user rights (if
> needed) are existing and promoted by nearly all distributions. This includes
> policikit, kdesu, safe applications which are developed to run in GUI mode
> with elevated user rights and much much more..

I first try to provide a more safe method, I test with su - and run systemsettings5, and kdesu systemsettings5 but the change not works.
Comment 27 katnatek 2023-11-04 02:20:48 CET
In the wiki of archlinux, I found interesting information, I adapt one of the recommendations, test on my system and update the page, this close the topic of the unsafe method,
Comment 28 Jose Manuel López 2023-11-04 07:10:28 CET
I think that we can close this bug.
Comment 29 Jose Manuel López 2023-11-27 11:50:37 CET
Several solutions have been provided and it is published on the Mageia wiki (https://wiki.mageia.org/en/Appearance_of_Mageia_Tools). I think we can close this bug.
Comment 30 katnatek 2023-11-27 19:06:45 CET
It's someone against to close this as WorksFoMe?
Comment 31 katnatek 2023-11-29 23:28:27 CET
Closing by Request of Reporter

Resolution: (none) => WORKSFORME
Status: NEW => RESOLVED


Note You need to log in before you can comment on or make changes to this bug.