Bug 24286 - Mageia Welcome missing icon
Summary: Mageia Welcome missing icon
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: Mageia tools maintainers
QA Contact:
URL:
Whiteboard:
Keywords: 7beta3
Depends on:
Blocks:
 
Reported: 2019-02-01 21:40 CET by Ben McMonagle
Modified: 2019-06-25 10:09 CEST (History)
5 users (show)

See Also:
Source RPM: mageiawelcome
CVE:
Status comment:


Attachments
Maeia welcome screenshot (31.92 KB, image/png)
2019-02-01 21:40 CET, Ben McMonagle
Details
Patch to give the good path to mageiawelcome.png (604 bytes, patch)
2019-04-15 10:41 CEST, Nicolas Salguero
Details | Diff

Description Ben McMonagle 2019-02-01 21:40:10 CET
Description of problem: difference in Mageia Welcome icons taskbar and Application launcher menu. see screenshot


Version-Release number of selected component (if applicable):

7-beta2-i586.iso
DATE.txt: Wed Jan 3


How reproducible:always


Steps to Reproduce:
1.install LXDE from above.iso. reboot
2.login and compare taskbar and Application Launcher menu icons 
3.
Comment 1 Ben McMonagle 2019-02-01 21:40:54 CET
Created attachment 10714 [details]
Maeia welcome screenshot
Ben McMonagle 2019-02-01 21:41:32 CET

Keywords: (none) => 7beta2

Comment 2 Marja Van Waes 2019-02-03 09:54:40 CET
In Plasma5, the taskbar MageiaWelcome-is-running icon matches the Application launcher icon, so I guess this should be fixed on LXDE side.

Assigning to the LXDE maintainer

CC: (none) => marja11
Assignee: bugsquad => nicolas.salguero

Comment 3 Nicolas Salguero 2019-02-04 14:13:53 CET
Hi,

The problem is not with LXDE but with mageiawelcome itself: the task bar in LXDE shows the same icon as the one from the main window and mageiawelcome has no icon for the main window because of line 168 of file /usr/share/mageiawelcome/mageiawelcome.py:
"""
app.setWindowIcon(QIcon("icons/32x32/apps/mageiawelcome.png"))
"""
There are several issues there:
1) To use a relative path, you need to be sure you are in the right directory before, which is a problem when launching from /usr/bin/mageiawelcome for example.
2) There is no directory /usr/share/mageiawelcome/icons/32x32/apps/ and, then, no file /usr/share/mageiawelcome/icons/32x32/apps/mageiawelcome.png.
3) You cannot use /usr/share/icons/hicolor/scalable/apps/mageiawelcome.svg because SVG files are not supported; it seems like only PNG ones are supported.

To solve the problem, in my tests, I did this:
1) mkdir -p /usr/share/mageiawelcome/icons/32x32/apps/
2) cd /usr/share/mageiawelcome/icons/32x32/apps/
3) convert /usr/share/icons/hicolor/scalable/apps/mageiawelcome.svg mageiawelcome.png
4) modify line 168 of file /usr/share/mageiawelcome/mageiawelcome.py like this:
"""
app.setWindowIcon(QIcon("/usr/share/mageiawelcome/icons/32x32/apps/mageiawelcome.png"))
"""

Best regards,

Nico.
Nicolas Salguero 2019-02-05 09:13:14 CET

Summary: Mageia Welcome incorrect icon in taskbar LXDE32 => Mageia Welcome missing icon
Assignee: nicolas.salguero => bugsquad

Comment 4 Ben McMonagle 2019-02-05 09:21:37 CET
Sorry Nicolas, LXDE is the first DE I try  when doing installs, and I write up any bugs found attributing them to LXDE, as I know that it is demonstratable in that DE, which is probably the wrong thing to do.

I try to amend bug reports if they are found in other desktops, so I will have a further look at this tomorrow.

what is now known is that plasma5 is ok, so I dont need to check that DE.
Comment 5 Marja Van Waes 2019-02-05 15:23:42 CET
Thanks Nicolas!

Reassigning to the MageiaTools maintainers

CC: (none) => geiger.david68210, yves.brungard_mageia
Source RPM: (none) => mageiawelcome
Assignee: bugsquad => mageiatools

Comment 6 papoteur 2019-02-05 21:21:16 CET
Thanks for reporting this problem.
It should be solved in the next release. The image wasn't included in the installation process.

Source RPM: mageiawelcome => (none)
Assignee: mageiatools => bugsquad

Comment 7 papoteur 2019-02-05 21:50:18 CET
Restoring bugsquad work :/

Source RPM: (none) => mageiawelcome
Assignee: bugsquad => mageiatools

Comment 8 papoteur 2019-02-25 07:47:58 CET
1.95 is now released.
Is this problem still present?
Comment 9 Ben McMonagle 2019-02-25 08:11:56 CET
after update today to 1.95-1.mga7

ok on desktops cinnamon, gnome, plasma

not ok on lxde, mate, xfce
Sébastien Morin 2019-02-26 12:46:12 CET

CC: (none) => sebsweb

Comment 10 Ben McMonagle 2019-04-13 06:30:20 CEST
stilll valid for:

Mageia-7-beta3-x86_64
DATE.txt: Fri Apr 12 01:15:06 CEST 201
Ben McMonagle 2019-04-13 06:30:37 CEST

Keywords: 7beta2 => 7beta3

Comment 11 papoteur 2019-04-13 17:48:27 CEST
For me, Ok in LXQt.
Ben, do you have this file?
/usr/share/icons/hicolor/32x32/apps/mageiawelcome.png
Comment 12 Sébastien Morin 2019-04-13 19:16:45 CEST
Confirmed here in a Virtual Machine.
Fresh install with the same Mga7-beta3 round 3 with LXDE

$ ls -lh /usr/share/icons/hicolor/32x32/apps/
total 108K
-rw-r--r-- 1 root root 2,2K nov.  16  2014 abiword.png
-rw-r--r-- 1 root root 1,3K sept. 21  2018 edit-urpm-sources.png
-rw-r--r-- 1 root root 2,2K nov.   8  2012 ekiga.png
-rw-r--r-- 1 root root 1,7K janv. 26  2017 empathy.png
-rw-r--r-- 1 root root  746 déc.   1  2016 filezilla.png
-rw-r--r-- 1 root root 2,1K avril  7 09:10 firefox.png
-rw-r--r-- 1 root root 1,2K mai   25  2018 gcr-gnupg.png
-rw-r--r-- 1 root root 1,9K mai   25  2018 gcr-key-pair.png
-rw-r--r-- 1 root root 1,2K mai   25  2018 gcr-key.png
-rw-r--r-- 1 root root  902 mai   25  2018 gcr-password.png
-rw-r--r-- 1 root root 1,1K mai   25  2018 gcr-smart-card.png
-rw-r--r-- 1 root root 1,9K mars  12  2012 gimp.png
-rw-r--r-- 1 root root 2,3K déc.  27  2014 gnumeric.png
-rw-r--r-- 1 root root 3,3K févr. 24 13:50 grip.png
-rw-r--r-- 1 root root 2,4K févr. 18 23:47 gthumb.png
-rw-r--r-- 1 root root 6,1K sept. 26  2018 jpilot.png
-rw-r--r-- 1 root root 2,4K oct.   5  2006 leafpad.png
-rw-r--r-- 1 root root 1,3K sept. 21  2018 mageiaupdate.png
-rw-r--r-- 1 root root 1,3K mars  31 13:54 mageiawelcome.png
-rw-r--r-- 1 root root 1,3K janv. 28 23:56 mgaonline.png
-rw-r--r-- 1 root root 2,1K déc.  11 17:52 pix.png
-rw-r--r-- 1 root root 5,5K mars   3 17:09 pulseaudio.png
-rw-r--r-- 1 root root 1,8K sept. 20  2018 register-mga.png
-rw-r--r-- 1 root root  997 sept. 21  2018 rpmdrake.png
-rw-r--r-- 1 root root 2,1K oct.   4  2018 xine.png
Comment 13 Nicolas Salguero 2019-04-15 10:41:32 CEST
Created attachment 10934 [details]
Patch to give the good path to mageiawelcome.png

Hi,

In mageiawelcome.py, the path to mageiawelcome.png is wrong: it should be "/usr/share/icons/hicolor/32x32/apps/mageiawelcome.png" and it is "/usr/share/mageiawelcome/icons/32x32/apps/mageiawelcome.png".

Best regards,

Nico.

CC: (none) => nicolas.salguero

Comment 14 David GEIGER 2019-04-15 11:04:51 CEST
So should be temporarily fixed in next mageiawelcome-1.96-2.mga7 update!


@papoteur:

Can you merge Nicolas's patch in gitweb, please?
Comment 15 papoteur 2019-04-16 13:35:59 CEST
Thanks Nicolas,
This was already in git, but not yet released. Sorry.
Comment 16 Ben McMonagle 2019-06-25 10:09:32 CEST
ok in m7-final

thanks

Resolution: (none) => FIXED
Status: NEW => RESOLVED


Note You need to log in before you can comment on or make changes to this bug.