Bug 24263 - shebangs incorrectly added to files to be sourced
Summary: shebangs incorrectly added to files to be sourced
Status: RESOLVED INVALID
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: Martin Whitaker
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-01-30 19:19 CET by David Walser
Modified: 2019-01-30 19:49 CET (History)
0 users

See Also:
Source RPM: dbus, xdg-compliance
CVE:
Status comment:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description David Walser 2019-01-30 19:19:38 CET 
The change in dbus-1.13.8-2.mga7 and xdg-compliance-0.1-23.mga7 is incorrect.  Those files are sourced, not executed, and don't need executable permissions.  In fact, I think something greps them for the "to be sourced" to know to source them, but off the top of my head I'm not sure they won't do the wrong thing with the shebangs.  it might not be a problem, but it wasn't necessary at the least.
Comment 1 Martin Whitaker 2019-01-30 19:33:40 CET 
See /etc/X11/Xsession. It checks that the files are executable, even when it sources them. Also see other files in /etc/X11/xinit.d that have both a shebang and a "# to be sourced".

If you want to change Xsession to work differently, go ahead. I prefer to tread cautiously.

Status: NEW => RESOLVED
Resolution: (none) => INVALID

Martin Whitaker 2019-01-30 19:49:34 CET

See Also: (none) => https://bugs.mageia.org/show_bug.cgi?id=24198
Note You need to log in before you can comment on or make changes to this bug.