Bug 23993 - "Image Files" option broken (setting icons on "Applications Menu" panel items)
Summary: "Image Files" option broken (setting icons on "Applications Menu" panel items)
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: Jani Välimaa
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-11 11:49 CET by Juergen Harms
Modified: 2019-02-19 18:47 CET (History)
1 user (show)

See Also:
Source RPM: xfce4-panel-4.13.3-2.mga7.src.rpm
CVE:
Status comment:


Attachments
Popup for starting icon selection (43.87 KB, image/jpeg)
2018-12-15 23:08 CET, Juergen Harms
Details
Resulting panel with the new Applications Menu item (has incorrect icon) (7.97 KB, image/jpeg)
2018-12-15 23:10 CET, Juergen Harms
Details

Description Juergen Harms 2018-12-11 11:49:17 CET
Description of problem:

"Applications Menu" panel items allow to define a custom icon; that icon can be picked from a list of icons, or it can be specified via a corresponding image file (eg. a .png file).

Specification from an image file does not work corrrectly with Xfce 4.13 (it does with 4.12):
- the path to an icon file can be correctly selected (and the selection survives restarting Xfce)
- but the Applications Menu panel item will not display the corresponding icon (instead a blank icon is shown)

Version-Release number of selected component (if applicable): see sourcce rpm


How reproducible: always


Steps to Reproduce:
1. Open the item-properties popup on an "Applications Menu" panel item (if necessary create such an item)
2. Left-button-hit on the icon displayed in the popup
3. In the new popup ("Select An Icon"), select "Icon Files" (top-row combo)
4. Navigate to some valid icon-file and hit OK

The path of the icon file will be saved, but the corresponding icon is not shown in the panel item.
Comment 1 Juergen Harms 2018-12-11 18:44:56 CET
I missed out on one essential item: functionally the panel items are OK: when such an item is (blindly) hit, the menu pops up and menu items can be selected.

There is an evident workaround: copy the icon-file into a directory where icons are automatically searched - for instance - /usr/local/share/icons
Comment 2 Marja Van Waes 2018-12-11 20:29:32 CET
Assigning to the registered maintainer.

Assignee: bugsquad => jani.valimaa
CC: (none) => marja11

Comment 3 Jani Välimaa 2018-12-15 20:59:53 CET
Can't reproduce the issue. I can change the icon for apps menu button, for every item in app menu and for launcher in panel.

A screenshot about the issue would be nice.
Comment 4 Juergen Harms 2018-12-15 23:07:19 CET
> Can't reproduce the issue

I re-did it in a void guest user environment. Steps once more, being overly wordy to avoid mis-understandings:
1. Create the new panel item 
  - right button hit on panel -> Panel -> "Add New Items"
  - "Add New Items" popup ->  select "Applications Menu -> +Add button -> Close

2. Customize that item
  - right button hit on the item -> Properties
  - in the "Applications Menu" popup: left button hit on the icon
  - in the "Select An Icon" popup, combo in the top row: Select "Image Files"
    (bottom menu item)
  - in the file selection popup : browse to/select the desired file (I - at 
    random - picked "deluge.png"

	Screenshot1 (the icon file is correctly selected and the icon correctly
        displayed)

  - OK
  - Close

	Screenshot2 (the icon is not displayed in the panel item),
	as said in comnent 1, functionally the item is OK and will launch the
        attached menu (the whisker menu in this case
Comment 5 Juergen Harms 2018-12-15 23:08:28 CET
Created attachment 10560 [details]
Popup for starting icon selection
Comment 6 Juergen Harms 2018-12-15 23:10:24 CET
Created attachment 10561 [details]
Resulting panel with the new Applications Menu item (has incorrect icon)
Comment 7 Jani Välimaa 2018-12-16 10:12:22 CET
OK, now I can reproduce this. I think this is something should be reported to upstream.
Comment 8 Juergen Harms 2018-12-16 10:36:16 CET
Since working around is possible (and few users will do this kind of operation), there is no hurry. Shall I do it, or will you?
Comment 9 Jani Välimaa 2018-12-16 10:59:51 CET
(In reply to Juergen Harms from comment #8)
> Since working around is possible (and few users will do this kind of
> operation), there is no hurry. Shall I do it, or will you?

It would be nice if you could do it.
Comment 10 Juergen Harms 2018-12-16 12:01:39 CET
Done: https://bugzilla.xfce.org/show_bug.cgi?id=14976
Jani Välimaa 2018-12-16 12:10:21 CET

See Also: (none) => https://bugzilla.xfce.org/show_bug.cgi?id=14976

Comment 12 Jani Välimaa 2019-01-11 17:31:11 CET
(In reply to Jani Välimaa from comment #11)
> Fixed in upstream GIT:
> https://git.xfce.org/xfce/xfce4-panel/commit/
> ?id=dc1f684d600884583d93cfbdae6b78a6b2b9ee9f

Applied upstream patch to xfce4-panel-4.13.4-2.mga7.
Comment 13 Juergen Harms 2019-02-19 18:47:47 CET
See comment #12

Status: NEW => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.