Bug 22988 - graphicsmagick several (possible) new security issues
Summary: graphicsmagick several (possible) new security issues
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: Security (show other bugs)
Version: 6
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: QA Team
QA Contact: Sec team
URL:
Whiteboard: MGA6-64-OK
Keywords: advisory, validated_update
Depends on:
Blocks:
 
Reported: 2018-05-03 19:07 CEST by David Walser
Modified: 2018-05-09 20:34 CEST (History)
7 users (show)

See Also:
Source RPM: graphicsmagick-1.3.28-1.mga6.src.rpm
CVE:
Status comment:


Attachments
List of reproducers to be run before and after the updates (2.65 KB, text/plain)
2018-05-03 20:22 CEST, Len Lawrence
Details
Results of running the reproducers before updating GM (4.26 KB, text/plain)
2018-05-04 01:40 CEST, Len Lawrence
Details
Results from running the PoC tests after updating GM (2.65 KB, text/plain)
2018-05-04 01:41 CEST, Len Lawrence
Details
Collection of reproducer files for GraphicsMagick (49.16 KB, application/octet-stream)
2018-05-04 17:06 CEST, Len Lawrence
Details
Quick conversion utility for images to be animated (284 bytes, application/x-ruby)
2018-05-05 13:47 CEST, Len Lawrence
Details
Animation script for a set of images. (325 bytes, application/x-perl)
2018-05-05 14:00 CEST, Len Lawrence
Details
Convert a set of images to frame<n>.ext (418 bytes, application/x-ruby)
2018-05-06 01:52 CEST, Len Lawrence
Details
Convert a set of images to files names frame<n>.gif|ext (427 bytes, application/x-ruby)
2018-05-06 02:26 CEST, Len Lawrence
Details

Description David Walser 2018-05-03 19:07:47 CEST
openSUSE has issued an advisory on February 1:
https://lists.opensuse.org/opensuse-updates/2018-02/msg00000.html

openSUSE has issued an advisory on February 16:
https://lists.opensuse.org/opensuse-updates/2018-02/msg00053.html

openSUSE has issued an advisory on February 20:
https://lists.opensuse.org/opensuse-updates/2018-02/msg00079.html

openSUSE has issued an advisory on February 26:
https://lists.opensuse.org/opensuse-updates/2018-02/msg00106.html

openSUSE has issued an advisory on March 18:
https://lists.opensuse.org/opensuse-updates/2018-03/msg00065.html

openSUSE has issued an advisory on April 7:
https://lists.opensuse.org/opensuse-updates/2018-04/msg00013.html

openSUSE has issued an advisory on May 2:
https://lists.opensuse.org/opensuse-updates/2018-05/msg00003.html

Stig-Ørjan Smelror has built an update for 1.3.29, which may fix these issues.

Advisory:
========================

GraphicsMagick 1.3.29 updated with fixes for several security issues.

References:
https://lists.opensuse.org/opensuse-updates/2018-02/msg00000.html
https://lists.opensuse.org/opensuse-updates/2018-02/msg00053.html
https://lists.opensuse.org/opensuse-updates/2018-02/msg00079.html
https://lists.opensuse.org/opensuse-updates/2018-02/msg00106.html
https://lists.opensuse.org/opensuse-updates/2018-03/msg00065.html
https://lists.opensuse.org/opensuse-updates/2018-04/msg00013.html
https://lists.opensuse.org/opensuse-updates/2018-05/msg00003.html


Updated packages in core/updates_testing:
========================
graphicsmagick-1.3.29-1.mga6
libgraphicsmagick3-1.3.29-1.mga6
libgraphicsmagick++12-1.3.29-1.mga6
libgraphicsmagickwand2-1.3.29-1.mga6
libgraphicsmagick-devel-1.3.29-1.mga6
perl-Graphics-Magick-1.3.29-1.mga6
graphicsmagick-doc-1.3.29-1.mga6

from graphicsmagick-1.3.29-1.mga6.src.rpm
David Walser 2018-05-03 19:08:19 CEST

Assignee: bugsquad => qa-bugs
Keywords: advisory, validated_update => (none)
Depends on: 22403 => (none)
Source RPM: graphicsmagick-1.3.27-1.mga6.src.rpm => graphicsmagick-1.3.28-1.mga6.src.rpm

Comment 1 Len Lawrence 2018-05-03 19:50:13 CEST
Accumulating reproducers for some of the CVEs.  Quite a long list.
Comment 2 Len Lawrence 2018-05-03 20:22:50 CEST
Created attachment 10118 [details]
List of reproducers to be run before and after the updates
Comment 3 Len Lawrence 2018-05-03 20:24:02 CEST
Continuing with this later.
Comment 4 Len Lawrence 2018-05-04 01:40:36 CEST
Created attachment 10119 [details]
Results of running the reproducers before updating GM
Comment 5 Len Lawrence 2018-05-04 01:41:45 CEST
Created attachment 10120 [details]
Results from running the PoC tests after updating GM
Comment 6 Len Lawrence 2018-05-04 01:45:35 CEST
Comparisons between the PoC tests before and after show that little had changed which might indicate that most of the issues with reproducers had already been fixed.  There is a net positive outcome anyway.

Functionality tests tomorrow aka later.
Comment 7 Len Lawrence 2018-05-04 10:32:18 CEST
Found a few more tests by following the seven links in the advisory again - after the update.  The results seem to show that the underlying issues are being dealt with cleanly.  There is general agreement with upstream tests.
Tabulating these later.
Comment 8 Len Lawrence 2018-05-04 17:06:16 CEST
Created attachment 10122 [details]
Collection of reproducer files for GraphicsMagick
Comment 9 Len Lawrence 2018-05-05 13:47:47 CEST
Created attachment 10123 [details]
Quick conversion utility for images to be animated

$ ruby frames.rb <imagelist> <extension>
Comment 10 Len Lawrence 2018-05-05 14:00:14 CEST
Created attachment 10124 [details]
Animation script for a set of images.

Edit as required.  See bug #17714.
Comment 11 Len Lawrence 2018-05-05 14:37:21 CEST
In previous testing sessions there has often been trouble with gm conversions from * to TIFF.  That still seems to be the case but IM can handle the conversion OK.

$ gm convert GlenShiel_7.jpg glenshiel.tiff
gm convert: glenshiel.tiff: Invalid tag "Predictor" (not supported by codec). (_TIFFVGetField).
$ convert GlenShiel_7.jpg glenshiel.tiff

Converting back again does not eradicate the message.
$ gm convert glenshiel.tiff glenshiel.jpg
$ gm convert glenshiel.jpg glen.tif
gm convert: glen.tif: Invalid tag "Predictor" (not supported by codec). (_TIFFVGetField).
$ gm display glenshiel.jpg
$ gm display glen.tif
$ gm convert GlenShiel_6.jpg loch.png
$ gm display loch.png
All the displays work fine.

Vector graphics:
$ ls *svg
sample2.svg  sample.svg  test.svg
$ gm display *.svg
That showed sample2.svg.  Left clicking for a menu and then clicking 'Next' advanced to sample.svg; another click for test.svg.

Create an animated GIF from an image list.
(Used the attached ruby script to generate a list of frame images.)
Ran wilcal's animation script from bug #17714 comment 23.
$ perl gmtest.pl
Generated four-frame image frames.gif.
$ gm display -delay 200 frames.gif
Display the sequence with 2 second pauses.  Units of 'delay' are hundredths of a second.
Alternatively:
$ gm display -delay 2.0 frames.gif
for 2 second delays.

$ gm convert -resize 120%x80% Ikapati.tif ikapati.png
Creates a squashed image of a crater on Ceres.

GM does not reproduce all of the IM functions but this works: 
$ gm convert -size 300x400  gradient:olivedrab-steelblue gradient_5.jpg
$ gm display gradient_5.jpg
It does not seem to support a builtin canvas.

Switch an image from left to right.
$ gm mogrify -flop frame5.png
Turn the image upside down.
$ gm mogrify -rotate 180 frame5.png
Return the image to its original state.
$ gm mogrify -flip frame5.png

Looks like it is all working.  Giving this an OK but shall add the latest PoC tests later.  Need to revert for those - for information only - the bug can be validated.

Whiteboard: (none) => MGA6-64-OK

Comment 12 Len Lawrence 2018-05-06 01:52:18 CEST
Created attachment 10125 [details]
Convert a set of images to  frame<n>.ext

Attachment 10123 is obsolete: 0 => 1

Comment 13 Len Lawrence 2018-05-06 02:26:25 CEST
Created attachment 10126 [details]
Convert a set of images to files names frame<n>.gif|ext

Attachment 10125 is obsolete: 0 => 1

Lewis Smith 2018-05-06 09:10:27 CEST

Keywords: (none) => advisory, validated_update

Comment 14 Mageia Robot 2018-05-09 20:34:13 CEST
An update for this issue has been pushed to the Mageia Updates repository.

https://advisories.mageia.org/MGASA-2018-0228.html

Resolution: (none) => FIXED
Status: NEW => RESOLVED


Note You need to log in before you can comment on or make changes to this bug.