Bug 22950 - Unable to preview plymouth themes because x11.so is not being built
Summary: Unable to preview plymouth themes because x11.so is not being built
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: Stig-Ørjan Smelror
QA Contact:
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2018-04-25 09:22 CEST by Jeremiah Summers
Modified: 2018-04-27 13:27 CEST (History)
7 users (show)

See Also:
Source RPM: plymouth-0.9.3-1.mga7.src.rpm
CVE:
Status comment:


Attachments
Patch to remove compile option from spec (839 bytes, patch)
2018-04-25 09:24 CEST, Jeremiah Summers
Details | Diff

Description Jeremiah Summers 2018-04-25 09:22:10 CEST
Description of problem:
When trying to preview a plymouth theme using:

plymouthd; plymouth --show-splash & sleep 20 ; killall plymouthd

The screen does nothing when it's supposed to at least show a plymouth screen.


Version-Release number of selected component (if applicable):

0.9.3-1

How reproducible:

Every time

Steps to Reproduce:
1. login as root
2. run in bash plymouthd; plymouth --show-splash & sleep 20 ; killall plymouthd

The Fix:
running the above plymouthd command with --debug shows the issue. There's a missing library:

Could not load module "/usr/lib64/plymouth/renderers/x11.so": /usr/lib64/plymouth/renderers/x11.so: cannot open shared object file: No such file or directory

This missing library is cause by a compile flag:

--enable-gtk=no

Not sure why this is disabled, but when it is the package does not build x11.so.

If this can be changed I have created a patch to fix it in the rpm spec file and attached it to this ticket.. Thanks
Comment 1 Jeremiah Summers 2018-04-25 09:24:32 CEST
Created attachment 10104 [details]
Patch to remove compile option from spec

This patch bumps the release version, removed the compile option to allow x11.so to compile and updates the file section to include the x11.so library in the renderers library folder
Comment 2 Marja Van Waes 2018-04-25 13:23:46 CEST
Thanks for the report and patch, Jeremiah. I haven't managed to find a reason why gtk wasn't enabled in the changelog of plymouth (but have only searched for "gtk", "GTK", "x11" and "X11").

Assigning to all packagers collectively, since there is no registered maintainer for this package.

CC'ing some committers.

Assignee: bugsquad => pkg-bugs
CC: (none) => ghibomgx, mageia, marja11, olav, smelror, tmb, zen25000
Keywords: (none) => PATCH

Stig-Ørjan Smelror 2018-04-25 14:34:54 CEST

Assignee: pkg-bugs => smelror

Comment 3 Stig-Ørjan Smelror 2018-04-25 14:40:06 CEST
Hi.

Thanks for the patch.

An update has been pushed to the Build System, 0.9.3-2.

Cheers,
Stig
Comment 4 Jeremiah Summers 2018-04-25 16:52:48 CEST
Note that Suse (and Deb based distros) has this lib in it's own sub package plymouth-x11 and Fedora has it included in devel. This lib is not needed for Plymouth to work, but only to view Plymouth themes in X11. It's very helpful to have but if it causes issues Mageia may need to subpackage it and allow the user to install it if they want to mess with edit/creating Plymouth themes.
Comment 5 Thomas Backlund 2018-04-25 17:23:20 CEST
The gtk=no came in with 0.9.2 update (partial sync with omdv)
http://svnweb.mageia.org/packages/cauldron/plymouth/current/SPECS/plymouth.spec?r1=878073&r2=923177&pathrev=1222372


@Stig, you need to split out it as a plymouth-x11 subpackage to not bloat the deps on normal plymouth
Comment 6 Stig-Ørjan Smelror 2018-04-25 21:13:10 CEST
Thomas,

There are two other libraries in Plymouth, drm.so and frame-buffer.so.

Should these also be split into their own sub-packages?

Cheers,
Stig
Comment 7 Jeremiah Summers 2018-04-26 08:33:08 CEST
Frame-buffer should be fine where it's at and for the drm lib it's supported for anything that uses drm (kms) on boot. Both of these libs are boot focused, the x11 lib is not. There could be an argument made I think to remove drm and create it's own subpackage.. but I personally would not.

There is however a conflicts issue. You're rel is 3 and you have the conflicts for x11 conflicting with anything less then 4, so the current release of plymouth conflicts with plymouth-x11

The description for x11, could be a bit more descriptive. I like Suse's description for the package so you could adopt that.

"This package providesthe X11 renderer which allows to test plymouth 
behavior on environments with a valid DISPLAY."

You can then bump the release for the description update and that would then fix your conflicts.. so:

Release:	%mkrel 3

to:

Release:	%mkrel 4

And you should be good. Please after these get built on the BS test and make sure they at least install. I can test anything further for you.
Comment 8 Stig-Ørjan Smelror 2018-04-26 09:16:19 CEST
Thanks.

Issue rectified and pushed to the Build System.

Cheers,
Stig
Comment 9 Stig-Ørjan Smelror 2018-04-27 13:27:52 CEST
Fixed.

Status: NEW => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.