Bug 22829 - The vim spec file plugin is badly broken
Summary: The vim spec file plugin is badly broken
Status: REOPENED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal critical
Target Milestone: ---
Assignee: Thierry Vignaud
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-25 15:51 CEST by Johnny A. Solbu
Modified: 2020-08-16 18:42 CEST (History)
2 users (show)

See Also:
Source RPM: vim-8.2.1412-1.mga8.src.rpm
CVE:
Status comment:


Attachments

Description Johnny A. Solbu 2018-03-25 15:51:59 CEST
Ever since I learned rpm packaging, I've used the vim spec plugn to add changelog entries for packages I build for myself.

In mageia 6 I just noticed the plugins changelog entry function doesn't work.
When I type \ch to add a changelog, it ask me for my e-mail address.
I provide it, and then it spits out this, and does not add a changelog entry:

==
Error detected while processing function <SNR>23_SpecChangelog[49]..<SNR>23_GetRelVer:
line   20:
Traceback (most recent call last):
  File "<string>", line 17, in <module>
vim.error: Vim(let):E121: Undefined variable: mga6
==

I have no idea when it started, as I haven't done this in mga6 untill today. I still run mga5 on my main systems.

How reproducible:
Allways

Steps to Reproduce:
1. open a new none-existant spec file by typing «vim test.spec»
The spec template is not used to populate the spec file.

2: Open an existing spec file
3. type \ch to add a changelog entry
Comment 1 Marja Van Waes 2018-03-25 18:27:35 CEST
I've never known we had a vim spec plugin :-/

Our vim spec file does contain some references to spec template/changelog/rpm-spec-syntax etc, so I guess we really had it. Assigning to the registered maintainer

CC: (none) => marja11
Assignee: bugsquad => thierry.vignaud

Comment 2 Johnny A. Solbu 2018-03-25 22:22:55 CEST
(In reply to Marja van Waes from comment #1)
> I've never known we had a vim spec plugin :-/

I guess many doesn't know about it. :-)

I tested the old version from mga5, and that works on mga6 also.
It doesn't fix the template not loading, but it add changelog entries just fine.


The new upstream version obviously changed how things work. It is not the old version from Thierry, but his version still works.

Maybe we should replace it in Mageia with that version?
Comment 3 Johnny A. Solbu 2018-06-18 23:56:42 CEST
And now i know why the plugin is broken. It was DELETED and replaced by a version shiped with the upstream package that is _not_ tailored towards our needs. The diff is here:  http://svnweb.mageia.org/packages/cauldron/vim/current/SPECS/vim.spec?r1=1052488&r2=1052489

The curent, broken, version assumes it is used in a Fedora/RHEL environment.
When adding a changelog usind the current version, it keeps asking for my email address. THe old one found that by itself. The new version doesn't know how to handle our mkrel tag, the old version handle this just fine.

I propose to revert that specfic change.

Severity: major => critical

Comment 4 Aurelien Oudelet 2020-08-16 17:32:34 CEST
Mageia 6 changed to end-of-life (EOL) status on 2019-09-30. It is no longer 
maintained, which means that it will not receive any further security or bug 
fix updates.

Package Maintainer: If you wish for this bug to remain open because you plan 
to fix it in a currently maintained version, simply change the 'version' to 
a later Mageia version.

Bug Reporter: Thank you for reporting this issue and we are sorry that we 
weren't able to fix it before Mageia 6's end of life. If you are able to 
reproduce it against a later version of Mageia, you are encouraged to click 
on "Version" and change it against that version of Mageia.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a more recent
Mageia release includes newer upstream software that fixes bugs or makes them
obsolete.

If you would like to help fixing bugs in the future, don't hesitate to join the
packager team via our mentoring program [1] or join the teams that fit you 
most [2].

[1] https://wiki.mageia.org/en/Becoming_a_Mageia_Packager
[2] http://www.mageia.org/contribute/

Best regards,
Aurélien
Bugsquad Team

CC: (none) => ouaurelien
Resolution: (none) => OLD
Status: NEW => RESOLVED

Comment 5 Johnny A. Solbu 2020-08-16 18:40:47 CEST
Still valid for Cauldron.

Resolution: OLD => (none)
Status: RESOLVED => REOPENED
Version: 6 => Cauldron

Comment 6 Johnny A. Solbu 2020-08-16 18:42:33 CEST
Updating sourcerpm version tag

Source RPM: vim-8.0.388-1.mga6.src.rpm => vim-8.2.1412-1.mga8.src.rpm


Note You need to log in before you can comment on or make changes to this bug.