Bug 22794 - Installer fails to offer upgrade when partitioning use encryption (at least encrypted LVM)
Summary: Installer fails to offer upgrade when partitioning use encryption (at least e...
Status: NEW
Alias: None
Product: Mageia
Classification: Unclassified
Component: Installer (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal enhancement
Target Milestone: Mageia 9
Assignee: Mageia tools maintainers
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-17 18:04 CET by Morgan Leijström
Modified: 2021-02-03 00:49 CET (History)
3 users (show)

See Also:
Source RPM: drakx-installer-stage2
CVE:
Status comment:


Attachments
Log from command "bug" when partitioning shows up (29.50 KB, application/x-xz)
2018-03-17 18:10 CET, Morgan Leijström
Details

Description Morgan Leijström 2018-03-17 18:04:12 CET
Installer fail to offer upgrade when partitioning is advanced

Version-Release number of selected component (if applicable):
Mga6 iso tested, setting version=6 as we intend to ship 6.1.


How reproducible: any time per below


All this is using Mageia 6 install iso booted from USB

___Steps to Reproduce:

1. My Mageia systems are generally installed as follows, using installer to partition:  a separate ext4 /boot, then a large partition LVM, encrypted; and in that /, /home, swap 

Pretend grub got busted and you want to repair it:

2. Boot the installer .iso

3. Select install, select language,
-> it loads the disk drivers etc and investigates disks

Expected behaviour:  Show a screen where user can select install or upgrade
 http://doc.mageia.org/installer/6/en/content/selectInstallClass.html
That works for a system installed with traditional partitions
(tested OK here on msdos partitioned mech disk, and system set up with /, /home swap as suggested by default.)

What happens:  Detection take several seconds longer, and then skips directly to 
partitioning step.

( I then tried setting all mount points manually, deselect formatting, and proceeding - but then urpmi got stuck in a resolve loop. Bug 22782 )
Comment 1 Morgan Leijström 2018-03-17 18:10:11 CET
Created attachment 10051 [details]
Log from command "bug" when partitioning shows up

I see it search inside the LVM, but it should first ask user for LUKS key and unlock it, as LVM use the encrypted pv, as described...
Morgan Leijström 2018-03-17 18:11:05 CET

Summary: Installer fail to offer upgrade when partitioning is advanced => Installer fail to offer upgrade when partitioning use encryption (at least encrypted LVM)

Marja Van Waes 2018-03-17 18:12:17 CET

Assignee: bugsquad => mageiatools
Whiteboard: (none) => (MGA6) MGA6.1TOO
Source RPM: (none) => drakx-installer-stage2
CC: (none) => marja11, pterjan

Comment 2 Marja Van Waes 2018-03-17 18:26:24 CET
Installer bugs are always set to cauldron, because we can't fix an already released iso.
(MGA6) on the whiteboard shows the issue was last seen in MGA6, 
 MGA6.1TOO on the whiteboard shows the issue may affect Mageia 6.1, too

Summary: Installer fail to offer upgrade when partitioning use encryption (at least encrypted LVM) => Installer fails to offer upgrade when partitioning use encryption (at least encrypted LVM)
Version: 6 => Cauldron

Comment 3 Morgan Leijström 2018-03-17 18:40:24 CET
Probably related: Bug 22795 - The rescue system fails when system use LUKS (at least when on LVM inside it)

When fixed, tests should also be performed on a UEFI system set up like described above (LVM on LUKS), but formatted drive also have a EFI partition, and a windows partition.  - because that seemed to confuse the rescue system (that bug) even more.  If it matters that was a nVME SSD drive, GPT formatted so test that if possible.
Comment 4 Morgan Leijström 2018-03-20 11:43:30 CET
(In reply to Marja van Waes from comment #2)
> Installer bugs are always set to cauldron, because we can't fix an already
> released iso.
> (MGA6) on the whiteboard shows the issue was last seen in MGA6, 
>  MGA6.1TOO on the whiteboard shows the issue may affect Mageia 6.1, too

Marja, you seem to know these things well.
Could you update https://wiki.mageia.org/en/QA_whiteboard_keywords ?

BTW, i have asked that page to be linked from bug pages,  Bug 19637
Comment 5 Thierry Vignaud 2020-03-20 16:16:33 CET
About upgrading LUKS: it's not as straightforward as when using regular partitions but basically you've to:
- choose "Custom disk partitioning"
- enable your LUKS partitions ("Use")
- assign mount points to partitions
- choose not to format

That's not perfect but that does exist.
Ideally we should prompt for encrypting LUKS before going to the partition wizard but that may rise some user friendly questions…

Severity: normal => enhancement
CC: (none) => thierry.vignaud

Comment 6 Morgan Leijström 2020-03-24 00:48:22 CET
Yes that method i remember having used.
It should be documented...

... So now for Mageia 6 -> 7, i added the section
https://wiki.mageia.org/en/Mageia_7_Release_Notes#Upgrading_an_encrypted_install

Please see if i made some mistake.
Comment 7 Thierry Vignaud 2020-03-24 08:17:12 CET
Please copy it to https://wiki.mageia.org/en/Mageia_8_Release_Notes
Comment 8 Morgan Leijström 2020-03-24 11:26:33 CET
Good idea, done :)

Also announced (before that) on qa and doc -discuss lists for comments.
Comment 9 Morgan Leijström 2020-12-21 01:00:54 CET
I was pondering closing this as worksforme, but i like the idea in comment 5, in other words

If LUKS is found: Ask user if he wants to unlock.
Morgan Leijström 2021-02-03 00:49:15 CET

Target Milestone: --- => Mageia 9
Whiteboard: (MGA6) MGA6.1TOO => (none)


Note You need to log in before you can comment on or make changes to this bug.