Bug 22087 - cdrdao generates a cue file in an outdated format
Summary: cdrdao generates a cue file in an outdated format
Status: RESOLVED OLD
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 5
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: Shlomi Fish
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-26 19:34 CET by Len Lawrence
Modified: 2018-10-07 17:37 CEST (History)
1 user (show)

See Also:
Source RPM: cdrdao-1.2.3-10.mga5.tainted.src.rpm
CVE:
Status comment:


Attachments
Specimen cue file which works with bchunk. (3.46 KB, text/plain)
2017-11-26 19:40 CET, Len Lawrence
Details
"Bad" cue file (3.46 KB, text/plain)
2017-11-28 17:13 CET, Len Lawrence
Details
Terminal output from cdrdao during bad cue run (2.80 KB, text/plain)
2017-11-28 17:15 CET, Len Lawrence
Details
Specimen cue file which works with bchunk (2.80 KB, text/plain)
2017-11-29 13:03 CET, Len Lawrence
Details

Description Len Lawrence 2017-11-26 19:34:31 CET
Description of problem:
During QA testing it was discovered that bchunk fails to read a cue file generated by cdrdao; bchunk works on a bin/cue pair of files.  While trying to process the cue file bchunk reports that there is no space after track number, a message which comes from the area of the code around line 421; https://github.com/phracker/bchunk/blob/master/bchunk.c.  The question is, is there a later version of cdrdao which we could use?
Note that bchunk has no problem with a cue file edited according to the proforma  
at https://en.wikipedia.org/wiki/Cue_sheet_(computing).

Version-Release number of selected component (if applicable):
cdrdao-1.2.3-10.mga5.tainted
Mageia 6 is also affected by this fault.

How reproducible:
Always.

Steps to Reproduce:
1. Load a commercial audio CD in the optical disk drive slot
2. $ cdrdao read-cd <rootname-for-cue-file> 
3. Note the production of a data.bin file in the current directory with an associated .cue file.
4. Suggested test of cue file:
   $ bchunk data.bin <whatever>.cue <root of file names for the tracks>
e.g. $ bchunk data.bin CreedenceClearwater.cue CreedenceClearwater
This should fault immediately when bchunk fails to parse the cue file.
"Reading the CUE file:

Track  1: 
... ouch, no space after track number."
Comment 1 Len Lawrence 2017-11-26 19:40:48 CET
Created attachment 9803 [details]
Specimen cue file which works with bchunk.

The "data.bin" name has not been changed so this file could be used with any data.bin file, otherwise the name should be edited.  It might also need to be truncated because it indexes 29 tracks.
Comment 2 Len Lawrence 2017-11-26 19:51:07 CET
Note that I did not search to see if wikipedia has the last word on cue sheet formats.  There seemed to be some argument about format as late as September this year.  Forum posts at http://www.digital-inn.de/threads/why-i-hate-eac-malformed-cue-sheets.40013/page-3#post-148353
Comment 3 Marja Van Waes 2017-11-27 07:26:11 CET
Assigning to the registered cdrdrao maintainer.

Assignee: bugsquad => shlomif
CC: (none) => marja11

Comment 4 Shlomi Fish 2017-11-27 18:27:46 CET
(In reply to Len Lawrence from comment #0)
> Description of problem:
> During QA testing it was discovered that bchunk fails to read a cue file
> generated by cdrdao; bchunk works on a bin/cue pair of files.  While trying
> to process the cue file bchunk reports that there is no space after track
> number, a message which comes from the area of the code around line 421;
> https://github.com/phracker/bchunk/blob/master/bchunk.c.  The question is,
> is there a later version of cdrdao which we could use?

there is no later version and there hasn't been one for 8 years. There is little we can do without one.

> Note that bchunk has no problem with a cue file edited according to the
> proforma  
> at https://en.wikipedia.org/wiki/Cue_sheet_(computing).
> 
> Version-Release number of selected component (if applicable):
> cdrdao-1.2.3-10.mga5.tainted
> Mageia 6 is also affected by this fault.
> 
> How reproducible:
> Always.
> 
> Steps to Reproduce:
> 1. Load a commercial audio CD in the optical disk drive slot
> 2. $ cdrdao read-cd <rootname-for-cue-file> 
> 3. Note the production of a data.bin file in the current directory with an
> associated .cue file.
> 4. Suggested test of cue file:
>    $ bchunk data.bin <whatever>.cue <root of file names for the tracks>
> e.g. $ bchunk data.bin CreedenceClearwater.cue CreedenceClearwater
> This should fault immediately when bchunk fails to parse the cue file.
> "Reading the CUE file:
> 
> Track  1: 
> ... ouch, no space after track number."
Comment 5 Len Lawrence 2017-11-28 07:48:41 CET
Copy that Shlomi.  That makes this a WONTFIX then.  Leaving that to you.
Thanks.
Comment 6 Jani Välimaa 2017-11-28 13:50:42 CET
Well, we could patch cdrdao to create 'good' .cue files.. But for that we would need the 'bad' .cue file also to see the differences.
Comment 7 Len Lawrence 2017-11-28 15:54:09 CET
OK Jani, that can be done.  Uploading a specimen later.
Comment 8 Len Lawrence 2017-11-28 17:13:35 CET
Created attachment 9808 [details]
"Bad" cue file
Comment 9 Len Lawrence 2017-11-28 17:15:00 CET
Created attachment 9809 [details]
Terminal output from cdrdao during bad cue run
Comment 10 Jani Välimaa 2017-11-29 11:56:30 CET
(In reply to Len Lawrence from comment #8)
> Created attachment 9808 [details]
> "Bad" cue file

IINM this is identical with the good one..
Jani Välimaa 2017-11-29 12:13:23 CET

Attachment 9803 mime type: application/x-cue => text/plain

Jani Välimaa 2017-11-29 12:13:48 CET

Attachment 9808 mime type: application/x-cue => text/plain

Comment 11 Len Lawrence 2017-11-29 13:01:54 CET
Drat.  Finger trouble.
A thousand apologies Jani.  Picked up the wrong "good" file.  Uploading a replacement - which I shall check!
Comment 12 Len Lawrence 2017-11-29 13:03:27 CET
Created attachment 9813 [details]
Specimen cue file which works with bchunk

Attachment 9803 is obsolete: 0 => 1

Len Lawrence 2017-11-29 13:10:51 CET

Attachment 9813 mime type: application/x-cue => text/plain

Comment 13 Marja Van Waes 2018-10-02 10:02:12 CEST
Does this report need to stay open for Mageia 6 and/or cauldron?
Comment 14 Len Lawrence 2018-10-02 11:20:01 CEST
In reply to marja comment 13.
Probably not for Mageia 6.
When I have some spare time I shall check how this works in Cauldron.
Comment 15 Marja Van Waes 2018-10-07 17:37:11 CEST
(In reply to Len Lawrence from comment #14)
> In reply to marja comment 13.
> Probably not for Mageia 6.
> When I have some spare time I shall check how this works in Cauldron.

Thanks for the reply.

If Mageia 6 is fine, then Cauldron will, as good as sure, be fine, too.

Closing as OLD, because Mga5 is no longer maintained.

Status: NEW => RESOLVED
Resolution: (none) => OLD


Note You need to log in before you can comment on or make changes to this bug.