Bug 21755 - rawtherapee new security issues CVE-2017-13735, CVE-2017-14265, CVE-2017-14348
Summary: rawtherapee new security issues CVE-2017-13735, CVE-2017-14265, CVE-2017-14348
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: Security (show other bugs)
Version: 6
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: QA Team
QA Contact: Sec team
URL:
Whiteboard: MGA5TOO MGA6-64-OK MGA5-32-OK MGA6-32-OK
Keywords: advisory, has_procedure, validated_update
Depends on: 21716
Blocks:
  Show dependency treegraph
 
Reported: 2017-09-22 17:13 CEST by David Walser
Modified: 2017-10-05 22:38 CEST (History)
8 users (show)

See Also:
Source RPM: rawtherapee-5.2-1.mga7.src.rpm
CVE:
Status comment:


Attachments

Description David Walser 2017-09-22 17:13:14 CEST
+++ This bug was initially created as a clone of Bug #21716 +++

Fedora has issued an advisory today (September 15):
https://lists.fedoraproject.org/archives/list/package-announce@lists.fedoraproject.org/thread/TVI7PQ5NTNFOL4EQTLNZOPGCDLKJKXST/

The issues are fixed upstream in 0.18.4:
https://www.libraw.org/news/libraw-0-18-4

It looks like other things that embed this code are also affected, like we've seen in the past.  Fedora lists dcraw, libkdcraw, and rawtherapee as examples, and has issued an advisory for rawtherapee:
https://lists.fedoraproject.org/archives/list/package-announce@lists.fedoraproject.org/thread/CMHXYQOFX5OQSBWNNMCVGJLYXTZHXYTM/
David Walser 2017-09-22 17:13:31 CEST

Source RPM: libraw-0.18.2-1.mga6.src.rpm => rawtherapee-5.2-1.mga7.src.rpm
Whiteboard: (none) => MGA6TOO, MGA5TOO

Comment 1 Marja Van Waes 2017-09-22 19:03:27 CEST
Assigning to the registered maintainer.

Assignee: bugsquad => mrambo

David Walser 2017-09-25 16:53:30 CEST

Summary: rawtherapee new security issues CVE-2017-13735 and CVE-2017-14265 => rawtherapee new security issues CVE-2017-13735, CVE-2017-14265, CVE-2017-14348

Comment 2 Mike Rambo 2017-09-28 19:38:18 CEST
Patched package uploaded for cauldron, Mageia 6 and 5.

Advisory:
========================

Patched rawtherapee package fixes security vulnerabilities:

It was discovered that rawtherapee had a floating point exception in the kodak_radc_load_raw function in dcraw.cc (CVE-2017-13735).

It was discovered that rawtherapee had a Heap-based 1 byte buffer overflow in the processCanonCameraInfo function in dcraw.c (CVE-2017-14348).

It was discovered that rawtherapee had a Stack Buffer Overflow in xtrans_interpolate in dcraw.c that could allow a remote denial of service and code execution attack (CVE-2017-14265).

References:
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-13735
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-14348
http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2017-14265
https://github.com/Beep6581/RawTherapee/issues/4061
https://github.com/Beep6581/RawTherapee/issues/4084
https://github.com/LibRaw/LibRaw/issues/99
========================

Updated packages in core/updates_testing:
========================
rawtherapee-5.1-1.2.mga6
rawtherapee-4.1-4.2.mga5

from:
rawtherapee-5.1-1.2.mga6.src.rpm
rawtherapee-4.1-4.2.mga5.src.rpm


Testing procedure https://bugs.mageia.org/show_bug.cgi?id=12693#c7

Whiteboard: MGA6TOO, MGA5TOO => MGA5TOO
Keywords: (none) => has_procedure
Assignee: mrambo => qa-bugs
Version: Cauldron => 6

Comment 3 Len Lawrence 2017-09-29 12:35:20 CEST
Had a look at this for mga6::x86_64.

There are PoCs, which need libraw tools.  No package name for 64-bits so installed libraw-tools which supplies the multirender_test program in /bin.
  
Downloaded some of the samples from the link in bug 12693#c7.

About to check the PoCs.

CC: (none) => tarazed25

Comment 4 Len Lawrence 2017-09-29 17:00:15 CEST
Summary of upstream PoCs

CVE-2017-13735
https://bugzilla.redhat.com/show_bug.cgi?id=1483988
Expected output:
$ multirender_test POC1
Processing file POC1
Floating point exception

CVE-2017-14348
https://github.com/LibRaw/LibRaw/issues/100
ASAN testing
$ raw-identify libraw-0.18.3-heap-buffer-overflow-processCanonCameraInfo.cr2
Aborting

CVE-2017-14265
ASAN testing
$ simple_dcraw crash-xtrans_interpolate-stack-overflow
Aborting

----------------------------------------------------------------------------

Before update:

$ multirender_test POC1
Processing file POC1
Floating point exception (core dumped)

$ raw-identify libraw-0.18.3-heap-buffer-overflow-processCanonCameraInfo.cr2
Cannot decode libraw-0.18.3-heap-buffer-overflow-processCanonCameraInfo.cr2: Unsupported file format or not RAW file

$ simple_dcraw crash-xtrans_interpolate-stack-overflow
Segmentation fault (core dumped)

----------------------------------------------------------------------------

Installed updated rawtherapee

After update:

$ multirender_test POC1
Processing file POC1
Floating point exception (core dumped)

$ raw-identify libraw-0.18.3-heap-buffer-overflow-processCanonCameraInfo.cr2
Cannot decode libraw-0.18.3-heap-buffer-overflow-processCanonCameraInfo.cr2: Unsupported file format or not RAW file

$ simple_dcraw crash-xtrans_interpolate-stack-overflow
$

The core dump for the first test is disappointing but the other two look OK.

----------------------------------------------------------------------------

Launched rawtherapee in the RAW images directory.  The whole set of images was displayed.  Used some of the controls to color-tag and rank images, cropped an image, used flip, flop and rotate.  Opened images with a double-click and saved a couple of images in png and jpeg formats.  Those displayed fine.

Giving this an OK.
Len Lawrence 2017-09-29 17:01:00 CEST

Whiteboard: MGA5TOO => MGA5TOO MGA6-64-OK

Comment 5 Len Lawrence 2017-09-29 17:04:02 CEST
Forgot the link for CVE-2017-14265
https://github.com/LibRaw/LibRaw/issues/99
Comment 6 Herman Viaene 2017-09-30 14:08:58 CEST
MGA5-32 on Asus A6000VM Xfce
No installation issues.
Played around with lighting parameters of raw images, and save the result. All looks OK

CC: (none) => herman.viaene
Whiteboard: MGA5TOO MGA6-64-OK => MGA5TOO MGA6-64-OK MGA5-32-OK

Comment 7 Herman Viaene 2017-09-30 16:40:06 CEST
MGA6-32 on Asus A6000VM MATENo installation issues.
Played around with lighting parameters of raw images, and save the result. This laptop is too slow to do much more.All looks OK

Whiteboard: MGA5TOO MGA6-64-OK MGA5-32-OK => MGA5TOO MGA6-64-OK MGA5-32-OK MGA6-32-OK

Comment 8 Lewis Smith 2017-09-30 20:40:13 CEST
Advisory from comments 2 & 0.
Validating, 3/4 confirmations.

Keywords: (none) => advisory, validated_update
CC: (none) => lewyssmith, sysadmin-bugs

Comment 9 Mageia Robot 2017-10-05 22:38:40 CEST
An update for this issue has been pushed to the Mageia Updates repository.

https://advisories.mageia.org/MGASA-2017-0359.html

Resolution: (none) => FIXED
Status: NEW => RESOLVED


Note You need to log in before you can comment on or make changes to this bug.