Bug 2103 - AfterStep menu shows "MandrivaLinux"
Summary: AfterStep menu shows "MandrivaLinux"
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 1
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: Remco Rijnders
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-10 12:41 CEST by Remco Rijnders
Modified: 2011-08-19 10:26 CEST (History)
2 users (show)

See Also:
Source RPM: AfterStep-2.2.11-1.mga1.src.rpm
CVE:
Status comment:


Attachments

Description Remco Rijnders 2011-07-10 12:41:31 CEST
The menu in AfterStep shows "MandrivaLinux" at the top.

This is the result of the patch AfterStep-1.8.9-menuname.patch being applied in the package sources. Either this patch should be removed, or amended to properly display "Mageia".
Samuel Verschelde 2011-07-24 16:57:51 CEST

CC: (none) => stormi
Assignee: bugsquad => remco

Comment 1 Shlomi Fish 2011-08-18 17:04:07 CEST
Can confirm. I'll try to get to fixing it.

CC: (none) => shlomif

Comment 2 Shlomi Fish 2011-08-18 17:13:03 CEST
(In reply to comment #1)
> Can confirm. I'll try to get to fixing it.

Upon investigation, I found out that the patch in question had already corrected in the repository back in July, but a new release was not released.

I'm now going to bump the new release and submit a new version.

Regards,

-- Shlomi Fish
Comment 3 Shlomi Fish 2011-08-18 17:19:21 CEST
OK, I submitted a new package to be fixed in Cauldron. Should we also submit it to Mageia 1?

Regards,

-- Shlomi Fish
Comment 4 Samuel Verschelde 2011-08-18 17:26:04 CEST
I think so. Maybe Remco can prepare it as a packaging mentoring program task.
Comment 5 Remco Rijnders 2011-08-18 19:26:06 CEST
Hi Shlomi,

Thanks for looking into this. Since I opened this bug report, I've started as a 'trainee' and uploaded the fix back in July myself. My mentor had assigned this bug to me.

As I can't submit packages yet, I can't push it myself to the buildsystem. I'm not sure if asked Samuel to push it, or that I wanted to see about making some more changes myself first. For example, the default configuration of afterstep expects to find "asclock" which was missing from Mageia before that I've since packaged and which has found its way into Cauldron.

Given the low number (I assume) of Mageia AfterStep users, I'm not sure if this menu fix is enough to warrant an update to 1, though I'm not opposed to it either.

Finally, all that said and done, it looks like the package submitted failed to build. I'm a bit surprised to see this actually as it doesn't seem related to any change you or I have made. Any ideas you have on that are most appreciated!
Comment 6 Shlomi Fish 2011-08-19 10:26:12 CEST
Hi Remco,

(In reply to comment #5)
> Hi Shlomi,
> 
> Thanks for looking into this. Since I opened this bug report, I've started as a
> 'trainee' and uploaded the fix back in July myself. My mentor had assigned this
> bug to me.

Ah, OK.

> 
> As I can't submit packages yet, I can't push it myself to the buildsystem. I'm
> not sure if asked Samuel to push it, or that I wanted to see about making some
> more changes myself first. For example, the default configuration of afterstep
> expects to find "asclock" which was missing from Mageia before that I've since
> packaged and which has found its way into Cauldron.
> 

OK.

> Given the low number (I assume) of Mageia AfterStep users, I'm not sure if this
> menu fix is enough to warrant an update to 1, though I'm not opposed to it
> either.
> 

In that case I won't release it for Mageia 1 (but someone else can.).

> Finally, all that said and done, it looks like the package submitted failed to
> build. I'm a bit surprised to see this actually as it doesn't seem related to
> any change you or I have made. Any ideas you have on that are most
> appreciated!

The problem there was that the AfterStep makefiles are not fail-proof for parallel builds (e.g: "make -j2"), because they sometimes have:

all: libAfterStep.a program-that-depends-on-libAfterStep.a

And the program-that-depends does not have libAfterStep.a in its make dependencies. So it failed to parallel build in this case (but may otherwise succeed other times by chance.).

Then there was a problem that %make_session was deprecated and no longer used and I had to remove the %post and %postun sections, but now the package has been uploaded with all the fixed.

So I'm going to close this bug and sorry if I interfered. Next time please convey the "trainee" intentions for the package.

Regards,

-- Shlomi Fish

Status: NEW => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.