Bug 20868 - Adwaita GTK+ theme is not selectable in GNOME tweak tool
Summary: Adwaita GTK+ theme is not selectable in GNOME tweak tool
Status: NEW
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal normal
Target Milestone: Mageia 6
Assignee: GNOME maintainers
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-16 09:41 CEST by Martin Whitaker
Modified: 2017-07-11 22:19 CEST (History)
1 user (show)

See Also:
Source RPM: task-gnome, meta-task?
CVE:
Status comment:


Attachments
gnome without adwaita-gtk2-theme (220.32 KB, image/png)
2017-07-11 08:29 CEST, Chris B
Details
gnome with adwaita-gtk2-theme (220.32 KB, image/png)
2017-07-11 08:30 CEST, Chris B
Details
really gnome without adwaita-gtk2-theme (238.70 KB, image/png)
2017-07-11 08:33 CEST, Chris B
Details

Description Martin Whitaker 2017-05-16 09:41:44 CEST
On a clean GNOME install from the Mageia-6-rc-x86_64-DVD ISO, after installing GNOME Tweak Tool, Tweak Tool shows a blank for the current GTK+ theme selection. When using the drop-drown list to select a GTL+ theme, the only option available is "High Contrast". If you select that, the theme changes correctly, but then there is no way to get back to the default Adwaita theme.

Installing the adwaita-gtk2-theme package fixes this. Should this get installed by default?
Comment 1 Rémi Verschelde 2017-05-16 09:48:07 CEST
IIRC, we want to enforce Adwaita for GTK+2 on GNOME, so it should be installed by default. Assigning to the gnome@ maintainer group for confirmation and/or fix.

Assignee: bugsquad => gnome
Source RPM: (none) => task-gnome, meta-task?

Rémi Verschelde 2017-05-16 09:48:17 CEST

Target Milestone: --- => Mageia 6

Comment 2 Samuel Verschelde 2017-07-10 15:24:39 CEST
(In reply to Rémi Verschelde from comment #1)
> IIRC, we want to enforce Adwaita for GTK+2 on GNOME, so it should be
> installed by default. Assigning to the gnome@ maintainer group for
> confirmation and/or fix.

Gnome maintainers or users, any comment to confirm whether it's a bug or wanted?

If it's a bug it would be good to add a note about this in the Errata.
Comment 3 Olav Vitters 2017-07-10 21:37:00 CEST
No clue. gnome-tweak-tools should NOT depend on anything gtk+2.x. So maybe the bug is elsewhere. Maybe quick fix is to ensure it is installed via meta-task as a require seems wrong.

CC: (none) => olav

Comment 4 Olav Vitters 2017-07-10 21:44:59 CEST
Checked source, gnome-tweak-tool really only shows themes with GTK+2.x and GTK+3.x support. Ugh
Comment 5 Chris B 2017-07-10 22:06:54 CEST
Olav, the issue is not the tweak-tool, but a default M6 Gnome (only) install does not include the adwaita-gtk2-theme package. All (by default) installed gtk+2 applications look horrible, f.e. Gimp. It's embarrasing :p
With the theme installed they look good :)

rpmsrate, meta-task or task-gnome could take care of it, I guess.

For Gnome Live, Martin has already manually included the adwaita-gtk2, but the CI and netinstall are still affected.

CC: (none) => shybluenight

Comment 6 Olav Vitters 2017-07-11 00:52:04 CEST
Ok, then the solution should be a Recommends or Require on lib*gtk+2.x
Comment 7 Chris B 2017-07-11 08:29:15 CEST
Created attachment 9483 [details]
gnome without adwaita-gtk2-theme

No, gnome needs the adwaita-gtk2-theme package.
See screenshots without the theme package, and with the package included.
Comment 8 Chris B 2017-07-11 08:30:33 CEST
Created attachment 9484 [details]
gnome with adwaita-gtk2-theme

screenshot gnome with adwaita-gtk2-theme package
Comment 9 Rémi Verschelde 2017-07-11 08:33:18 CEST
You posted the with adwaita-gtk2 screenshot twice ;)
Comment 10 Chris B 2017-07-11 08:33:41 CEST
Created attachment 9485 [details]
really gnome without adwaita-gtk2-theme

skip the first screenshot, here is the one without adwaita-gtk2-theme package installed.
Comment 11 Olav Vitters 2017-07-11 10:06:02 CEST
(In reply to Chris B from comment #7)
> No, gnome needs the adwaita-gtk2-theme package.
> See screenshots without the theme package, and with the package included.

You're posting a screenshot of GIMP. That's a gtk+2.x package which is NOT part of GNOME. By default GTK+3.x uses Adwaita. As such gtk+2.x should have Adwaita as well. That some other desktops prefer some other theme or have one extra dependency is because the theme is changed from the default.
Comment 12 Chris B 2017-07-11 10:13:44 CEST
 
Gimp and other gtk+2 applications are part of our default single Gnome installation.
You are not interested, how it looks? Fine with me, I'm not even a gnome user, just a member of the QA team.

I'm giving up.
Comment 13 Rémi Verschelde 2017-07-11 11:00:15 CEST
(In reply to Olav Vitters from comment #11)
> (In reply to Chris B from comment #7)
> > No, gnome needs the adwaita-gtk2-theme package.
> > See screenshots without the theme package, and with the package included.
> 
> You're posting a screenshot of GIMP. That's a gtk+2.x package which is NOT
> part of GNOME. By default GTK+3.x uses Adwaita. As such gtk+2.x should have
> Adwaita as well. That some other desktops prefer some other theme or have
> one extra dependency is because the theme is changed from the default.

I feel like we've been discussing this for years and we're no closer to a resolution...

GTK+3 uses Adwaita as default theme.
GTK+2 uses Raleigh as default theme, and it's arguably very old fashioned, if not ugly.

GTK+2/Raleigh applications in a GTK+3/Adwaita environment look very out of place, like e.g. GIMP or LibreOffice in the out-of-the-box GNOME environment on Mageia (but also on other DEs).

So gtk+2.0 should recommend adwaita-gtk2-theme to ensure that we have a sane default theme, and meta-task should install it out of the box. If some users really don't want adwaita-gtk2, they can then uninstall it.
Chris B 2017-07-11 11:48:38 CEST

CC: shybluenight => (none)

Comment 14 Olav Vitters 2017-07-11 22:19:07 CEST
(In reply to Chris B from comment #12)
> I'm giving up.

Great, then I'll fix this the way that I deem right. That means an additional dependency on gtk+2.x.

The not caring: whatever, I proposed a solution and you rejected it, then stating you're only QA.

Note You need to log in before you can comment on or make changes to this bug.