Bug 20687 - Remove warning in identity.m.o about the encoding parameter
Summary: Remove warning in identity.m.o about the encoding parameter
Status: RESOLVED FIXED
Alias: None
Product: Infrastructure
Classification: Unclassified
Component: Others (show other bugs)
Version: unspecified
Hardware: All Linux
Priority: Low minor
Target Milestone: ---
Assignee: Frédéric "LpSolit" Buclin
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-17 14:12 CEST by Frédéric "LpSolit" Buclin
Modified: 2017-04-17 16:49 CEST (History)
1 user (show)

See Also:
Source RPM:
CVE:
Status comment:


Attachments
proposed fix (3.06 KB, patch)
2017-04-17 14:13 CEST, Frédéric "LpSolit" Buclin
Details | Diff
patch (3.83 KB, patch)
2017-04-17 15:11 CEST, Frédéric "LpSolit" Buclin
Details | Diff
patch #2 (942 bytes, patch)
2017-04-17 15:37 CEST, Frédéric "LpSolit" Buclin
Details | Diff

Description Frédéric "LpSolit" Buclin 2017-04-17 14:12:19 CEST
[warn] Unicode::Encoding plugin is auto-applied, please remove this from your appclass and make sure to define "encoding" config
Comment 1 Frédéric "LpSolit" Buclin 2017-04-17 14:13:33 CEST
Created attachment 9210 [details]
proposed fix
Comment 2 Frédéric "LpSolit" Buclin 2017-04-17 14:19:47 CEST
I bumped the min version of Catalyst::Runtime to 5.90042 which has the Unicode::Encoding plugin in core, and also defined the 'encoding' parameter to UTF-8, as specified in the warning above. Now the warning is gone.

I also removed the <meta name="keywords"> tag as it's no longer used by search engines.

Ideally, we should require Catalyst::Runtime 5.90080 which has a better support for UTF8, but Mageia 5 only has 5.90071.
Comment 3 Frédéric "LpSolit" Buclin 2017-04-17 15:11:00 CEST
Created attachment 9211 [details]
patch

Looks like I cannot commit this patch myself, so here is a new patch using "format-patch".

Attachment 9210 is obsolete: 0 => 1

Comment 4 Mageia Robot 2017-04-17 15:17:31 CEST
commit 9981494a9e4f2272b85eb3a5672b8b7392d52ca1
Author: Frédéric Buclin <LpSolit@...>
Date:   Mon Apr 17 15:00:08 2017 +0200

    Remove a warning about the encoding parameter (mga#20687)
---
 Commit Link:
   http://gitweb.mageia.org/web/identity/commit/?id=9981494a9e4f2272b85eb3a5672b8b7392d52ca1
Comment 5 Mageia Robot 2017-04-17 15:17:48 CEST
commit 3f0349b374e0883fe4ddada7286aef73da1e376e
Author: Frédéric Buclin <LpSolit@...>
Date:   Mon Apr 17 15:00:08 2017 +0200

    Remove a warning about the encoding parameter (mga#20687)
---
 Commit Link:
   http://gitweb.mageia.org/web/identity/commit/?id=3f0349b374e0883fe4ddada7286aef73da1e376e
Comment 6 Frédéric "LpSolit" Buclin 2017-04-17 15:21:58 CEST
fixed

Resolution: (none) => FIXED
Status: ASSIGNED => RESOLVED

Comment 7 Frédéric "LpSolit" Buclin 2017-04-17 15:37:08 CEST
Created attachment 9212 [details]
patch #2

I just realized that the charset meta tag is wrong. This 2nd patch fixed it.
Comment 8 Mageia Robot 2017-04-17 16:49:36 CEST
commit 095c37d101b02508b745ff12e6f48e8e3458cdf2
Author: Frédéric Buclin <LpSolit@...>
Date:   Mon Apr 17 15:31:03 2017 +0200

    Fix the charset meta tag (mga#20687)
---
 Commit Link:
   http://gitweb.mageia.org/web/identity/commit/?id=095c37d101b02508b745ff12e6f48e8e3458cdf2
Comment 9 Mageia Robot 2017-04-17 16:49:42 CEST
commit 7c020a3bc61a5922f607734e65f33bf7d6523f5b
Author: Frédéric Buclin <LpSolit@...>
Date:   Mon Apr 17 15:31:03 2017 +0200

    Fix the charset meta tag (mga#20687)
---
 Commit Link:
   http://gitweb.mageia.org/web/identity/commit/?id=7c020a3bc61a5922f607734e65f33bf7d6523f5b

Note You need to log in before you can comment on or make changes to this bug.