Bug 20681 - Mageia Welcome does not display correctly in GNOME on Wayland
Summary: Mageia Welcome does not display correctly in GNOME on Wayland
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: release_blocker normal
Target Milestone: ---
Assignee: Daniel Napora
QA Contact:
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2017-04-16 00:37 CEST by Martin Whitaker
Modified: 2017-05-15 12:08 CEST (History)
6 users (show)

See Also:
Source RPM: mageiawelcome
CVE:
Status comment:


Attachments
Initial display (201.82 KB, image/png)
2017-04-16 00:37 CEST, Martin Whitaker
Details
Second display (184.96 KB, image/png)
2017-04-16 00:39 CEST, Martin Whitaker
Details
third display (348.22 KB, image/png)
2017-04-16 00:40 CEST, Martin Whitaker
Details
good display on working setup (116.57 KB, image/png)
2017-05-06 17:32 CEST, Rémi Verschelde
Details
bad display on non-working setup (159.26 KB, image/png)
2017-05-06 18:23 CEST, Martin Whitaker
Details

Description Martin Whitaker 2017-04-16 00:37:04 CEST
Created attachment 9203 [details]
Initial display

The only defect in the initial display is that the "Show this window at startup" checkbox and "Close" button overlap the "Bugzilla" and "Join us" buttons...
Comment 1 Martin Whitaker 2017-04-16 00:39:04 CEST
Created attachment 9204 [details]
Second display

but on switching to the "Applications" tab, the list of applications is displayed below the category list, causing the window to grow...
Comment 2 Martin Whitaker 2017-04-16 00:40:02 CEST
Created attachment 9205 [details]
third display

and on switching back to the "Welcome" tab, the whole thing is scrambled.
Comment 3 Martin Whitaker 2017-04-16 00:41:09 CEST
This doesn't occur when running GNOME on Xorg.
Comment 4 Marja Van Waes 2017-04-16 11:36:59 CEST
@ Napcok

I'm not sure I should assign this bug to you, but I am sure you can figure out whom it should be assigned to, if this can't be solved on MageiaWelcome side :-)

Please reassign if needed.

Assignee: bugsquad => napcok
CC: (none) => gnome, marja11
Source RPM: (none) => mageiawelcome

Comment 5 Martin Whitaker 2017-04-24 21:33:18 CEST
Actually there's a second defect in the initial display - the window isn't quite wide enough, causing the right hand column of buttons to be truncated. And this window width is what's causing the display problems in the Applications tab. I've had a quick look at the HTML, but I can't see what sets the window size.

Setting this to a release blocker, because it is a significant flaw on the GNOME Live DVD.

Priority: Normal => release_blocker

Comment 6 Chris B 2017-04-25 12:46:12 CEST
/usr/share/mageiawelcome/webgui.py

window.set_resizable(False)  --> window.set_resizable(True)

That is very ugly, but it automatically resizes without user intervention. Issue: if I manually resize the window, it is stuck at this size.
I've tested if it introduces new bugs in Xfce, probably not. I can't test plasma/kde/other DE's.

I'm not a html/js expert, and I'm sorry to say this, I've spend already too much time to debug this poor code, and this poor design.

This is very personal: If it was me I would nuke the whole Welcome app. Maybe replace it with a simple local html page in Firefox.

CC: (none) => shybluenight

Comment 7 Rémi Verschelde 2017-05-06 14:48:30 CEST
I just tried in a VirtualBox VM that had just been upgraded for an all-DE Mageia 5 to an all-DE Mageia 6, and I can't reproduce that issue on GNOME (Wayland).
Comment 8 Martin Whitaker 2017-05-06 15:18:07 CEST
(In reply to Rémi Verschelde from comment #7)
> I just tried in a VirtualBox VM that had just been upgraded for an all-DE
> Mageia 5 to an all-DE Mageia 6, and I can't reproduce that issue on GNOME
> (Wayland).

I've just tested an upgrade of a GNOME-only mga5 to GNOME-only mga6 in Vbox (on a mga6 host), and have reproduced the issue.
Comment 9 Rémi Verschelde 2017-05-06 15:20:00 CEST
(In reply to Martin Whitaker from comment #8)
> 
> I've just tested an upgrade of a GNOME-only mga5 to GNOME-only mga6 in Vbox
> (on a mga6 host), and have reproduced the issue.

So it may be that some additional dependencies due to my multi-DE setup play a role. Or that starting mageiawelcome first on Plasma 5 before trying GNOME 3 changed something.
Comment 10 Frédéric "LpSolit" Buclin 2017-05-06 15:25:41 CEST
Can you reproduce in Virtualbox only? If yes, then this may be because Virtualbox doesn't support Wayland yet, see https://www.virtualbox.org/ticket/13471.
Comment 11 Martin Whitaker 2017-05-06 15:29:37 CEST
(In reply to Rémi Verschelde from comment #9)
> So it may be that some additional dependencies due to my multi-DE setup play
> a role. Or that starting mageiawelcome first on Plasma 5 before trying GNOME
> 3 changed something.

Did you get a Close button at the bottom of the initial screen? If not, the behaviour is a bit different - and less noticeably wrong.
Comment 12 Martin Whitaker 2017-05-06 15:37:17 CEST
(In reply to Frédéric Buclin from comment #10)
> Can you reproduce in Virtualbox only? If yes, then this may be because
> Virtualbox doesn't support Wayland yet, see
> https://www.virtualbox.org/ticket/13471.

We use the 'modesetting' driver, not 'vboxvideo'. I've seen no other issues with GNOME on Wayland with this combination.

I can reproduce on real H/W (64-bit Live GNOME on USB stick).
Comment 13 Rémi Verschelde 2017-05-06 17:32:52 CEST
Created attachment 9267 [details]
good display on working setup

Here's how it looks like for me. I do have the Close button.
Comment 14 Martin Whitaker 2017-05-06 18:23:31 CEST
Created attachment 9269 [details]
bad display on non-working setup

And here's what it looks like on my mga5->mga6 upgrade using the same screen resolution. As you can see, the base window is smaller, which is what is causing the problems.

I've tried adding Plasma to my install and switching to SDDM, but still get the same result. And in Plasma on Wayland, mageiawelcome doesn't display anything at all.
Comment 15 Lewis Smith 2017-05-11 11:44:10 CEST
When I first spotted this as per attachment 9269 [details], I cannot remember in what context, the truncated screen *only showed on the very first instance* of Mageia Welcome, first re-boot; any subsequent invocation was correct.
On a Classic install (ex 8 May), selecting just 'Gnome' in the SDDM login menu (= Wayland, I believe, as XOrg is a different choice), specifically invoking Welcome produces a correct window. I will try from a Gnome Live installation.

CC: (none) => lewyssmith

Comment 16 Lewis Smith 2017-05-11 12:07:12 CEST
From Gnome installation ex latest Live ISO of 27 April, Mageia Welcome is showing correctly. Looking at my PAD notes for 1st re-boot, I noted Welcome as OK even then (unless I ignored the 'truncated' issue as being too familiar, & trivial).
Comment 17 Lewis Smith 2017-05-11 14:07:03 CEST
Having discovered bug 19293, they look (as this one is first described) duplicates.

My Comment 15 was premature (I had not run through the Gnome desktop). Having now explored further but not fully Mageia Welcome under Classic/Gnome and Gnome/Live, accepting that problems arise just under Wayland, XOrg OK, I revise my verdict:

Gnome/Wayland ex Classic ISO: When first fired up, MW looks OK - but the window *is* in my case marginally truncated right & bottom, the bottom buttons visible, so you hardly notice. Exploring further, the 4 'welcome' choices display OK (but yes, subtly trimmed). OTOH the minute you use the 'programs' tab - chaos. Chris had reported this, but I cannot find a bug for it. Would this come under this bug, or a different one? And if it was fixed, would it also address the clipped MW window issue causing this bug?

Gnome/Wayland ex Live ISO: I cannot fault MW! The problems above are simply absent.
Comment 18 Chris B 2017-05-11 15:28:21 CEST
Could we just start the Welcome app with 'GDK_BACKEND=x11'?

I've just done it, Live Gnome iso, wayland, from a terminal:
GDK_BACKEND=x11 mageiawelcome-launcher

As expected, all is well.
Comment 19 Martin Whitaker 2017-05-12 09:41:37 CEST
(In reply to Chris B from comment #18)
> Could we just start the Welcome app with 'GDK_BACKEND=x11'?
> 
> I've just done it, Live Gnome iso, wayland, from a terminal:
> GDK_BACKEND=x11 mageiawelcome-launcher
> 
> As expected, all is well.

Nice find Chris! I confirm this works for me too. It can be automated by changing the line

  os.system("python3 /usr/share/mageiawelcome/mageiawelcome.py")

in /bin/mageiawelcome to

  os.system("GDK_BACKEND=x11 python3 /usr/share/mageiawelcome/mageiawelcome.py")

I've tested this in Plasma as well, and see no regressions.
Thierry Vignaud 2017-05-12 15:53:42 CEST

CC: (none) => thierry.vignaud
Keywords: (none) => PATCH

Comment 20 Mageia Robot 2017-05-13 11:24:10 CEST
commit c9f23163b66395bcc091b72f8c34149a24e46b61
Author: Papoteur <papoteur@...>
Date:   Sat May 13 11:21:39 2017 +0200

    Workaround display glitch on Gnome Wayland (mga#20681)
---
 Commit Link:
   http://gitweb.mageia.org/software/mageiawelcome/commit/?id=c9f23163b66395bcc091b72f8c34149a24e46b61
Comment 21 Frédéric "LpSolit" Buclin 2017-05-13 15:55:46 CEST
I guess this bug can be closed, now?
Comment 22 Nicolas Lécureuil 2017-05-13 16:52:25 CEST
Closing

Please reopen if it appears still valid for you

Status: NEW => RESOLVED
CC: (none) => mageia
Resolution: (none) => FIXED

Comment 23 Lewis Smith 2017-05-13 23:34:50 CEST
On Gnome Live installation ISO dated 13 May, real EFI hardware, Radeon video.
Confirm that Mageia Welcome looks OK all round under default GDM 'Gnome' entry => Wayland. My Comment 17 says it did previously, anyway. (Await next Classic).
Comment 24 Lewis Smith 2017-05-15 12:08:49 CEST
Confirm all OK on latest 14 May Classic installation 6 desktops.
On Gnome (default = Wayland) from SDDM display manager login, Mageia Welcome looks perfect, both sides. No clipping, nor the chaos noted in Comment 17.

Note You need to log in before you can comment on or make changes to this bug.