Bug 20387 - Closing embedded diskdrake modules in MCC with "x" does not return to the MCC menu
Summary: Closing embedded diskdrake modules in MCC with "x" does not return to the MCC...
Status: NEW
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: x86_64 Linux
Priority: High normal
Target Milestone: Mageia 10
Assignee: Mageia tools maintainers
QA Contact:
URL:
Whiteboard: MGA9TOO
Keywords:
: 20829 28126 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-03-03 09:15 CET by Ben McMonagle
Modified: 2023-12-13 15:45 CET (History)
6 users (show)

See Also:
Source RPM: drakconf, drakxtools
CVE:
Status comment: Happens only with some Network Sharing and Local disks embedded applications (all diskdrake variants)


Attachments
Gnome i586 report.bug.xz (194.62 KB, application/x-xz)
2017-03-14 08:41 CET, Ben McMonagle
Details

Description Ben McMonagle 2017-03-03 09:15:39 CET
Description of problem: closing some MCC applications with "x" does not close the window. If "x" is pressed 2x, MCC will exit. "Cancel" will close the window. 
Particularly noticable in "Local disks" and "Network sharing"


Version-Release number of selected component (if applicable):
Mageia-6-sta2-x86_64-DVD.iso
DATE.txt: Tue Feb 28 22:03:40 CET 2017

How reproducible:every time


Steps to Reproduce:
1.install Cinnamon DE only from above .iso  (USB)
2.invoke MCC from Mageia Welcome 
3.invoke an application from "Network sharing" or "Local disks"
4.attempt to close application with "x" (top right)
5.attempt again with "x", MCC will exit
Ben McMonagle 2017-03-03 09:15:59 CET

Keywords: (none) => 6sta2

Marja Van Waes 2017-03-03 19:39:16 CET

CC: (none) => marja11
Assignee: bugsquad => mageiatools

Comment 1 Ben McMonagle 2017-03-04 09:00:09 CET
also valid for upgrade Mga 5.1 x86_64 using  Classical Install.iso
Marja Van Waes 2017-03-05 10:06:20 CET

Summary: [6sta2] closing some MCC applications with "x" does not close the window. => closing some MCC applications with "x" does not close the window.

Comment 2 Ben McMonagle 2017-03-14 08:29:13 CET
also valid for Gnome from

Mageia-6-sta2-i586-DVD.iso
DATE.txt: Wed Mar  1 11:09:58 CET 2017
Comment 3 Ben McMonagle 2017-03-14 08:41:14 CET
Created attachment 9089 [details]
Gnome i586 report.bug.xz

share your hard disk partitions,
access WebDAV shared drives and directories
access NFS shared drives and directories
access Windows (SMB) shared drives and directories
Ben McMonagle 2017-03-22 04:17:08 CET

Summary: closing some MCC applications with "x" does not close the window. => closing some MCC modules with "x" does not close the window.

Comment 4 Ben McMonagle 2017-04-10 08:29:57 CEST
valid for 

Mageia-6-rc-i586-DVD.iso
DATE.txt: Fri Apr  7 23:11:51 CEST 2017

Priority: Normal => release_blocker

Ben McMonagle 2017-04-10 08:30:16 CEST

Keywords: 6sta2 => 6RC

Comment 5 Frédéric "LpSolit" Buclin 2017-04-22 23:15:06 CEST
Can you reproduce the issue only when MCC is called from the Mageia Welcome page, or also when called later, e.g. from the "start menu"? If this is only a problem when called from the Mageia Welcome page, I wouldn't qualify this bug as a release blocker.
Comment 6 Rémi Verschelde 2017-04-26 22:26:48 CEST
I can reproduce the issue on Plasma, and also without starting from MageiaWelcome (just starting "mcc" from the terminal).

It does not affect all embedded applications, but at least those:
- Network Sharing: Accessing Windows (SMB) shared drives and directories
- Network Sharing: Accessing NFS shared drives and directories
- Network Sharing: Accessing WebDav shared drives and directories
- Local disks: Manage disk partitions
- Local disks: CD/DVD burner
- Local disks: Share your hard disk partitions

All other applications seem to work fine as far as this glitch is concerned.

@ Thierry, any idea about what could be special in the embedded of those Network sharing and Local disks applications that could cause the bug?

Status comment: (none) => Happens only with some Network Sharing and Local disks embedded applications

Comment 7 Rémi Verschelde 2017-04-26 22:29:45 CEST
Not a release blocker, it's only a minor inconvenience and can be fixed by an update after the release. It would of course be very positive to have this fixed before the release :)

Priority: release_blocker => High
Target Milestone: --- => Mageia 6

Comment 8 Pascal Terjan 2017-04-26 22:39:35 CEST
It seems to all be diskdrake with different options

http://gitweb.mageia.org/software/drakx/tree/perl-install/standalone/diskdrake

It seems to have:
--hd
--nfs
--smb
--dav
--removable
--fileshare

CC: (none) => pterjan

Rémi Verschelde 2017-04-26 22:44:11 CEST

Status comment: Happens only with some Network Sharing and Local disks embedded applications => Happens only with some Network Sharing and Local disks embedded applications (all diskdrake variants)
Summary: closing some MCC modules with "x" does not close the window. => Closing embedded diskdrake modules in MCC with "x" does not return to the MCC menu

Rémi Verschelde 2017-04-26 22:47:58 CEST

Source RPM: drakconf => drakconf, drakxtools

Comment 9 Frédéric "LpSolit" Buclin 2017-05-13 15:53:53 CEST
*** Bug 20829 has been marked as a duplicate of this bug. ***

CC: (none) => smelror

Comment 10 Martin Whitaker 2017-05-13 19:23:50 CEST
This bug was introduced when we added the wrapper round diskdrake to use udisks-inhibit. In both /usr/libexec/drakdisk and in /usr/lib/udisks2/udisks2-inhibit we need to use 'exec' to chain the commands.

CC: (none) => mageia

Comment 11 Martin Whitaker 2017-05-15 09:35:07 CEST
But using 'exec' in /usr/lib/udisks2/udisks2-inhibit stops it restoring the udev rules after diskdrake exits, so that's not a solution.
Comment 12 Pascal Terjan 2017-10-11 11:49:14 CEST
I have a not nice but working /usr/libexec/drakdisk:

#!/bin/sh
  
CMD=/usr/libexec/diskdrake

# To be able to kill the real program even if ran through udisks2-inhibit
# we create a new process group by enabling job control and running
# commands in the background and then forward the TERM signal to the group
set -m

ps -C udisksd > /dev/null
if [ $? -eq 0 -a -x /usr/lib/udisks2/udisks2-inhibit ] ; then
  /usr/lib/udisks2/udisks2-inhibit $CMD "$@" &
else
  $CMD "$@" &
fi

PID=$!
trap "kill -TERM -- -$PID; wait $PID" TERM
wait $!

Probably better to use exec in /usr/libexec/drakdisk and just forward the TERM in /usr/lib/udisks2/udisks2-inhibit
Comment 13 Arne Spiegelhauer 2017-11-06 16:07:18 CET
Another issue related to the udisks2-inhibit wrapper is that for disks (internal and external) that currently have none of their partitions mounted, the corresponding partition entries are removed from Dolphin's Devices list and from the Device Notifier (Plasma DE) when diskdrake starts.
The entries are not restored, when diskdrake is exited (by clicking done).
(trying to exit by clicking "X" twice is worse, since /usr/libexec/diskdrake isn't terminated).

CC: (none) => gm2.asp

Comment 14 Pascal Terjan 2017-11-06 19:00:43 CET
That seems like an unrelated bug, inhibiting events shouldn't change the state
Comment 15 Arne Spiegelhauer 2017-11-06 19:14:56 CET
Maybe. The reason I thought it was related is that when running /usr/libexec/diskdrake without the wrapper, the entries are also removed, but restored immediately after the removal.
I think this is the same behaviour as for MGA5
Comment 16 Martin Whitaker 2017-11-06 19:22:10 CET
(In reply to Pascal Terjan from comment #14)
> That seems like an unrelated bug, inhibiting events shouldn't change the
> state

It does though. If you run 'udevadm monitor', you'll see a whole load of change events when you enter and exit udisks2-inhibit, even if you just do something like '/usr/lib/udisks2/udisks2-inhibit sleep 2'.

Using Xfce, the icons on the desktop for unmounted volumes are removed when you start udisks2-inhibit but reappear when it exits. The Nemo file manager in Cinnamon behaves similarly. So it seems Dolphin is the odd one out in not restoring the device view.
Comment 17 Morgan Leijström 2021-01-17 11:28:26 CET
*** Bug 28126 has been marked as a duplicate of this bug. ***

CC: (none) => fri

Morgan Leijström 2021-01-17 11:29:40 CET

Whiteboard: (none) => MGA7TOO
Keywords: 6RC => (none)
Target Milestone: Mageia 6 => Mageia 9

Ben McMonagle 2021-01-29 09:07:44 CET

Whiteboard: MGA7TOO => MGA7TOO | MGA8TOO

Comment 18 Morgan Leijström 2023-12-13 15:45:39 CET
Still valid

Target Milestone: Mageia 9 => Mageia 10
Whiteboard: MGA7TOO | MGA8TOO => MGA9TOO


Note You need to log in before you can comment on or make changes to this bug.