Mga5 was installed on /dev/sdx a gpt disk. It uses grub to boot from MBR on /dev/sdx. When I try to update that drive to Mga6 the installer balks and will not proceed because the disk does not contain a bios_boot partition. Because grub is being used for Mga5 it can also be used for the upgraded Mga6 which means that the bootloader does not need a bios_boot partition.
please compress and then attach /root/report.bug from the time of the upgrade
Keywords: (none) => NEEDINFOCC: (none) => mageiatools, marja11, zen25000
Created attachment 8980 [details] report from Mga6 upgrade requiring bios_boot
Martin, would you patches handle that case too?
CC: (none) => mageia, thierry.vignaud
(In reply to Thierry Vignaud from comment #3) > Martin, would you patches handle that case too? No, because there is only a GPT disk in this case. For new installs we only support grub2, so it's right to insist on a BIOS boot partition. For upgrades, we still support legacy grub, so it isn't needed. I think the fix for this is to skip the is_boot_bios_part_needed() check when $o->{isUpgrade} is set.
Assignee: bugsquad => mageiatools
Keywords: NEEDINFO => (none)
Created attachment 8988 [details] Proposed fix e.g. like this. Tested in Vbox. The only issue I saw was that if you try to modify the bootloader at the end of the upgrade, you are no longer given the option to install it in the MBR
Comment on attachment 8988 [details] Proposed fix It might be simpler to not add a new parameter and just check for $::o->{isUpgrade}
Attachment 8988 is patch: 0 => 1
(In reply to Thierry Vignaud from comment #6) > Comment on attachment 8988 [details] > Proposed fix > > It might be simpler to not add a new parameter and just check for > $::o->{isUpgrade} Long ago when I was taught programming, global variables were frowned upon ;-) But feel free to modify my patch. Changing this to a release blocker because it affects the installer and any fix needs to be on the released ISOs.
Keywords: (none) => PATCHPriority: Normal => release_blocker
Does this patch need some work? If not, could it be committed, please? :) This bug is a release blocker.
It looks sane
@Martin, go ahead and commit :)
Status comment: (none) => Approved patch, needs to be pushed to git and packaged
commit 6753abe33da73245f22908724f671334de56cd09 Author: Martin Whitaker <mageia@...> Date: Sat Feb 25 21:01:34 2017 +0000 Don't require a BIOS boot partition when performing an upgrade (mga#20338) If we are upgrading a system on a GPT disk and it doesn't currently have a BIOS boot partition, the old system must be using a legacy bootloader (e.g. grub). We support the continued use of legacy bootloaders in an upgrade, so there is no need to insist on a BIOS boot partition in this case. --- Commit Link: http://gitweb.mageia.org/software/drakx/commit/?id=6753abe33da73245f22908724f671334de56cd09
Status comment: Approved patch, needs to be pushed to git and packaged => Patch pushed, to be tested in drakx 17.77 or later
Closing
Status: NEW => RESOLVEDResolution: (none) => FIXED