Created attachment 8483 [details] Proposed fix. The Live ISOs contain a small repository of additional packages (in /var/local/mga_rpms). To enable proprietary drivers to be installed and built on Live boot (now we no longer include pre-built drivers), the Live system needs to access this repository. However, the do_pkgs perl module detects when it is being run from a Live system and tries to chroot to /mnt/install - presumably to handle the case where we are installing from a Live system. This prevents the local repository being found during normal operation. The attached patch fixes this. P.S. Not sure if "Installer" is the correct component for this - please reassign if not.
commit e61963d811173bb572bb1ffe0d3ad1a8c265801d Author: Martin Whitaker <mageia@...> Date: Tue Nov 1 08:52:57 2016 +0000 Added patches to fix mga#19517 and mga#19520. --- Commit Link: http://gitweb.mageia.org/software/build-system/draklive-config/commit/?id=e61963d811173bb572bb1ffe0d3ad1a8c265801d Bug links: Mageia https://bugs.mageia.org/19517 https://bugs.mageia.org/19520
commit b6a40abe0a9f4127a1def0ac5b5667e963eebd80 Author: Martin Whitaker <mageia@...> Date: Sat Nov 12 19:06:31 2016 +0000 Temporarily add patches for mga#17223, mga#19517, mga#19520. --- Commit Link: http://gitweb.mageia.org/software/build-system/draklive-config/commit/?id=b6a40abe0a9f4127a1def0ac5b5667e963eebd80 Bug links: Mageia https://bugs.mageia.org/17223 https://bugs.mageia.org/19517 https://bugs.mageia.org/19520
Humm.... This is a not so old change (aka nearly 2 years aog): "install packages in chroot when in mgalive mode" http://gitweb.mageia.org/software/drakx/commit/perl-install?id=03bc6a6d53521054e42b6c43352fbd00ed285c6c later fixed by: http://gitweb.mageia.org/software/drakx/commit/perl-install?id=dd4cf3f2ce403d50345e3fa58c37fce935bf3c4d There's obviously conflicting usages. I would rather let Thomas comment on this as he was the one handling Live ISOs/installer/...
CC: (none) => thierry.vignaud, tmbComponent: Installer => RPM PackagesSource RPM: (none) => draklive
(In reply to Thierry Vignaud from comment #3) > There's obviously conflicting usages. Yes, the original change is still needed when running the Live installer. But there is also a need to install packages (for building proprietary drivers) when booting a Live system. Adding the test for /mnt/install distinguishes between the two use cases.
Yeah mabe in the long term draklive-install should set a global $::isLiveInstall variable like draks sets $::isInstall but I guess we can go that path now
Summary: Enable Live system to install additional packages from local repository. => Enable Live system to install additional packages from local repository
Did you still want Thomas to comment on this, or are you happy for me to push it?
Go with that though having draklive-install set $::isInstall would be saner. This depends on whether we expect urpmi to install a pkg in the live system or in the chroot once draklive-install has copied the live OS in the chroot...
Done.
Status: NEW => RESOLVEDResolution: (none) => FIXED