Bug 19516 - Installer should not check for boot partitions when used to build Live ISOs
Summary: Installer should not check for boot partitions when used to build Live ISOs
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: Installer (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: Mageia tools maintainers
QA Contact:
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2016-10-03 22:05 CEST by Martin Whitaker
Modified: 2016-12-02 22:08 CET (History)
3 users (show)

See Also:
Source RPM:
CVE:
Status comment:


Attachments
Proposed fix. (1.35 KB, text/plain)
2016-10-03 22:05 CEST, Martin Whitaker
Details

Description Martin Whitaker 2016-10-03 22:05:39 CEST
Created attachment 8482 [details]
Proposed fix.

If the draklive script is run on a UEFI-booted system, the 'Partitioning' step fails with the error:

"You must have a ESP FAT32 partition mounted in /boot/EFI at /usr/lib/libDrakX/fs/any.pm line 73."

This check should not be performed because:

a) At that stage, the ESP for the Live ISO has not yet been created.
b) draklive should work the same, regardless of the system it is run on.

As suggested by blino, this can be fixed by using $o->{match_all_hardware} to detect we are running draklive, and skip this check.

Suggested patch attached.
Rémi Verschelde 2016-10-03 22:10:49 CEST

Assignee: bugsquad => mageiatools

Thierry Vignaud 2016-10-03 23:04:25 CEST

CC: (none) => mageia, thierry.vignaud

Comment 1 Rémi Verschelde 2016-10-18 09:28:19 CEST
Looks good to me, Olivier, Thierry, can you check and potential apply the fix?
Comment 2 Thierry Vignaud 2016-12-01 17:28:07 CET
You can go on Martin, bug please s/$match_all_hardware/$o_match_all_hardware/
The "o_" prefix is important for perl_checker to not warn about bogus bugs about missing parameters in other call sites since this is an optional parameter.
Comment 3 Mageia Robot 2016-12-02 22:06:34 CET
commit d043433cefb6a98b2e039972f90398e9edd5d074
Author: Martin Whitaker <mageia@...>
Date:   Fri Dec 2 21:02:51 2016 +0000

    Skip check for boot partitions when building Live images (mga#19516).
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=d043433cefb6a98b2e039972f90398e9edd5d074
Comment 4 Martin Whitaker 2016-12-02 22:08:13 CET
Pushed with requested change.

Status: NEW => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.