Bug 19422 - Plasma 5.8 panel system tray applet icons do not resize
Summary: Plasma 5.8 panel system tray applet icons do not resize
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: KDE maintainers
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-20 09:50 CEST by Jüri Ivask
Modified: 2017-03-14 18:04 CET (History)
2 users (show)

See Also:
Source RPM:
CVE:
Status comment:


Attachments
systray with icons size "smallMedium" (1.56 KB, image/png)
2016-09-20 10:35 CEST, Jüri Ivask
Details
higher panel - icon size still smallMedium (2.00 KB, image/png)
2016-09-20 10:36 CEST, Jüri Ivask
Details
very high panel, icon size still smallMedium (10.33 KB, image/png)
2016-09-20 10:37 CEST, Jüri Ivask
Details

Description Jüri Ivask 2016-09-20 09:50:52 CEST
Description of problem: Plasma 5.7.95 panel system tray applet icons do not adapt their size according to panel height.


Version-Release number of selected component (if applicable): 5.7.95


Steps to Reproduce:
1. Start Plasma 6.7.95 desktop
2. Note that the system tray icons are small
3. Panel Options -> Panel Settings -> Height -> increase or decrease height
4. Icons remain in the size "small" regardless of panel height
Comment 1 Nicolas Lécureuil 2016-09-20 10:07:34 CEST
can you provide a screenshot please ?

CC: (none) => mageia

Comment 2 Nicolas Lécureuil 2016-09-20 10:07:42 CEST
can you provide a screenshot please ?
Comment 3 Jüri Ivask 2016-09-20 10:35:32 CEST
Created attachment 8429 [details]
systray with icons size "smallMedium"

At this panel height the icon size should be "medium"
Comment 4 Jüri Ivask 2016-09-20 10:36:48 CEST
Created attachment 8430 [details]
higher panel - icon size still smallMedium
Comment 5 Jüri Ivask 2016-09-20 10:37:49 CEST
Created attachment 8431 [details]
very high panel, icon size still smallMedium
Comment 6 Jüri Ivask 2016-09-20 10:47:32 CEST
If I go smaller, then the icon size scales down correctly from smallMedium to small.

Corresponding line in:
/usr/share/plasma/plasmoids/org.kde.plasma.private.systemtray/contents/ui/

property int itemSize: units.roundToIconSize(Math.min(Math.min(width, height), units.iconSizes[iconSizes[plasmoid.configuration.iconSize]]))

If I edit it to:
property int itemSize: Math.min(Math.min(width, height), units.iconSizes.medium)

I'll get correct "medium" icon size for the height of the panel like in first (panel1.png) screenshot.

Again - in KaOS the systray icons scale correctly when the panel heigth is changed,

PS Note also the empty digital clock applet (bug 19403)
Comment 7 Jüri Ivask 2016-09-20 12:05:39 CEST
Correction - in KaOS the icons too scale down correctly but not up. There the size just starts at more correct value (eg medium vs smallMedium in Mageia) at the same panel height.
Comment 8 David GEIGER 2016-09-20 12:23:18 CEST
@ Nicolas:

Perhaps we should revert back this patch?:

http://svnweb.mageia.org/packages/cauldron/plasma-workspace/current/SOURCES/plasma-workspace-5.7.4-systray_iconSizes.patch?revision=1048846&view=markup

CC: (none) => geiger.david68210

Comment 9 David GEIGER 2016-09-20 12:57:09 CEST
or not :( the code has changed now:

property var iconSizes: ["small", "smallMedium", "medium", "large", "huge", "enormous"];

property bool vertical: plasmoid.formFactor == PlasmaCore.Types.Vertical
property int itemSize: units.roundToIconSize(Math.min(Math.min(width, height), units.iconSizes[iconSizes[plasmoid.configuration.iconSize]]))
Comment 10 David GEIGER 2016-09-20 13:21:28 CEST
All recent iconSizes changes come from this upstream bug report:

https://bugs.kde.org/show_bug.cgi?id=365570
Comment 11 Jüri Ivask 2016-09-21 10:05:03 CEST
There seems to be a submitted commit: Configuration option for System Tray's icon size
https://git.reviewboard.kde.org/r/128400/
So the icon size should be configurable in system tray settings.

Checked the commit changes and they seems to be present here in Cauldron, however the corresponding configuration option in system tray settings window seems to be missing...
Comment 12 Jüri Ivask 2016-10-20 11:32:56 CEST
As a workaround, I'm editing the file:
/usr/share/plasma/plasmoids/org.kde.plasma.private.systemtray/contents/config/main.xml
and from the section:
    <entry name="iconSize" type="Int">
      <label>Default icon size for the systray icons, it's an enum which values mean, Small, SmallMedium, Medium, Large, Huge, Enormous respectively. On low DPI systems they correspond to 16, 22, 32, 48, 64, 128 pixels. On high DPI systems those values would be scaled up, depending on the DPI.</label>
      <default>1</default>
    </entry>
I change the line: <default>1</default> to <default>2</default>
which corresponds to size "Medium" instead of initial "SmallMedium"
Jüri Ivask 2016-10-20 11:34:49 CEST

Summary: Plasma 5.7.95 panel system tray applet icons do not resize => Plasma 5.8 panel system tray applet icons do not resize

Comment 13 Nicolas Lécureuil 2017-03-14 18:04:48 CET
Fixed upstream => Closing.

If still valid for you please add comments on https://bugs.kde.org/show_bug.cgi?id=365570

Status: NEW => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.