Bug 18786 - aisleriot disrespects settings
Summary: aisleriot disrespects settings
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 7
Hardware: x86_64 Linux
Priority: Normal normal
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL:
Whiteboard: MGA7-64-OK
Keywords: 6sta1.5, advisory, validated_update
: 20689 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-06-24 20:49 CEST by Herman Viaene
Modified: 2019-11-14 17:59 CET (History)
6 users (show)

See Also:
Source RPM:
CVE:
Status comment:


Attachments

Description Herman Viaene 2016-06-24 20:49:06 CEST
Description of problem:
Plasma station: aisleriot remebers setting of game last played, but does not record card type choosen
And no matter what sound setting you select, aisleriot gives click sounds when e.g. clicking on the "hint" button.

Version-Release number of selected component (if applicable):
3.20.2

How reproducible:
every time

Steps to Reproduce:
1.
2.
3.
Marja Van Waes 2016-06-25 13:59:39 CEST

CC: (none) => marja11
Assignee: bugsquad => jani.valimaa

Herman Viaene 2016-07-13 15:48:10 CEST

Keywords: (none) => 6RC

Comment 1 Jani Välimaa 2017-04-17 17:59:04 CEST
*** Bug 20689 has been marked as a duplicate of this bug. ***
Comment 2 Herman Viaene 2019-02-19 16:47:36 CET
Tested in M7beta2 i586
The click sound issue is gone, but the card type each time comes on some default. From doing this on different installations/versions/Mreleases, I see that this default is once and for all selected randomly at the first run of the program. I've never up to now seen two identical setups.
Comment 3 Julien Moragny 2019-10-01 21:38:49 CEST
Hi,

I can confirm on mga7 final (32 & 64 bits), it's annoying especially if PySolFC is also installed since it comes with its own cardsets which are recognized by aisleriot.

CC: (none) => julien.moragny

Comment 4 Julien Moragny 2019-10-04 21:51:04 CEST
Hi,

After some investigation, this bug only occurs if all format of theme are compiled, especially when kde format is added.
Without it, aisleriot obey its settings.

And well, attempt to select a kde carddecks work initially but leads to a segfault (mga7 x86_64) when I close and reopen aisleriot.

So my proposition would be to stay on the default setting (svg+pysol).

regards
Julien
Comment 5 David GEIGER 2019-10-05 06:13:27 CEST
I see in spec file that the kde-card-theme-path is set to an old kde4 path "/usr/share/apps/carddecks"

with plasma5 path is now "/usr/share/carddecks", could be that the problem?

or still better to ignore/disable the kde card theme support?

CC: (none) => geiger.david68210

Comment 6 Herman Viaene 2019-10-05 09:12:30 CEST
The problem exists since way before Plasma, see the date of my first posting. And that was not the first time I noticed this. It took some time before I was so annoyed with it, before I logged the bug.
Comment 7 José Jorge 2019-10-05 11:45:05 CEST
I feel this bug should be reported upstream, as there is no reason a software should segfault when some extra files are installed in other folders.

CC: (none) => lists.jjorge

Comment 8 David GEIGER 2019-10-05 12:11:40 CEST
Please test aisleriot-3.22.9-1.1.mga7 in Core/Updates_testing repo!
Comment 9 Julien Moragny 2019-10-05 14:53:43 CEST
(In reply to David GEIGER from comment #8)
> Please test aisleriot-3.22.9-1.1.mga7 in Core/Updates_testing repo!

Thanks, this update doesn't suffer from this bug :) (and of course doesn't offer kde carddecks)

tested on mga7 x86_64 and mga7 i586

regards
julien
Comment 10 Julien Moragny 2019-10-05 15:12:50 CEST
(In reply to David GEIGER from comment #5)
> I see in spec file that the kde-card-theme-path is set to an old kde4 path
> "/usr/share/apps/carddecks"
> 
> with plasma5 path is now "/usr/share/carddecks", could be that the problem?
> 
> or still better to ignore/disable the kde card theme support?

I just tested with new plasma path and the result is the same (no respect of settings & segfault if I choose a kde carddeck).

FWIW, I can't compile kde support without compiling everything else (e.g. svg,kde fail):
/usr/bin/ld: ./.libs/libaisleriot.a(libaisleriot_la-ar-card-themes.o): in function `ar_card_themes_foreach_theme_type_and_dir':
/home/jules/rpm/7/aisleriot/BUILD/aisleriot-3.22.9/src/lib/ar-card-themes.c:234: undefined reference to `ar_card_theme_native_get_type'
/usr/bin/ld: ./.libs/libaisleriot.a(libaisleriot_la-ar-card-themes.o): in function `theme_type_from_string':
/home/jules/rpm/7/aisleriot/BUILD/aisleriot-3.22.9/src/lib/ar-card-themes.c:88: undefined reference to `ar_card_theme_native_get_type'
collect2: error: ld returned 1 exit status

Maybe it's related.

Anyway, I think disabling is the way to go at least in the short term.

regards
julien
Comment 11 Herman Viaene 2019-10-06 11:08:50 CEST
MGA7-64 Plasma on Lenovo B50.
This laptop did not have aisleriot and Pysol installed before. Selecting the new version in MCC draws in Pysol and its carddecks.
No feedback in CLI when  launching sol and selecting a game type and deck is now preserved for a following session.
One minor niggle: the first time I click on the "View" menu, it is not shown completely, it only shows "Full screen F11" and white space above it and below. Opening another menu, and then the View menu again, then it is complete.This happens each and every time i start the program.
I don't see this as a blocking issue.
Comment 12 Julien Moragny 2019-11-13 21:17:13 CET
Uh,

it seems QA hasn't been CC to this bug

Here is a tentative Advisory :

====================================
update aisleriot fix bug with selecting cardset:

aisleriot doesn't remember the cardset selected in previous session and default to a random one. This update fix the issue.

reference :
https://bugs.mageia.org/show_bug.cgi?id=18786

===================================


Updated package in core/updates_testing:
===================================
aisleriot-3.22.9-1.1.mga7

Source RPM:
aisleriot-3.22.9-1.1.mga7.src.rpm

Assignee: jani.valimaa => qa-bugs

Comment 13 Julien Moragny 2019-11-13 21:22:40 CET
Hello QA,

Could you please validate this update.

It has been tested on mga7 64 by the reporter and myself and mga7 32 by myself.

steps to reproduce and test:
after installing, open aisleriot and select a cardset (display/card style)

close aisleriot

when you open it again, the cardset you just selected is displayed

if the bug is still here, a random cardset is selected


thanks
regards
julien
David GEIGER 2019-11-14 08:10:06 CET

Version: Cauldron => 7

Comment 14 Herman Viaene 2019-11-14 12:07:23 CET
There is no need to validate this package as it is already in Core Updates.
Comment 15 Herman Viaene 2019-11-14 12:15:33 CET
Sorry, reacted too quickly
OKing

CC: (none) => sysadmin-bugs
Keywords: (none) => validated_update
Whiteboard: (none) => MGA7-64-OK

Thomas Backlund 2019-11-14 17:11:42 CET

Keywords: (none) => advisory
CC: (none) => tmb

Comment 16 Mageia Robot 2019-11-14 17:59:59 CET
An update for this issue has been pushed to the Mageia Updates repository.

https://advisories.mageia.org/MGAA-2019-0201.html

Status: NEW => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.