Bug 18682 - drakconf missing /usr/share/icons/drakconf.png
Summary: drakconf missing /usr/share/icons/drakconf.png
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: Rémi Verschelde
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-10 17:40 CEST by David Walser
Modified: 2016-06-15 18:24 CEST (History)
1 user (show)

See Also:
Source RPM: drakconf-13.7-1.mga6.src.rpm
CVE:
Status comment:


Attachments

Description David Walser 2016-06-10 17:40:19 CEST
IceWM (and probably some other things) look for icons in /usr/share/icons.  drakconf-icons used to have a drakconf.png there, but no longer does in Mageia 6.  I'm not sure if the /usr/share/icons/large/drakconf.png and /usr/share/icons/mini/drakconf.png that also disappeared are also needed, but it wouldn't hurt to restore those too.
Comment 1 David Walser 2016-06-10 19:05:58 CEST
Assigning Anne and Rémi, who did the icons update in this package.

CC: (none) => ennael1
Assignee: bugsquad => rverschelde

Comment 2 Rémi Verschelde 2016-06-15 16:20:19 CEST
I dropped those on purpose to the profit of the icons in /usr/share/icons/hicolor (and especially the SVG in /usr/share/icons/hicolor/scalable/apps/drakconf.svg).

See http://svnweb.mageia.org/packages/cauldron/drakconf/current/SPECS/drakconf.spec?r1=1019065&r2=1019140 for the SRPM and http://gitweb.mageia.org/software/control-center/commit/?id=99201be1aecae611417004b9c6a5be39b16be304 for the source itself.

Those icons were obsolete, and instead of readding duplicated images in /usr/share/icons/{,large,mini}, I preferred to force everyone to use the ones in hicolor. This is of course a debatable decision :)

I could of course readd a symlink to the 48x48 icon in /usr/share/icons/hicolor/48x48/apps/drakconf.png, but I wanted things to break first to force us to check if adapting what depends on /usr/share/icons/drakconf.png would not be better.
Comment 3 David Walser 2016-06-15 16:28:06 CEST
Some things like IceWM look in the directories that you removed the icons from, not everything looks in hicolor, so you need to restore them in their old locations.
Comment 4 Rémi Verschelde 2016-06-15 17:17:55 CEST
Or fix IceWM to look into the new location.
Comment 5 David Walser 2016-06-15 17:19:45 CEST
It's an easy fix in the drakconf package, where you broke something that was already working.  /usr/share/icons has been a standard place for such icons for a very long time.  Do you really expect us to patch IceWM to be able to use SVGs in all sorts of other locations?  Do you know for sure that no other software looks in the same place?
Comment 6 Rémi Verschelde 2016-06-15 17:27:38 CEST
(In reply to David Walser from comment #5)
> Do you really expect us to patch IceWM to be able to
> use SVGs in all sorts of other locations?

That's the point. /usr/share/icons/drakconf.png is not an SVG, it's a low-res PNG. It's becoming more and more outdated nowadays where people have HiDPI resolutions.

So by removing this obsolete icon, as mentioned above, I wanted to force us to look into trying to use an SVG instead, and not just "keep what has been working for 10 years".

But sure I can readd a duplicate PNG icon and be done with it.
Comment 7 Rémi Verschelde 2016-06-15 17:31:22 CEST
Alright, re-reading your comment I understand that IceWM does not support looking for icons in hicolor at all, so either an icon is in /usr/share/icons, or there's no icon.

That probably means that 80% of the applications packaged in Mageia don't have icons in IceWM, but at the same time, you're right that we should not willingly break that for our own packages, so I'll add a symlink.
Comment 8 David Walser 2016-06-15 17:32:19 CEST
(In reply to Rémi Verschelde from comment #6)
> That's the point. /usr/share/icons/drakconf.png is not an SVG, it's a
> low-res PNG. It's becoming more and more outdated nowadays where people have
> HiDPI resolutions.

I know the difference between SVG and PNG.  Nobody is going to be using IceWM on a HiDPI screen.  SVG is fine for modern software that can handle it, but it is also customary to provide at least one pre-generated image with an SVG as not everything can handle it.

> So by removing this obsolete icon, as mentioned above, I wanted to force us
> to look into trying to use an SVG instead, and not just "keep what has been
> working for 10 years".

Well, it's not obsolete.  SVG has some advantages, but there's nothing wrong with not breaking things that already work fine.

> But sure I can readd a duplicate PNG icon and be done with it.

Thank you, please do.
Comment 9 Rémi Verschelde 2016-06-15 18:24:17 CEST
Should be fixed in drakconf-13.7-2.mga6.

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Rémi Verschelde 2016-06-15 18:24:27 CEST

Summary: drakconf-icons missing /usr/share/icons/drakconf.png => drakconf missing /usr/share/icons/drakconf.png


Note You need to log in before you can comment on or make changes to this bug.