Bug 18626 - Style/polish/semantics: drakxtools/manatools update dialog talk about both itself and the user in first person, plus minor notes
Summary: Style/polish/semantics: drakxtools/manatools update dialog talk about both it...
Status: NEW
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal minor
Target Milestone: Mageia 7
Assignee: Mageia tools maintainers
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-05 10:23 CEST by Morgan Leijström
Modified: 2017-01-03 14:37 CET (History)
3 users (show)

See Also:
Source RPM: drakxtools & manatools
CVE:
Status comment:


Attachments
drakxtools dialog (9.69 KB, image/png)
2016-06-05 10:24 CEST, Morgan Leijström
Details
mantools dialog (14.28 KB, image/png)
2016-06-05 10:25 CEST, Morgan Leijström
Details

Description Morgan Leijström 2016-06-05 10:23:22 CEST
OK this is very minor, it is about style and polish
The issue is almost identical on drakxtools and manatools

On first run and every time time until you check that checkmark in the dialog, the updater show a popup:  (also see attachements)

-------------------------------------------------------------------------
I need to contact the mirror to get latest packages. Please check that your network is currently running.

Is it ok to continue?

[ ] Do not ask me next time.

  [ NO ]     [ YES ]
-------------------------------------------------------------------------
(same in manatools as in drakxtools except shifted buttons order)

What immediately hits me is that it talks about both itself and user in first person.  I observed it in swedish translation and found it is the same in english.  Possibly it is more or less disturbing depending on language, but to make it universal i think original english shoold be fixed and translations follow.

The least edit to fix it is to simply omit "me" in the last line.

A better alternative is to have it conform to the style used in rest of program suite: it normally do not use "I", "me" etc, i suggest

-------------------------------------------------------------------------
The mirror need to be contacted in order to get the latest packages.
Please check that the internet connection is currently working.

Is it OK to continue?

  [ ] Do not ask next time.

  [ NO ]     [ YES ]
-------------------------------------------------------------------------
( also note versal "OK" )
( And optimally same button order in manatools as in drakxtools? )  


Version-Release number of selected component (if applicable):
Last then years i think at least,  inherited to manatools
... time to get it fixed...



Steps to Reproduce:

1. If you have once put checkmark in that dialog, to make that dialog appear again: change the line "no-confirmation 1" to "no-confirmation 0" in
  a. for drakxtools : /root/.rpmdrake 
  b. for manatools  : /root/.rpmdragora 

? BTW is there no GUI way to do this ?!

2. start "mcc" / "mana pan", select updates
For different languages, launc by i.e "LC_ALL=C mcc" for english
Comment 1 Morgan Leijström 2016-06-05 10:24:16 CEST
Created attachment 7914 [details]
drakxtools dialog
Comment 2 Morgan Leijström 2016-06-05 10:25:06 CEST
Created attachment 7915 [details]
mantools dialog
Morgan Leijström 2016-06-05 10:27:28 CEST

Summary: Slyle/polish/semantics: drakxtools/manatools update dialog talk about both itself and the user in first person => Style/polish/semantics: drakxtools/manatools update dialog talk about both itself and the user in first person, plus minor notes

Morgan Leijström 2016-06-05 11:58:24 CEST

CC: (none) => anaselli, thierry.vignaud

Comment 3 Marja Van Waes 2016-06-05 12:18:27 CEST
Maybe user 1 can choose to no longer see the popup, while user 2 still sees it until she decides to no longer see it?

If that's how it works, then the 'me' in the text is to be preferred.

CC: (none) => marja11

Comment 4 Morgan Leijström 2016-06-05 12:38:10 CEST
That is a good thought.

For all above i was starting "mcc" or "mana pan" as normal user, and it immediately asks for root privilegies, so all users become root at the time that dialog is shown, and the choice to show the dialog is stored under /root

*If* it can be different for different users then "me" could be left there
( or for clarity changed to "this user" )

But the "I" in first line is not optimal anyway and i dont see any other dialog where it talks about "I", the tools normally just state some fact like in my suggestion, without any "I", "we", "you"...


When i issue
 $ drakrpm --update
I am no asked for root privilegies, and it do not ask.
I can not find where the setting is (if any) to make it ask like the dialogues i described.
And what is corresponding command for manatools?
Comment 5 Morgan Leijström 2016-06-05 12:43:02 CEST
", and it do not ask." => i mean it do not show the dialog per comment0
Comment 6 Marja Van Waes 2016-06-05 13:49:00 CEST
(In reply to Morgan Leijström from comment #5)
> ", and it do not ask." => i mean it do not show the dialog per comment0

also not when clicking the red button with exclamation mark, which tells that updates are available?
Comment 7 Marja Van Waes 2016-06-05 13:49:30 CEST
s/when/when first/
Comment 8 Angelo Naselli 2016-06-05 14:28:55 CEST
well rpmdragora can be run as user, I'm fine to fix our strings, don't know if it's the right moment though so near to the final release.
Comment 9 Marja Van Waes 2016-06-05 15:01:56 CEST
(In reply to Angelo Naselli from comment #8)
> well rpmdragora can be run as user, I'm fine to fix our strings, don't know
> if it's the right moment though so near to the final release.

Better keep this for Mageia 7, that gives more time to decide on what exactly to change into what.

@ Frédéric

I wanted to set the Target Milestone to Mageia 7, but that isn't available in the list, yet.

Do you mind adding it?

Thanks :-)

CC: (none) => LpSolit

Comment 10 Frédéric "LpSolit" Buclin 2016-06-05 15:14:43 CEST
(In reply to Marja van Waes from comment #9)
> I wanted to set the Target Milestone to Mageia 7, but that isn't available
> in the list, yet.
> 
> Do you mind adding it?

Done.
Comment 11 Marja Van Waes 2016-06-05 15:16:45 CEST
Thanks, Frédéric :-)

Target Milestone: --- => Mageia 7

Frédéric "LpSolit" Buclin 2016-06-05 15:20:34 CEST

CC: LpSolit => (none)

Comment 12 Morgan Leijström 2016-06-06 12:48:41 CEST
What is the corresponding direct command to (as user) launch manatools and drakxtools updater respectively, the same way as mgaapplet is supposed to?

The KDE systemtray mgaapplet icon do not work properly yet.
-or is it only on my systems?

Here it is a blurred big blue low resolution icon with what i think is a white down arrow.  It do not respond to any mouse clicks.
(the same goes for net_applet too)
I have seen it show a message bubble for a couple seconds that there are new updates but I am always in the middle of something else and have not had time to click that message...) And the icon is blue even when it has shown that message...
Comment 13 Marja Van Waes 2016-06-06 13:05:37 CEST
(In reply to Morgan Leijström from comment #12)
> What is the corresponding direct command to (as user) launch manatools and
> drakxtools updater respectively, the same way as mgaapplet is supposed to?
> 

For Manatools:

    dragoraUpdate

and for drakxtools:

    MageiaUpdate

Btw, I just noticed that the Dutch translation resembles your proposal, there's no equivalent of "I" or "me" in it
Comment 14 Morgan Leijström 2016-06-06 23:56:36 CEST
OK, nice to see more than myself thought about that, thanks for looking Marja :)

dragoraUpdate and MageiaUpdate behaves quite differently when started as normal user from a temrinal:

MageiaUpdate ask users password (can be changed to ask root instead) but it seems that regardless of that the setting to show the dialog is global, in /root/.rpmdrake 

dragoraUpdate show a message that when launching it as normal user it cannot make changes to the system, but it can browse the database.  Then it runs curl (i guess trying to retrieve synthesis files) but it exits with errors 22 and 23 , Bug 18643 .

So it seem it is designed not to alter the system, and currently (at least on this system) it can not download synthesis files.

So no need to ask about contacting internet.

However I *think* i have seen it do that, but it do not now when starting as normal user, but not as root.

If it have some place to store the choice per user, what file would that be?
Comment 15 Morgan Leijström 2016-06-09 06:07:29 CEST
After recent updates, text got slighty bigger and now that manatools dialog do not show the line "Is it ok to continue?" on my machine unless user scrolls or resize it.
Is it possible to make it autosize?
Comment 16 Marja Van Waes 2017-01-03 14:37:30 CET
(In reply to Morgan Leijström from comment #15)
> After recent updates, text got slighty bigger and now that manatools dialog
> do not show the line "Is it ok to continue?" on my machine unless user
> scrolls or resize it.
> Is it possible to make it autosize?

Please file a separate bug report for that, Morgan. It's a different issue ;-)

Assignee: bugsquad => mageiatools


Note You need to log in before you can comment on or make changes to this bug.