Bug 18579 - Add the new mageia application menu icon to all DE
Summary: Add the new mageia application menu icon to all DE
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: release_blocker normal
Target Milestone: ---
Assignee: All Packagers
QA Contact: Rémi Verschelde
URL:
Whiteboard:
Keywords:
Depends on: 18585
Blocks:
  Show dependency treegraph
 
Reported: 2016-05-29 13:12 CEST by Timothée Giet
Modified: 2017-01-17 10:29 CET (History)
14 users (show)

See Also:
Source RPM:
CVE:
Status comment: Must be fixed in Enlightenment (daviddavid looking at it)


Attachments
screenshot Enlightenment (963.28 KB, image/png)
2016-11-24 19:17 CET, David GEIGER
Details

Description Timothée Giet 2016-05-29 13:12:22 CEST
The new icon for the desktop launcher has been committed here:
http://gitweb.mageia.org/software/desktop/plasma5/config/commit/?id=884a844677a9657da9768c8a5ca5c7fa7f19c752

So it should be added in default config in all DE.

Please CC to all DE maintainers.
Comment 1 Rémi Verschelde 2016-05-29 13:24:10 CEST
Adding all DE maintainers in CC, and setting as release_blocker.

To all maintainers: please check if your DE uses a launcher and if it could use the new one Timothée made.
Discussions welcome if you think that it doesn't concern or match your DE, etc.

Priority: Normal => release_blocker
CC: (none) => doktor5000, joequant, mageia, nicolas.salguero, olav, tarakbumba, tremyfr
Blocks: (none) => 15527
Assignee: bugsquad => pkg-bugs

Comment 2 Florian Hubold 2016-05-29 13:42:26 CEST
(In reply to Rémi Verschelde from comment #1)
> To all maintainers: please check if your DE uses a launcher and if it could
> use the new one Timothée made.

FWIW, might be helpful if you add "a launcher for ..." - are you referring to a launcher for drakconf, or for mageiawelcome, or ... ? Or are you referring to e.g. application menu in the panel?

Maybe just reword it to replace any "old" Mageia icon with the new one from Timothée ;)
Comment 3 Timothée Giet 2016-05-29 14:32:21 CEST
This icon was meant for the application menu panel yes (though it can also be used somewhere else as you see fit).

I'll reword the title.
Timothée Giet 2016-05-29 14:32:47 CEST

Summary: Add the new mageia desktop launcher icon to all DE => Add the new mageia application menu icon to all DE

Comment 4 Nicolas Salguero 2016-05-29 14:47:45 CEST
Hi,

In LXDE, the Mageia logo for the menu is directly /usr/share/icons/mageia.png, from desktop-common-data package.

So, is it possible to add the new icon (SVG format is good because it resizes well in LXDE) in that package so that I can modify the default configuration of LXDE menu to use that new icon.

Best regards,

Nico.
Comment 5 Timothée Giet 2016-05-29 15:50:30 CEST
I've pushed the mgabutton.svg icon in the desktop common-data package here:
http://gitweb.mageia.org/software/desktop/common-data/commit/?id=11dba12f13e011cbfc4deab14151003a01ff5091

note that I put it in icons/svg folder with all other svg icons there, but I'm not sure if that folder is already packaged and installed..

who can update the desktop-common-data package now?
Comment 6 Rémi Verschelde 2016-05-29 15:53:38 CEST
I'll have a look for desktop-common-data. I guess I will package icons this way:
/usr/share/icons/hicolor/scalable/apps/mageia-menu.svg
/usr/share/icons/hicolor/{48x48,128x128}/apps/mageia-menu.png
/usr/share/icons/mageia.png

I'll probably keep the latter 48x48, for compatibility, but users of desktop-common-data will be welcome to use mageia-menu.svg from hicolor instead.
Comment 7 Rémi Verschelde 2016-05-29 16:55:39 CEST
Done with http://gitweb.mageia.org/software/desktop/common-data/commit/?id=1ee1d32c8276a6e3b28e98a2f7b2e87e58836ae2
I asked a freeze push for desktop-common-data 6.0 that will now provide this mageia-menu.{png,svg} icon.
Comment 8 Nicolas Salguero 2016-05-30 09:40:52 CEST
Hi,

When trying "urpmi --auto-update", I have this conflict:

file /usr/share/icons/hicolor/scalable/apps/mageia-menu.svg from install of desktop-common-data-1:6.0-1.mga6.noarch conflicts with file from package mate-panel-1.14.0-1.mga6.x86_64

so I think the file /usr/share/icons/hicolor/scalable/apps/mageia-menu.svg should be removed from package mate-panel.

Best regards,

Nico.
Comment 9 Rémi Verschelde 2016-05-30 09:41:56 CEST
Ah that's bad luck, I did not know there was already a file with this name :D

@ Atilla, could you have a look at comment 8?
Comment 10 Rémi Verschelde 2016-05-30 09:43:11 CEST
Note that if the conflicting file(s) is(are) removed from mate-panel, we'd still need to rebuild desktop-common-data with `Conflicts: mate-panel < 1.14.0-2`.
Rémi Verschelde 2016-05-30 13:07:49 CEST

See Also: (none) => https://bugs.mageia.org/show_bug.cgi?id=18585

Comment 11 Joseph Wang 2016-05-30 14:21:56 CEST
Done for cinnamon.  I had to copy in the icon file into the cinnamon package because it was too difficult to get the javascript to point to the common icon file.
Atilla ÖNTAŞ 2016-05-30 14:41:06 CEST

Depends on: (none) => 18585

Comment 12 Atilla ÖNTAŞ 2016-05-30 14:43:34 CEST
(In reply to Rémi Verschelde from comment #9)
> Ah that's bad luck, I did not know there was already a file with this name :D
> 
> @ Atilla, could you have a look at comment 8?

Hi Remi, i commented on #18585 about the issue. As i said there, i don't have enough time to work on this nowadays, would you mind to fix mate-panel for me, please?

Depends on: 18585 => (none)

Atilla ÖNTAŞ 2016-05-30 14:44:25 CEST

Depends on: (none) => 18585

Comment 13 Marja Van Waes 2016-07-12 16:38:12 CEST
(In reply to Atilla ÃNTAÅ from comment #12)
> (In reply to Rémi Verschelde from comment #9)
> > Ah that's bad luck, I did not know there was already a file with this name :D
> > 
> > @ Atilla, could you have a look at comment 8?
> 
> Hi Remi, i commented on #18585 about the issue. As i said there, i don't
> have enough time to work on this nowadays, would you mind to fix mate-panel
> for me, please?

Strange, I don't see Rémi in the CC of this report. Adding him now.
(He should have seen your request via pkg-bugs ml, though)

CC: (none) => marja11, rverschelde

Comment 14 Rémi Verschelde 2016-07-28 11:03:54 CEST
(Note: The issue mentioned in comments 8-10 and 12-13 has been fixed already in bug 18585)

So from the above reports it looks like we should be good for:
- Cinnamon
- LXDE (I think?)

Need to check what's the status for:
- Enlightenment
- GNOME 3
- IceWM
- LXQt
- MATE
- Plasma 5
- XFCE 4
Comment 15 Nicolas Salguero 2016-07-28 13:23:00 CEST
For LXDE, yes, it is good.
Comment 16 Mageia Robot 2016-08-07 19:25:20 CEST
commit 87b0a815bec71154e8b00973694e3333ef8106b1
Author: Jani Välimaa <wally@...>
Date:   Sun Aug 7 20:25:07 2016 +0300

    Update app menu icon (mga#18579)
---
 Commit Link:
   http://gitweb.mageia.org/software/desktop/xfce/config/commit/?id=87b0a815bec71154e8b00973694e3333ef8106b1
Samuel Verschelde 2016-09-10 00:53:06 CEST

Status comment: (none) => 'Needs review, might be fixed everywhere already.
QA Contact: (none) => rverschelde

Samuel Verschelde 2016-09-12 16:26:44 CEST

Status comment: 'Needs review, might be fixed everywhere already. => Needs review, might be fixed everywhere already.

Comment 17 Chris B 2016-09-13 14:37:16 CEST
xfce: ok
icewm: ok

CC: (none) => shybluenight

Comment 18 Rémi Verschelde 2016-09-13 14:39:40 CEST
It's good for Plasma 5 too, so new status (from what I know and could read above):

Good:
- Cinnamon
- IceWM
- LXDE
- Plasma 5
- XFCE 4

Need to check what's the status for:
- Enlightenment
- GNOME 3
- LXQt
- MATE
Rémi Verschelde 2016-09-13 14:41:49 CEST

Status comment: Needs review, might be fixed everywhere already. => Needs to be checked in: Enlightenment, GNOME 3, LXQt, MATE

Comment 19 James Kerr 2016-10-17 12:41:56 CEST
I'm not sure where in Gnome you would expect this icon to appear. Presumably immediately before the heading "Activities", but there is at present no icon in that location and no icon appears there in Mageia 5.

So far as I can tell, other distros do not place an icon in that location.

I don't see a need for it in Mageia's Gnome.

CC: (none) => jim

Comment 20 Rémi Verschelde 2016-10-17 14:48:49 CEST
Thanks for the feedback, let's consider GNOME 3 as good too then.
3 to go :)
Rémi Verschelde 2016-10-17 14:48:58 CEST

Status comment: Needs to be checked in: Enlightenment, GNOME 3, LXQt, MATE => Needs to be checked in: Enlightenment, LXQt, MATE

Comment 21 Samuel Verschelde 2016-11-08 12:49:09 CET
CCing QA since we're lacking testers for this bug report. Need to be checked: Enlightenment, LXQt and MATE.

CC: (none) => qa-bugs

Comment 22 Nicolas Lécureuil 2016-11-08 14:09:47 CET
I am in progress to update LXQt, i will check this bug in the meantime.
Comment 23 Nicolas Lécureuil 2016-11-08 14:20:33 CET
OK in LxQT 0.10 ( menu icon OK ).
Rémi Verschelde 2016-11-09 13:57:46 CET

Status comment: Needs to be checked in: Enlightenment, LXQt, MATE => Needs to be checked in: Enlightenment, MATE

Comment 24 Nicolas Lécureuil 2016-11-09 15:58:28 CET
i just tested mate.
There is a mageia icon, but not the last one.
Samuel Verschelde 2016-11-09 16:57:04 CET

Status comment: Needs to be checked in: Enlightenment, MATE => Needs to be checked in Enlightenment and fixed in MATE

Comment 25 Nicolas Lécureuil 2016-11-09 17:56:17 CET
this is not ok on Enlightnement
Samuel Verschelde 2016-11-09 18:39:15 CET

Status comment: Needs to be checked in Enlightenment and fixed in MATE => Must be fixed in Enlightenment and MATE

Angelo Naselli 2016-11-23 21:43:12 CET

CC: (none) => anaselli

Comment 26 Rémi Verschelde 2016-11-23 21:45:25 CET
anaselli will have a look for MATE, and daviddavid will try for Enlightenment.
Rémi Verschelde 2016-11-23 21:45:41 CET

CC: (none) => geiger.david68210

Comment 27 Angelo Naselli 2016-11-23 22:55:38 CET
seems that commit has not been triggered Mate should be fixed now.
Comment 28 Rémi Verschelde 2016-11-24 00:36:28 CET
Awesome, thanks!

Status comment: Must be fixed in Enlightenment and MATE => Must be fixed in Enlightenment (daviddavid looking at it)

Comment 29 David GEIGER 2016-11-24 19:17:48 CET
Created attachment 8695 [details]
screenshot Enlightenment

looking on Enlightenment DE and the "menu" icon is not customizable (see the attached screenshot).

So we can close this bug as all DEs are fixed now!
Comment 30 David GEIGER 2016-11-24 19:19:21 CET
Closing!

Resolution: (none) => FIXED
Status: NEW => RESOLVED

Comment 31 Samuel Verschelde 2016-11-26 12:06:58 CET
Wonderful. I like when blocker bugs go down.
Samuel Verschelde 2017-01-17 10:29:39 CET

Blocks: 15527 => (none)


Note You need to log in before you can comment on or make changes to this bug.