Bug 18572 - Drop legacy check for drakmenustyle, drakbackup and tomoyo-gui
Summary: Drop legacy check for drakmenustyle, drakbackup and tomoyo-gui
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal enhancement
Target Milestone: ---
Assignee: Rémi Verschelde
QA Contact:
URL:
Whiteboard:
Keywords: Junior_job, PATCH
Depends on:
Blocks:
 
Reported: 2016-05-28 17:49 CEST by Rémi Verschelde
Modified: 2017-04-03 11:44 CEST (History)
0 users

See Also:
Source RPM: drakconf
CVE:
Status comment:

Attachments
Drop legacy loaders for drakbackup, drakmenustyle and tomoyo-gui (1.91 KB, patch)
2016-05-28 17:52 CEST, Rémi Verschelde 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Description Rémi Verschelde 2016-05-28 17:49:03 CEST 
It's been 5 years since Mageia 1, and we don't seem to want to resurrect those components, so I'd propose to drop from the MCC those checks:

"/usr/sbin/drakmenustyle" is not executable [Menus] at /usr/libexec/drakconf line 818.
"/usr/sbin/drakbackup" is not executable [Backups] at /usr/libexec/drakconf line 818.
"/usr/sbin/tomoyo-gui" is not executable [Tomoyo Policy] at /usr/libexec/drakconf line 818.

The warnings don't hurt, but having dead code doesn't help either. WDYT?
Comment 1 Rémi Verschelde 2016-05-28 17:52:13 CEST 
Created attachment 7874 [details]
Drop legacy loaders for drakbackup, drakmenustyle and tomoyo-gui
Rémi Verschelde 2016-05-28 17:52:27 CEST

Keywords: (none) => Junior_job, PATCH

Comment 2 Rémi Verschelde 2016-05-28 17:52:48 CEST 
We might want to drop the corresponding icons btw.
Rémi Verschelde 2017-03-13 19:00:25 CET

Assignee: thierry.vignaud => rverschelde

Comment 3 Mageia Robot 2017-03-13 19:04:51 CET 
commit f23d43d1c224d9caf2b085f831b4728b3b70c540
Author: Rémi Verschelde <rverschelde@...>
Date:   Mon Mar 13 18:59:41 2017 +0100

    Drop legacy loaders for drakbackup, drakmenustyle and tomoyo-gui (mga#18572)
---
 Commit Link:
   http://gitweb.mageia.org/software/control-center/commit/?id=f23d43d1c224d9caf2b085f831b4728b3b70c540
Comment 4 Rémi Verschelde 2017-03-13 19:05:45 CET 
Fixed in git.

FIXED-IN: drakconf 13.14.

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Comment 5 Rémi Verschelde 2017-04-03 11:44:44 CEST 
Apparently my patch was incomplete, the real fix will come in the next drakconf version.

http://gitweb.mageia.org/software/control-center/commit/?id=78572413493edbaa3ff8a00e197f4e8a1738bcf5
Note You need to log in before you can comment on or make changes to this bug.