Bug 18571 - Add support for defining a custom icon in mgaonline applets
Summary: Add support for defining a custom icon in mgaonline applets
Status: NEW
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal enhancement
Target Milestone: ---
Assignee: Thierry Vignaud
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-28 16:41 CEST by Rémi Verschelde
Modified: 2016-05-28 16:42 CEST (History)
2 users (show)

See Also:
Source RPM: mgaonline
CVE:
Status comment:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Rémi Verschelde 2016-05-28 16:41:56 CEST 
While looking to fix bug 18226, I noticed that mgaapplet-config and the "Configure updates frequency" embedded tools use different icons.

The problem is that mgaonline::get_banner() always instances a banner with the mgaonline icon hardcoded in mgaonline::get_banner_icon() (which also references a non-existing icon, as a side note):
- http://gitweb.mageia.org/software/mgaonline/tree/mgaapplet-config#n64
- http://gitweb.mageia.org/software/mgaonline/tree/mgaonline.pm#n140

On the other hand, control-center allows defining a custom icon:
- http://gitweb.mageia.org/software/control-center/tree/lib/MDV/Control_Center.pm#n587

So as a result the icons while embedded or standalone are different. It should be easy to fix by adding support for defining custom icons in mgaonline applets. Though maybe there's some code factorisation magic to do here too to avoid duplicating references.
Rémi Verschelde 2016-05-28 16:42:24 CEST

CC: (none) => alien, anaselli

Rémi Verschelde 2016-05-28 16:42:41 CEST

See Also: (none) => https://bugs.mageia.org/show_bug.cgi?id=18226
Note You need to log in before you can comment on or make changes to this bug.