Bug 18469 - os-prober does not recognize other btrfs installations in multi-boot system
Summary: os-prober does not recognize other btrfs installations in multi-boot system
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: x86_64 Linux
Priority: Normal normal
Target Milestone: ---
Assignee: Barry Jackson
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-16 17:18 CEST by Ulrich Beckmann
Modified: 2016-05-24 12:24 CEST (History)
0 users

See Also:
Source RPM: os-prober
CVE:
Status comment:


Attachments
commands that show the test case (6.65 KB, text/plain)
2016-05-16 17:21 CEST, Ulrich Beckmann
Details
Test of os-prober-1.71-6.3.mga6.x86_64.rpm (88.87 KB, text/plain)
2016-05-18 15:11 CEST, Ulrich Beckmann
Details
Error channel of os-prober-1.71-6.3.mga6.x86_64.rpm (19.90 KB, text/plain)
2016-05-18 15:13 CEST, Ulrich Beckmann
Details
os-prober in both versions (4.60 KB, text/plain)
2016-05-18 22:50 CEST, Ulrich Beckmann
Details
Test of os-prober-1.70-0.8.mga6 (3.82 KB, text/x-log)
2016-05-19 19:01 CEST, Ulrich Beckmann
Details
grub.cfg referring to os-prober-1.70-0.8.mga6 (48.49 KB, text/plain)
2016-05-19 19:06 CEST, Ulrich Beckmann
Details
Test of os-prober-1.71-6.6.mga6 (6.01 KB, text/plain)
2016-05-20 23:18 CEST, Ulrich Beckmann
Details

Description Ulrich Beckmann 2016-05-16 17:18:35 CEST
Description of problem:

I have cloned a btrfs installation of Mageia Cauldron into the logical volume of LVM. It is an UEFI system, btrfs-progs installed. os-prober does not find any other btrfs installation, whereas openSUSE 42.1 finds all instances and creates bootable entries. All instances have btrfs default subvolumes, read-write snapshots, other than the original default 5.

Version-Release number of selected component (if applicable):
1.71 6.mga6 x86_64

How reproducible:


Steps to Reproduce:
1.
2.
3.

Best regards,
Ulrich Beckmann
Comment 1 Ulrich Beckmann 2016-05-16 17:21:35 CEST
Created attachment 7801 [details]
commands that show the test case
Rémi Verschelde 2016-05-17 11:42:01 CEST

Assignee: bugsquad => zen25000

Comment 2 Barry Jackson 2016-05-18 01:17:20 CEST
Would you please test this version of os-prober:

http://mtf.no-ip.co.uk/pub/linux/barjac/distrib/cauldron/x86_64/media/extra/release/os-prober-1.71-6.3.mga6.x86_64.rpm

This reverts several changes and restores a patch for btrfs recognition that was in Mageia 5 and was recently dropped from Cauldron/Mga6.
Comment 3 Ulrich Beckmann 2016-05-18 15:11:20 CEST
Created attachment 7804 [details]
Test of os-prober-1.71-6.3.mga6.x86_64.rpm

The output of
# grub2-mkconfig > >(tee mageia-18496-2.txt) 2> >(tee mageia-18496-2.err >&2)

The btrfs installations are "found", but no entries in grub.cfg produced.

Best regards
Ulrich
Comment 4 Ulrich Beckmann 2016-05-18 15:13:03 CEST
Created attachment 7805 [details]
Error channel of os-prober-1.71-6.3.mga6.x86_64.rpm
Comment 5 Barry Jackson 2016-05-18 21:48:31 CEST
What is the output of
su
os-prober

for both versions?
Comment 6 Ulrich Beckmann 2016-05-18 22:50:00 CEST
Created attachment 7808 [details]
os-prober in both versions

The output of command # os-prober
in a) manually installed os-prober-1.71-6.3.mga6
   b) actual repo os-prober-1.71-6.mga6

Greetings
Ulrich
Comment 7 Barry Jackson 2016-05-19 11:26:11 CEST
So the difference is that the manually installed version finds these that the current cauldron version does not:

/dev/sda8:unknown Linux distribution:Linux:linux
/dev/mapper/vg1-mlvm06:Mageia 6:Mageia:linux
/dev/mapper/vg1-mlvm11:Fedora release 23 (Twenty Three):Fedora:linux

But none of these appear in the menu.

That would indicate to me that with os-prober-1.71-6.3.mga6 installed, the correct information is being passed to grub2-mkconfig but is ignored - would you agree?
Comment 8 Barry Jackson 2016-05-19 14:21:57 CEST
Out of interest would you also please test this:

http://mtf.no-ip.co.uk/pub/linux/barjac/distrib/cauldron/x86_64/media/extra/release/os-prober-1.70-0.8.mga6.x86_64.rpm

It is the current openSUSE tumbleweed version with all their patches but modified a little to fix some paths and add our ufs detection.
Comment 9 Ulrich Beckmann 2016-05-19 19:01:22 CEST
Created attachment 7811 [details]
Test of os-prober-1.70-0.8.mga6

Hi Barry,

Comment #7
Yes, I agree. But I did not where the real entry in grub.cfg is composed.

Comment #8
Works exactly os-prober like openSUSE 42.1.

Mageia 6 on vg1-mlvm06, ok
unknown Linux distribution (KaOS Linux) on sda8, ok
openSUSE 42.1 on vg1-mlvm12, ok
Fedora 23 on vg1-mlvm11, not ok

Fedora 23 was installed with shim.efi and Secure Boot. The other distributions boot with grubx64.efi. I forgot to mention. I have to manually add Fedora in /etc/grub.d/40_custom.

Greetings,
Ulrich Beckmann
Comment 10 Ulrich Beckmann 2016-05-19 19:06:07 CEST
Created attachment 7812 [details]
grub.cfg referring to os-prober-1.70-0.8.mga6
Comment 11 Barry Jackson 2016-05-20 00:34:44 CEST
Thanks Ulrich,
This looks promising.

I have also tested (in VM) with OpenSUSE on xfs (UEFI) and that is also OK.

Regarding Fedora 23, this is not an issue since we do not support secure boot in any form.

I will do some more testing and then push this to updates_testing so more people can test for regressions on other hardware and especially PC-BIOS machines.

Barry
Comment 12 Barry Jackson 2016-05-20 16:21:50 CEST
Hi Ulrich,
Another test please ;)

http://mtf.no-ip.co.uk/pub/linux/barjac/distrib/cauldron/x86_64/media/extra/release/os-prober-1.71-6.6.mga6.x86_64.rpm

Barry

I would be interested to see if KaOS Linux on sda8 is still shown as "Unknown Linux" in the top level menu entries. I suspect it will, and this seems to be related to a recent SuSE patch, but we can fix that later hopefully.
Comment 13 Ulrich Beckmann 2016-05-20 23:18:02 CEST
Created attachment 7819 [details]
Test of os-prober-1.71-6.6.mga6

Hi Barry,

Please note that the annoying error message/warning "File descriptor 62 (pipe:[1465670]) leaked on vgs invocation. Parent PID 680: /usr/sbin/grub2-probe" disappeared with testing since comment #9.

The last test shows no difference just like you expected. But that does not matter, as KaOS Linux ships with systemd-boot as default bootloader on UEFI systems. I had installed grub manually and made several config changes which I cannot trace any more. Nothing to spend time upon.

Best wishes
Ulrich
Comment 14 Barry Jackson 2016-05-21 01:34:37 CEST
Hi Ulrich,

There is now os-prober-1.71-7.mga6 in Cauldron core/updates_testing which has some cosmetic spec changes from the one you tested above.

I will ask on ML for everyone to test for regressions with as much different hardware as possible.

Thanks for your help.

Barry
Comment 15 Barry Jackson 2016-05-24 12:24:30 CEST
There was no response from my request for testing on dev-ML.

So, with the testing done by Ulrich, Marja and myself showing no regressions I have pushed os-prober-1.71-8.mga6 to Core.

Closing as fixed

Status: NEW => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.