Bug 18441 - kdiff3 does not appear in dolphin context menu in plasma5
Summary: kdiff3 does not appear in dolphin context menu in plasma5
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: High major
Target Milestone: ---
Assignee: Nicolas Lécureuil
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-12 00:04 CEST by Barry Jackson
Modified: 2016-06-04 13:09 CEST (History)
1 user (show)

See Also:
Source RPM: kdiff3-0.9.98-4.mga6.src.rpm
CVE:
Status comment:

Attachments
proposed patch (1.57 KB, patch)
2016-05-23 22:29 CEST, Barry Jackson 		Details | Diff
proposed patch (1.67 KB, patch)
2016-05-23 22:34 CEST, Barry Jackson 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Description Barry Jackson 2016-05-12 00:04:38 CEST 
In KDE4 kdiff3 was available in the dolphin context menu to quickly and easily compare files - in plasma5 this feature is missing.
Barry Jackson 2016-05-12 00:07:38 CEST

Source RPM: (none) => kdiff3-0.9.98-4.mga6.src.rpm

Rémi Verschelde 2016-05-12 07:30:38 CEST

Assignee: bugsquad => mageia

Barry Jackson 2016-05-22 16:54:41 CEST

Priority: Normal => High
Severity: normal => major

Comment 1 David GEIGER 2016-05-22 17:42:13 CEST 
This package seems to be not ported to kf5 and also seems a bit dead.

So I don't know if this one will be keeps for mga6??

CC: (none) => geiger.david68210

Comment 2 Barry Jackson 2016-05-23 22:29:33 CEST 
Created attachment 7838 [details]
proposed patch

This works for me with minimal spec changes.

WDYT Nicolas?
Comment 3 Barry Jackson 2016-05-23 22:34:51 CEST 
Created attachment 7839 [details]
proposed patch

Oops wrong diff - this has url for servicemenu and a mention of it's license.

Attachment 7838 is obsolete: 0 => 1

Comment 4 Barry Jackson 2016-05-29 11:51:48 CEST 
Ping?
This works for me.
Nicolas, can I push this?
Comment 5 David GEIGER 2016-05-29 11:59:41 CEST 
I think this is not a proper fix, as kdiff3 is always compiled against KDE4 libs and not against KF5.
Comment 6 Rémi Verschelde 2016-05-29 12:02:56 CEST 
Well it fixes this bug "kdiff3 does not appear in dolphin context menu in plasma5", so it's better than nothing.
Comment 7 Barry Jackson 2016-05-31 00:36:10 CEST 
(In reply to David GEIGER from comment #5)
> I think this is not a proper fix, as kdiff3 is always compiled against KDE4
> libs and not against KF5.

It won't build against kf5, so leaving it as is and adding this add-on seems the only option currently available.

I will commit the changes and let Nicolas review it.
Comment 8 Barry Jackson 2016-05-31 00:44:49 CEST 
Update is in svn ready to commit.
Comment 9 Barry Jackson 2016-06-04 13:09:15 CEST 
It got pushed by a mass rebuild so closing.

Status: NEW => RESOLVED
Resolution: (none) => FIXED
Note You need to log in before you can comment on or make changes to this bug.