Bug 17349 - abiword background color selection does nothing / color selection broken
Summary: abiword background color selection does nothing / color selection broken
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 5
Hardware: All Linux
Priority: Normal critical
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL: http://bugzilla.abisource.com/show_bu...
Whiteboard: MGA5-64-OK MGA5-32-OK advisory
Keywords: validated_update
Depends on:
Blocks:
 
Reported: 2015-12-17 13:59 CET by Florian Hubold
Modified: 2015-12-28 20:24 CET (History)
4 users (show)

See Also:
Source RPM: abiword-3.0.0-10.mga5.src.rpm
CVE:
Status comment:


Attachments

Description Florian Hubold 2015-12-17 13:59:58 CET
Originally reported via forums thread:
https://forums.mageia.org/en/viewtopic.php?f=7&t=10575


Two issues that are linked and related to the GTK color selector. 
When trying to change the background color via menu Format > Page Background > Page Color and clicking on any color with the mouse and OK, background color will not be changed.

This is because the color selection is reportedly broken, color needs to be selected either with enter or space key, and then abiword will crash with a segfault.

This is known upstream: http://bugzilla.abisource.com/show_bug.cgi?id=13638
and also mentioned in the Changelog for 3.0.1:

> Gtk Background Dialog: properly get the color on close with the new color chooser widget. Cherry-pick from trunk@35029 (Hubert Figuière)
> Gtk Dialogs Background and options: fix the color chooser. (Hubert Figuière)
> Gtk option dialog: fix the color selector for gtk3: We instantiate it manually instead of doing it in the UI file. This diverge from trunk. (Hubert Figuière)


Verified already that this is fixed in abiword 3.0.1 which should be pushed as an update to mga5.

Reproducible: 

Steps to Reproduce:
Florian Hubold 2015-12-17 14:02:10 CET

URL: (none) => http://bugzilla.abisource.com/show_bug.cgi?id=13638
CC: (none) => doktor5000

Comment 1 Shlomi Fish 2015-12-17 16:51:12 CET
(In reply to Florian Hubold from comment #0)
> Originally reported via forums thread:
> https://forums.mageia.org/en/viewtopic.php?f=7&t=10575
> 
> 
> Two issues that are linked and related to the GTK color selector. 
> When trying to change the background color via menu Format > Page Background
> > Page Color and clicking on any color with the mouse and OK, background
> color will not be changed.
> 
> This is because the color selection is reportedly broken, color needs to be
> selected either with enter or space key, and then abiword will crash with a
> segfault.
> 
> This is known upstream: http://bugzilla.abisource.com/show_bug.cgi?id=13638
> and also mentioned in the Changelog for 3.0.1:
> 
> > Gtk Background Dialog: properly get the color on close with the new color chooser widget. Cherry-pick from trunk@35029 (Hubert Figuière)
> > Gtk Dialogs Background and options: fix the color chooser. (Hubert Figuière)
> > Gtk option dialog: fix the color selector for gtk3: We instantiate it manually instead of doing it in the UI file. This diverge from trunk. (Hubert Figuière)
> 
> 
> Verified already that this is fixed in abiword 3.0.1 which should be pushed
> as an update to mga5.
> 
> Reproducible: 
> 
> Steps to Reproduce:

Update pushed to core/updates_testing . Florian, can you write an advisory? The version is 3.0.1 with 1.1 (%mkrel 1 and subrel 1).

Assignee: shlomif => qa-bugs

Comment 2 Florian Hubold 2015-12-17 17:01:32 CET
(In reply to Shlomi Fish from comment #1)
> Florian, can you write an advisory?

Sure, here goes suggested advisory:

========================

In abiword versions prior to 3.0.1, when trying to change the background color via the menu Format > Page Background > Page Color and clicking on any color with the mouse, then OK, the background color will not be changed.

This is because the color selection dialog was broken, the color would have needed to be selected either with enter or space key, and then abiword would crash with a segmentation fault.

This update fixes both issues.


References:
http://bugzilla.abisource.com/show_bug.cgi?id=13638
http://www.abisource.com/changelogs/3.0.1.phtml
https://bugs.mageia.org/show_bug.cgi?id=17349
========================

Updated packages in core/updates_testing:
========================
i586
abiword-3.0.1-1.1.mga5.i586
abiword-devel-3.0.1-1.1.mga5.i586
python-abiword-3.0.1-1.1.mga5.i586

x86_64
abiword-3.0.1-1.1.mga5.x86_64
abiword-devel-3.0.1-1.1.mga5.x86_64
python-abiword-3.0.1-1.1.mga5.x86_64

Source RPMs: 
abiword-3.0.1-1.1.mga5.src.rpm

Status: NEW => ASSIGNED

Comment 3 Florian Hubold 2015-12-18 01:32:54 CET
As I'm not the packager this time, I can confirm (again) that the update to abiword-3.0.1-6.mga5.x86_64.rpm fixes both mentioned issues, the crash and the color selector in general.

Background color can now be changed as expected \o/


Only other thing I noticed is that when selecting text, the highlighting of the selected text is in black - vs. black text, which is a pretty bad choice. But not related to the update, 3.0.0 shows the same issue. Might also simply be a local theming problem.

Whiteboard: (none) => MGA5-64-OK

Comment 4 Joel Barnett 2015-12-18 04:40:37 CET
I can confirm that Florian is correct, the Abiword 3.0.1 package in the core/updates_testing repo fixes the problem.

I am the original poster in the the forum thread Florian links to in his bug description.

CC: (none) => jbarntt56

Comment 5 Atilla ÖNTAŞ 2015-12-18 13:32:47 CET
Off topic but just curious about subrel usage. Version is already bigger value than the previous one. So why you used subrel? Release should be enough?

CC: (none) => tarakbumba

Comment 6 Florian Hubold 2015-12-18 13:44:09 CET
(In reply to Atilla ÃNTAÅ from comment #5)
> So why you used subrel? Release should be enough?

Good point actually, also mentioned in https://wiki.mageia.org/en/Updates_policy#Maintainer_.28or_any_interested_packager.29

But in this particular case, the release in cauldron is already much higher, I don't think this warrants to re-submit the update candidate without subrel (which would also require intervention by sysadmins for manual removal).
Comment 7 James Kerr 2015-12-20 23:07:16 CET
Testing on mga5-32

Packages installed from testing:

python-abiword-3.0.1-1.1.mga5
abiword-3.0.1-1.1.mga5

Page colour can be changed using the menu with the mouse.

(I see the same black on black problem with highlighted text as mentioned in comment #3)

OK for mga5-32

Whiteboard: MGA5-64-OK => MGA5-64-OK MGA5-32-OK

Comment 8 James Kerr 2015-12-20 23:10:32 CET
This update is now validated.

The Advisory needs to be uploaded to SVN. The packages can then be pushed to updates.

Keywords: (none) => validated_update
CC: (none) => sysadmin-bugs

Rémi Verschelde 2015-12-28 13:29:34 CET

Whiteboard: MGA5-64-OK MGA5-32-OK => MGA5-64-OK MGA5-32-OK advisory

Comment 9 Mageia Robot 2015-12-28 20:24:17 CET
An update for this issue has been pushed to Mageia Updates repository.

http://advisories.mageia.org/MGAA-2015-0213.html

Status: ASSIGNED => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.