Bug 17277 - [Mga6-dev1] Include hexchat/konversation where no IRC client is provided - needed by mageiawelcome
Summary: [Mga6-dev1] Include hexchat/konversation where no IRC client is provided - ne...
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: Release (media or process) (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: Daniel Napora
QA Contact:
URL:
Whiteboard:
Keywords: 6dev1, NEEDINFO
Depends on:
Blocks:
 
Reported: 2015-12-02 19:50 CET by Ben McMonagle
Modified: 2016-04-05 22:10 CEST (History)
4 users (show)

See Also:
Source RPM:
CVE:
Status comment:


Attachments

Description Ben McMonagle 2015-12-02 19:50:11 CET
Description of problem: MageiaWelcome has a button for "Chat Room" which opens an IRC client. If none is present it attempts to install hexchat.

KDE uses konversation which is installed by default but gnome has none and likely most others.

We should include hexchat in the default installation for DE's without an IRC client


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.


Reproducible: 

Steps to Reproduce:
claire robinson 2015-12-02 20:02:53 CET

CC: (none) => eeeemail, sysadmin-bugs
Component: RPM Packages => Release (media or process)
Assignee: bugsquad => ennael1
Whiteboard: (none) => 6dev1

Comment 1 papoteur 2015-12-02 22:49:45 CET
Hello,
Should be already the case.
In code, I see:
            elif msg == "irc":
              irc_client = get_irc_client()
              if irc_client == "none":
                if desktop == "KDE":
                  subprocess.Popen("gurpmi konversation", shell=True)
                else:
                  subprocess.Popen("gurpmi hexchat", shell=True)
              else: os.system(irc_client)
ger_irc_client test for konversation, hexchat, xchat, xchat-gnome and quaessel.
If none is present, either konversation or hexchat will be installed, according to the DE is KDE or not.
The difference I see is that if installation is needed, the client is not launched. Should this be changed?

CC: (none) => yves.brungard_mageia

Comment 2 Ben McMonagle 2015-12-02 23:07:46 CET
Chat-room link from Mageia Welcome, for: 
Mageia-6-dev1-LiveDVD-PLASMA5-x86_64-DVD.iso Mon Nov 23 16:00:00 CET 2015 
required that Konversation be installed first from Mageia Welcome [ or MCC ] before use.
for:
Mageia-6-dev1-i586-DVD.iso Sun Nov 29 21:42:03 CET 2015 LXDE 
required that Hexchat be installed first from Mageia Welcome [ or MCC ] before use.
Should they not have been installed as part of the original installation?

Perhaps I incorrectly titled the bug report?
if so, apologies.
Comment 3 Ben McMonagle 2016-01-02 23:36:24 CET
currently, even if installed, Plasma5 desktop Mageia Welcome Chat Room default launches to Hexchat instead of Konversation
Comment 4 Samuel Verschelde 2016-01-11 08:35:39 CET
I thought now we install quassel by default instead of konversation.

Also, I think mageiawelcome should use xdg stuff to open in the default client rather than use such an arbitraty choice algorithm.

Reassigning to MageiaWelcome developer, first.

Assignee: ennael1 => napcok

Comment 5 Mageia Robot 2016-01-22 11:11:53 CET
commit 7b6d0b785b652b202a629a691cf13475cf3e8501
Author: Daniel Napora <napcok@...>
Date:   Fri Jan 22 11:11:42 2016 +0100

    use xdg-open for irc (mga#17277)
---
 Commit Link:
   http://gitweb.mageia.org/software/mageiawelcome/commit/?id=7b6d0b785b652b202a629a691cf13475cf3e8501
Comment 6 Marja Van Waes 2016-04-05 19:30:37 CEST
Can this bug be closed as fixed?

Keywords: (none) => 6dev1, NEEDINFO
CC: (none) => marja11
Whiteboard: 6dev1 => (none)

Comment 7 Ben McMonagle 2016-04-05 22:10:21 CEST
yes

Status: NEW => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.