Imported.

Status: NEW => RESOLVED
Resolution: (none) => FIXED

Thanks Ahmad, the only problem is that this version it has a bug with the parser
http://kde-look.org/content/show.php/translatoid?content=97511
I downloaded the svn version
svn co svn://anonsvn.kde.org/home/kde/trunk/playground/base/plasma/applets/translatoid

and the problem is fixed
I rebuilt the file localy and i test it it works

So, for me is ok now.

I am sorry, but I see the post about the Greek .po file here was done on 7th Jan 2011, while the last change in svn://anonsvn.kde.org/home/kde/trunk/playground/base/plasma/applets/translatoid was 15month ago, so I don't see how this is version 1.30 , so I can't get the latest svn changes you're talking about.

Keywords: (none) => NEEDINFO
Status: RESOLVED => REOPENED
Resolution: FIXED => (none)

i dont see any translation for this program, either greek either french. Will ne included in the next version ?

The package in the repos uses the tarball from http://kde-look.org/content/show.php/translatoid?content=97511

You said the html parsing in broken and is fixed in upstream svn, right? I don't see anything about that in upstream svn...

So I need either a tarball from upstream or a link to the currently used upstream svn repo...

The fix has to be the file with the latest date so the http://websvn.kde.org/trunk/playground/base/plasma/applets/translatoid/ktranslatoid.cpp?revision=1178194&view=markup

As you can see in the http://kde-look.org/content/show.php/translatoid?content=97511 the author of the program (dridk) replies the 7 january with the svn version to fix the problem. Probably he was a few months late:

svn work
 
 by dridk on: Jan 7 2011  
 --  svn co svn://anonsvn.kde.org/home/kde/trunk/playground/base/plasma/applets/translatoid


After, we can see at rpm releases of other distro:
* Mon Feb 07 2011 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 1.30-3.svn01092011
  - Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
* Wed Jan 26 2011 Eli Wapniarski <eli@orbsky.homelinux.org> 1.30
  -1.30-2.svn01092011
  - Fix for new Google Api.
* Sun Jun 13 2010 Eli Wapniarski <eli@orbsky.homelinux.org> 1.30
  -1.30
  - Version upgrade
  - Correct Json parser with new Google Api.
http://rpmfind.net//linux/RPM/fedora/devel/rawhide/i386/kde-plasma-translatoid-1.30-3.svn01092011.fc15.i686.html

I got confused by chepioq comment on http://kde-look.org/content/show.php/translatoid?content=97511 , he said that he modified svn, his comment was on  Jan 7 2011 , but the latest commit in svn://anonsvn.kde.org/home/kde/trunk/playground/base/plasma/applets/translatoid was in 2010... that and installing a new translatoid package plasma must be restarted....

Please test the next package. :/

Yes it is ok now thanks very much

It is weird that the author has fixed from September and he did nt announced it :)


* The translations dont come with the rpm, may be the program does nt get it from svn.

This rpm includes svn head, so any translations should be included (there're none, AFAICS).

There are in trunk:
Greek:
http://websvn.kde.org/*checkout*/trunk/l10n-kde4/el/messages/playground-base/plasma_applet_translatoid.po

French:
http://websvn.kde.org/*checkout*/trunk/l10n-kde4/fr/messages/playground-base/plasma_applet_translatoid.po

German:
http://websvn.kde.org/*checkout*/trunk/l10n-kde4/de/messages/playground-base/plasma_applet_translatoid.po

and other languages

But not in the upstream tarball, I don't like the idea of having to chase .po files from l10n-kde4.... 

Upstream should create a new tarball with all the translations/fixes :/

what about this bug ?

i asked for the translations to be included on Mars 08 2011 but i did nt get any answer till now. I also checked today but the translations are nt included uin the svn checkout

(In reply to comment #13)
> i asked for the translations to be included on Mars 08 2011 but i did nt get
> any answer till now. I also checked today but the translations are nt included
> uin the svn checkout

I forgot to add the url: http://kde-look.org/content/show.php?content=97511&forumpage=18

if i understand correctly, new translations are in the upstream svn but there is no tarballs with them ?


if yes we can patch to add new translations.

Yes, the translations are in the upstream svn but they are not included in the svn checkout of the program.

Maybe it's related to http://lists.kde.org/?l=kde-extra-gear&m=130853712719673&w=2

Regards,

CC: (none) => balcaen.john

Aka upstream does not add more translation is there is less than 65% of translated strings.

i have reported it upstream here :
https://bugs.kde.org/show_bug.cgi?id=272772

It seems that is the responsability of the author.
I asked again here:
http://lists.kde.org/?l=kde-i18n-doc&m=131349267721850&w=2
i did nt get any answere from the author so may be you want to close the report...

I feel we should leave this bugreport open. Ideally, upstream would take care of this and respond to your request of March 8th and fix future releases by including the translations in the released tarballs. Failing that (and for now), I think D Morgan's suggestion (comment 15) is worth following and we can patch it on our end. Clearly, this is not ideal, but I believe it would be of value to our users.

It is somewhat ironic that an applet helping users to get translations is not out of the box available in their own language, but such is life I guess.

(In reply to comment #21)
> I think D Morgan's suggestion (comment 15) is worth following and we can
> patch it on our end. Clearly, this is not ideal, but I believe it would be of
> value to our users.
> 

cc'ing three packagers who work for doc team,too, and know how important translations are, because one of them might be motivated to fix this

CC: (none) => doktor5000, marja11, oliver.bgr, remco

I'll have a look.

(In reply to comment #23)
> I'll have a look.

@ Oliver

Did you find time to do that?

Nope, I forgot, since I didn't assign it to me :/

Assignee: bugsquad => oliver.bgr

I commited a patch to add the translations.
Oliver, can you check it out if you have any objection ?

I test it localy, it works fine and it adds those translation files:

plasma_applet_translatoid_ca.po           
plasma_applet_translatoid_ca@valencia.po  
plasma_applet_translatoid_cs.po           
plasma_applet_translatoid_da.po           
plasma_applet_translatoid_de.po           
plasma_applet_translatoid_el.po           
plasma_applet_translatoid_en_GB.po        
plasma_applet_translatoid_es.po           
plasma_applet_translatoid_et.po          
plasma_applet_translatoid_fi.po           
plasma_applet_translatoid_fr.po           
plasma_applet_translatoid_km.po
plasma_applet_translatoid_nb.po
plasma_applet_translatoid_nds.po
plasma_applet_translatoid_nl.po
plasma_applet_translatoid_pa.po
plasma_applet_translatoid_pl.po
plasma_applet_translatoid_pt_BR.po
plasma_applet_translatoid_pt.po
plasma_applet_translatoid_ru.po
plasma_applet_translatoid_sv.po
plasma_applet_translatoid_uk.po

Here is the patch: http://svnweb.mageia.org/packages/cauldron/plasma-applet-translatoid/current/SOURCES/plasma-applet-translatoid-1.30-mga-add-translations.patch?view=markup&pathrev=210360

I'm gonna review it.

Well, the patch does download things during build time, which is not a good thing because that way we are packaging things, that are not stored in our repositories (binrepo and/or svn).
It would be better to download the files, create a tar ball of them and add that as an additional source to the package.

i generated the translations manualy with the script, and the generated /po folder i added it in the tarball. I hope that was the desired way.
http://svnweb.mageia.org/packages?view=revision&revision=221234

(In reply to comment #29)
...
> It would be better to download the files, create a tar ball of them and add
> that as an additional source to the package.

I did nt add as additional source (only one tarball for all), it is ok or not ?

We don't change the upstream tar balls, changes/additions to upstream code should be done by adding patches or additional source tar balls.
Look into the "-a" option of the rpm %setup macro.
You will find a lot of literature about it on the net.

i added the po/ folder as an additional tarball
i added the script which i generated the po/ folder in the SOURCES/

Localy, it builds without any problem.
Oliver, can you check if is done correctly ?

http://svnweb.mageia.org/packages?view=revision&revision=223074
http://svnweb.mageia.org/packages?view=revision&revision=223073
http://svnweb.mageia.org/packages?view=revision&revision=223072

Pushed to BS, good work.

This bug is opened against council, but it was filed before the Mga1 release. Should those fixes be pushed back to Mga1 as well?

Oups, I meant "Cauldron" not "Council".

Closing as fixed. If fix needed in 1 as well, please reopen.

Status: REOPENED => RESOLVED
Resolution: (none) => FIXED