Bug 16837 - isodumper writes despite it failed to umount target filesystem
Summary: isodumper writes despite it failed to umount target filesystem
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 5
Hardware: x86_64 Linux
Priority: Normal normal
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL:
Whiteboard: advisory MGA5-64-OK
Keywords: validated_update
Depends on:
Blocks:
 
Reported: 2015-09-26 23:30 CEST by Morgan Leijström
Modified: 2015-11-26 21:48 CET (History)
4 users (show)

See Also:
Source RPM: isodumper-0.42-1.mga5.src.rpm
CVE:
Status comment:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Morgan Leijström 2015-09-26 23:30:23 CEST 
I had opened dolphin to see what was on the stick i was to write an iso to.
Then i ran isodumper and it first popped up a dialog it said it could not unmount - but when i closed that popup it started writing anyhow!

The old content on the stick was not affected.

Cut-paste from the log in isodumper window:

MÃ¥lenhet: SanDisk Cruzer Fit (/dev/sdd) 7633Mb
Avbild: /home/morgan/Hämtningar/mga5 i586 150613 boot-nonfree.iso
MÃ¥lenhet: SanDisk Cruzer Fit (/dev/sdd) 7633Mb
Avmonterar alla partitioner för /dev/sdd:
Försöker att avmontera /dev/sdd1...
Fel, avmontera /dev/sdd1 returnerade 32
Kör kopia från/home/morgan/Hämtningar/mga5 i586 150613 boot-nonfree.iso till /dev/sdd
Skrev: 1% 524288 bytes
Skrev: 2% 1048576 bytes
Skrev: 3% 1572864 bytes
Skrev: 4% 2097152 bytes
Skrev: 5% 2621440 bytes
Skrev: 6% 3145728 bytes
Skrev: 7% 3670016 bytes
Skrev: 8% 4194304 bytes
Skrev: 9% 4456448 bytes
Skrev: 10% 4980736 bytes
Skrev: 11% 5505024 bytes
Skrev: 12% 6029312 bytes
Skrev: 13% 6553600 bytes
Skrev: 14% 7077888 bytes
Skrev: 15% 7602176 bytes
Skrev: 16% 8126464 bytes
Skrev: 17% 8388608 bytes
Skrev: 18% 8912896 bytes
Skrev: 19% 9437184 bytes
Skrev: 20% 9961472 bytes
Skrev: 21% 10485760 bytes
Skrev: 22% 11010048 bytes
Skrev: 23% 11534336 bytes
Skrev: 24% 12058624 bytes
Skrev: 25% 12320768 bytes
Skrev: 26% 12845056 bytes
Skrev: 27% 13369344 bytes
Skrev: 28% 13893632 bytes
Skrev: 29% 14417920 bytes
Skrev: 30% 14942208 bytes
Skrev: 31% 15466496 bytes
Skrev: 32% 15990784 bytes
Skrev: 33% 16515072 bytes
Skrev: 34% 16777216 bytes
Skrev: 35% 17301504 bytes
Skrev: 36% 17825792 bytes
Skrev: 37% 18350080 bytes
Skrev: 38% 18874368 bytes
Skrev: 39% 19398656 bytes
Skrev: 40% 19922944 bytes
Skrev: 41% 20447232 bytes
Skrev: 42% 20709376 bytes
Skrev: 43% 21233664 bytes
Skrev: 44% 21757952 bytes
Skrev: 45% 22282240 bytes
Skrev: 46% 22806528 bytes
Skrev: 47% 23330816 bytes
Skrev: 48% 23855104 bytes
Skrev: 49% 24379392 bytes
Skrev: 50% 24641536 bytes
Skrev: 51% 25165824 bytes
Skrev: 52% 25690112 bytes
Skrev: 53% 26214400 bytes
Skrev: 54% 26738688 bytes
Skrev: 55% 27262976 bytes
Skrev: 56% 27787264 bytes
Skrev: 57% 28311552 bytes
Skrev: 58% 28835840 bytes
Skrev: 59% 29097984 bytes
Skrev: 60% 29622272 bytes
Skrev: 61% 30146560 bytes
Skrev: 62% 30670848 bytes
Skrev: 63% 31195136 bytes
Skrev: 64% 31719424 bytes
Skrev: 65% 32243712 bytes
Skrev: 66% 32768000 bytes
Skrev: 67% 33030144 bytes
Skrev: 68% 33554432 bytes
Skrev: 69% 34078720 bytes
Skrev: 70% 34603008 bytes
Skrev: 71% 35127296 bytes
Skrev: 72% 35651584 bytes
Skrev: 73% 36175872 bytes
Skrev: 74% 36700160 bytes
Skrev: 75% 36962304 bytes
Skrev: 76% 37486592 bytes
Skrev: 77% 38010880 bytes
Skrev: 78% 38535168 bytes
Skrev: 79% 39059456 bytes
Skrev: 80% 39583744 bytes
Skrev: 81% 40108032 bytes
Skrev: 82% 40632320 bytes
Skrev: 83% 41156608 bytes
Skrev: 84% 41418752 bytes
Skrev: 85% 41943040 bytes
Skrev: 86% 42467328 bytes
Skrev: 87% 42991616 bytes
Skrev: 88% 43515904 bytes
Skrev: 89% 44040192 bytes
Skrev: 90% 44564480 bytes
Skrev: 91% 45088768 bytes
Skrev: 92% 45350912 bytes
Skrev: 93% 45875200 bytes
Skrev: 94% 46399488 bytes
Skrev: 95% 46923776 bytes
Skrev: 96% 47448064 bytes
Skrev: 97% 47972352 bytes
Skrev: 98% 48496640 bytes
Skrev: 99% 49020928 bytes
Skrev: 100% 49283072 bytes
Avbildmga5 i586 150613 boot-nonfree.iso skrevs till /dev/sdd
Bytes skrivna:49283072
SHA1-värde:3d058d7bc0c6b16aa736587395f19903b54a97d8
MD5-värde:ee43a9517e6f8d236a7ba0be24911b85


Reproducible: 

Steps to Reproduce:
Comment 1 Morgan Leijström 2015-09-26 23:42:49 CEST 
Illegal, sorry.
Now i see, also see the output below from when starting isodumper from a terminal:
1) it forcfully wrote /dev/sdd even when it could not umount /dev/sdd1 
   That is OK i think.
2) Dolphin used cached info so i just thought old content were there.  Even after closing all dolphin windows and opening them again.  Only when i moved the USB to another USB port, dolphin forgot about the old files!

# isodumper
Error creating proxy: Anslutningen är stängd (g-io-error-quark, 18)                                                                                                 
Error creating proxy: Anslutningen är stängd (g-io-error-quark, 18)                                                                                                 
Error creating proxy: Anslutningen är stängd (g-io-error-quark, 18)                                                                                                 
Error creating proxy: Anslutningen är stängd (g-io-error-quark, 18)                                                                                                 
Error creating proxy: Anslutningen är stängd (g-io-error-quark, 18)                                                                                                 
umount: /run/media/morgan/ntfs-8G-Mikro-SanDisk: target is busy                                                                                                     
        (In some cases useful info about processes that                                                                                                             
         use the device is found by lsof(8) or fuser(1).)                                                                                                           
MÃ¥lenhet: SanDisk Cruzer Fit (/dev/sdd) 7633Mb                                                                                                                      
Avbild: /home/morgan/Hämtningar/mga5 i586 150613 boot-nonfree.iso                                                                                                   
MÃ¥lenhet: SanDisk Cruzer Fit (/dev/sdd) 7633Mb
Avmonterar alla partitioner för /dev/sdd:
Försöker att avmontera /dev/sdd1...
Fel, avmontera /dev/sdd1 returnerade 32
Kör kopia från/home/morgan/Hämtningar/mga5 i586 150613 boot-nonfree.iso till /dev/sdd
Skrev: 1% 524288 bytes
Skrev: 2% 1048576 bytes
Skrev: 3% 1572864 bytes
Skrev: 4% 2097152 bytes
Skrev: 5% 2621440 bytes
Skrev: 6% 3145728 bytes
Skrev: 7% 3670016 bytes
Skrev: 8% 4194304 bytes
Skrev: 9% 4456448 bytes
Skrev: 10% 4980736 bytes
Skrev: 11% 5505024 bytes
Skrev: 12% 6029312 bytes
Skrev: 13% 6553600 bytes
Skrev: 14% 7077888 bytes
Skrev: 15% 7602176 bytes
Skrev: 16% 8126464 bytes
Skrev: 17% 8388608 bytes
Skrev: 18% 8912896 bytes
Skrev: 19% 9437184 bytes
Skrev: 20% 9961472 bytes
Skrev: 21% 10485760 bytes
Skrev: 22% 11010048 bytes
Skrev: 23% 11534336 bytes
Skrev: 24% 12058624 bytes
Skrev: 25% 12320768 bytes
Skrev: 26% 12845056 bytes
Skrev: 27% 13369344 bytes
Skrev: 28% 13893632 bytes
Skrev: 29% 14417920 bytes
Skrev: 30% 14942208 bytes
Skrev: 31% 15466496 bytes
Skrev: 32% 15990784 bytes
Skrev: 33% 16515072 bytes
Skrev: 34% 16777216 bytes
Skrev: 35% 17301504 bytes
Skrev: 36% 17825792 bytes
Skrev: 37% 18350080 bytes
Skrev: 38% 18874368 bytes
Skrev: 39% 19398656 bytes
Skrev: 40% 19922944 bytes
Skrev: 41% 20447232 bytes
Skrev: 42% 20709376 bytes
Skrev: 43% 21233664 bytes
Skrev: 44% 21757952 bytes
Skrev: 45% 22282240 bytes
Skrev: 46% 22806528 bytes
Skrev: 47% 23330816 bytes
Skrev: 48% 23855104 bytes
Skrev: 49% 24379392 bytes
Skrev: 50% 24641536 bytes
Skrev: 51% 25165824 bytes
Skrev: 52% 25690112 bytes
Skrev: 53% 26214400 bytes
Skrev: 54% 26738688 bytes
Skrev: 55% 27262976 bytes
Skrev: 56% 27787264 bytes
Skrev: 57% 28311552 bytes
Skrev: 58% 28835840 bytes
Skrev: 59% 29097984 bytes
Skrev: 60% 29622272 bytes
Skrev: 61% 30146560 bytes
Skrev: 62% 30670848 bytes
Skrev: 63% 31195136 bytes
Skrev: 64% 31719424 bytes
Skrev: 65% 32243712 bytes
Skrev: 66% 32768000 bytes
Skrev: 67% 33030144 bytes
Skrev: 68% 33554432 bytes
Skrev: 69% 34078720 bytes
Skrev: 70% 34603008 bytes
Skrev: 71% 35127296 bytes
Skrev: 72% 35651584 bytes
Skrev: 73% 36175872 bytes
Skrev: 74% 36700160 bytes
Skrev: 75% 36962304 bytes
Skrev: 76% 37486592 bytes
Skrev: 77% 38010880 bytes
Skrev: 78% 38535168 bytes
Skrev: 79% 39059456 bytes
Skrev: 80% 39583744 bytes
Skrev: 81% 40108032 bytes
Skrev: 82% 40632320 bytes
Skrev: 83% 41156608 bytes
Skrev: 84% 41418752 bytes
Skrev: 85% 41943040 bytes
Skrev: 86% 42467328 bytes
Skrev: 87% 42991616 bytes
Skrev: 88% 43515904 bytes
Skrev: 89% 44040192 bytes
Skrev: 90% 44564480 bytes
Skrev: 91% 45088768 bytes
Skrev: 92% 45350912 bytes
Skrev: 93% 45875200 bytes
Skrev: 94% 46399488 bytes
Skrev: 95% 46923776 bytes
Skrev: 96% 47448064 bytes
Skrev: 97% 47972352 bytes
Skrev: 98% 48496640 bytes
Skrev: 99% 49020928 bytes
Skrev: 100% 49283072 bytes
Avbildmga5 i586 150613 boot-nonfree.iso skrevs till /dev/sdd
Bytes skrivna:49283072
SHA1-värde:3d058d7bc0c6b16aa736587395f19903b54a97d8
MD5-värde:ee43a9517e6f8d236a7ba0be24911b85

Status: NEW => RESOLVED
Resolution: (none) => INVALID

Rémi Verschelde 2015-09-26 23:59:50 CEST

CC: (none) => yves.brungard_mageia

Comment 2 papoteur 2015-09-27 21:20:28 CEST 
Ok, good catch.
I will add a correction.
Papoteur
Comment 3 papoteur 2015-10-08 08:09:06 CEST 
Didn't see comment 1.
Thus, nothing to do.
Comment 4 Mageia Robot 2015-11-22 15:23:40 CET 
commit 025b79f33537a671a593a71c129b779b1ed205a5
Author: Papoteur <papoteur@...>
Date:   Sun Nov 22 12:27:01 2015 +0100

    Manage when partition is busy (mga#16837)
---
 Commit Link:
   http://gitweb.mageia.org/software/isodumper/commit/?id=025b79f33537a671a593a71c129b779b1ed205a5
Comment 5 David GEIGER 2015-11-23 12:30:42 CET 
Assigning to QA,


Advisory:
========================

When a partition is busy, writing operation is not possible.
In main window, only detail box is expandable.

This update fixes this issue.

========================

Packages in 5/core/updates_testing:
========================
isodumper-0.44-1.mga5.noarch.rpm

Source RPM: 
========================
isodumper-0.44-1.mga5.src.rpm

Status: RESOLVED => REOPENED
CC: (none) => geiger.david68210
Resolution: INVALID => (none)

David GEIGER 2015-11-23 12:31:05 CET

Assignee: bugsquad => qa-bugs

Comment 6 papoteur 2015-11-23 12:36:58 CET 
Should be read:

Advisory:
========================

After this update:
When a partition is busy, writing operation is not possible.
In main window, only detail box is expandable.

========================

Packages in 5/core/updates_testing:
========================
isodumper-0.44-1.mga5.noarch.rpm

Source RPM: 
========================
isodumper-0.44-1.mga5.src.rpm
Comment 7 Len Lawrence 2015-11-25 23:46:56 CET 
mga5  x86_64  Mate

Plugged in the USB device and the Caja file manager came up.  Left it on screen.

[lcl@belexeuli ~]$ cd /run/media/lcl/Mageia-6-PLASMA5-LiveDVD/
[lcl@belexeuli Mageia-6-PLASMA5-LiveDVD]$ isodumper
umount: /run/media/lcl/Mageia-6-PLASMA5-LiveDVD: target is busy
        (In some cases useful info about processes that
         use the device is found by lsof(8) or fuser(1).)

As reported before, isodumper ignores the busy signal and writes to the USB device and completes in the usual manner.

Updated to version 0.44

Performed the same actions as above and dismissed the error message popup.
The details window showed this as before:
  DVD/Mageia-6-dev1-LiveDVD-PLASMA5-x86_64-DVD.iso
  Target Device: JetFlash Transcend 8GB (/dev/sdd) 7536Mb
  Unmounting all partitions of /dev/sdd:
  Trying to unmount /dev/sdd1...
  Partition /dev/sdd1 is busy

and no writing took place, so this is good.

CC: (none) => tarazed25
Whiteboard: (none) => MGA5-64-OK

Comment 8 claire robinson 2015-11-26 18:08:50 CET 
Validating. Advisory from comment 6 uploaded.

Please push to 5 updates

Thanks

Keywords: (none) => validated_update
Whiteboard: MGA5-64-OK => advisory MGA5-64-OK
CC: (none) => sysadmin-bugs

Comment 9 Mageia Robot 2015-11-26 21:48:22 CET 
An update for this issue has been pushed to Mageia Updates repository.

http://advisories.mageia.org/MGAA-2015-0188.html

Status: REOPENED => RESOLVED
Resolution: (none) => FIXED
Note You need to log in before you can comment on or make changes to this bug.