Bug 16660 - Add plasma support into meta-tasks
Summary: Add plasma support into meta-tasks
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: Installer (show other bugs)
Version: Cauldron
Hardware: i586 Linux
Priority: Normal enhancement
Target Milestone: ---
Assignee: Mageia Bug Squad
QA Contact:
URL:
Whiteboard:
Keywords:
: 16651 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-08-27 15:59 CEST by Nicolas Lécureuil
Modified: 2015-09-28 09:49 CEST (History)
1 user (show)

See Also:
Source RPM: meta-task
CVE:
Status comment:

Attachments
This patch remove KDE4 and add Plasma 5 instead (15.51 KB, text/plain)
2015-08-27 16:01 CEST, Nicolas Lécureuil 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Description Nicolas Lécureuil 2015-08-27 15:59:44 CEST 
Description of problem:

The provided patch ad Plasma support in the installer ( over KDE4 )



Reproducible: 

Steps to Reproduce:
Comment 1 Nicolas Lécureuil 2015-08-27 16:01:20 CEST 
Created attachment 6973 [details]
This patch remove KDE4 and add Plasma 5 instead
Nicolas Lécureuil 2015-08-27 16:01:47 CEST

Assignee: bugsquad => thierry.vignaud

Comment 2 Rémi Verschelde 2015-08-27 16:14:26 CEST 
*** Bug 16651 has been marked as a duplicate of this bug. ***

CC: (none) => jyri2000

Comment 3 Rémi Verschelde 2015-08-27 16:26:16 CEST 
In compssUsers.pl, you should probably also update the description which says: "The K Desktop Environment, the basic graphical environment with a collection of accompanying tools"
IIUC, KDE no longer means "K Desktop Environment" but only "KDE", so at least this should be updated.


In rpmsrate-raw, it seems you ran sed 's/CAT_KDE/CAT_PLASMA5/', but since CAT_PLASMA5 was already present as an alternative in some parts, there are now  duplicates like:
CAT_PLASMA5 || CAT_PLASMA5    or    !CAT_PLASMA5 !CAT_PLASMA5

Could probably improve the patch with:
s/CAT_PLASMA5 || CAT_PLASMA5/CAT_PLASMA5/
s/!CAT_PLASMA5 !CAT_PLASMA5/!CAT_PLASMA5/
Comment 4 Thierry Vignaud 2015-08-28 09:50:24 CEST 
Just commit your changes (after fixing the little issues spot by Rémi)

Assignee: thierry.vignaud => bugsquad

Comment 5 Nicolas Lécureuil 2015-08-28 20:57:54 CEST 
commited.

I just didn't changed the sentence about KDE as we need to fin a proper one and i am not good at it :)
Comment 6 Nicolas Lécureuil 2015-09-28 09:49:29 CEST 
fixed .

Status: NEW => RESOLVED
Resolution: (none) => FIXED
Note You need to log in before you can comment on or make changes to this bug.