The "drakrpm-update" program crashed. Drakbug-16.62 caught it. I put wrong syntax in the skip list: /*nvidia-current/ Preferrably it should not crash, but pop up a message about syntax... Quantifier follows nothing in regex; marked by <-- HERE in m/(?:* <-- HERE nvidia-current)/ at /usr/lib/perl5/vendor_perl/5.20.1/x86_64-linux-thread-multi/URPM/Resolve.pm line 1949. Perl's trace: drakbug::bug_handler() called from /usr/lib/perl5/vendor_perl/5.20.1/x86_64-linux-thread-multi/URPM/Resolve.pm:1949 URPM::compute_flags() called from /usr/lib/perl5/vendor_perl/5.20.1/urpm/media.pm:846 urpm::media::_compute_flags_for_skiplist() called from /usr/lib/perl5/vendor_perl/5.20.1/urpm/media.pm:740 urpm::media::configure() called from /usr/lib/perl5/vendor_perl/5.20.1/Rpmdrake/open_db.pm:157 Rpmdrake::open_db::open_urpmi_db() called from /usr/lib/perl5/vendor_perl/5.20.1/Rpmdrake/pkg.pm:444 Rpmdrake::pkg::get_pkgs() called from /usr/lib/perl5/vendor_perl/5.20.1/Rpmdrake/gui.pm:642 Rpmdrake::gui::pkgs_provider() called from /usr/libexec/drakrpm-update:266 main::run_treeview_dialog() called from /usr/libexec/drakrpm-update:293 Theme name: oxygen-gtk Kernel version = 3.19.0-desktop-2.mga5 Distribution=Mageia release 5 (Cauldron) for x86_64 CPU=Intel(R) Core(TM) i7-2600K CPU @ 3.40GHz
Priority: Normal => LowCC: (none) => thierry.vignaudSeverity: normal => minor
Created attachment 5945 [details] patch to avoid the crash that print a warning message A quick patch to avoid the problem. dragoraUpdated is affected too, obviously.
CC: (none) => anaselli
patch does skip any lines of skip-list if a regexp is wrong, but that is better than crashing imo
Maybe try that patch in cauldron after mga5 release And update the bug to ask for popping up and/or log a message when syntax is wrong?
Keywords: (none) => PATCH
It would be better to use $urpm->{debug} instead of warn
Whiteboard: (none) => MGA5TOO
for mga6 ?
CC: (none) => marja11Assignee: bugsquad => mageiatools
*** Bug 19382 has been marked as a duplicate of this bug. ***
CC: (none) => jyri2000
commit 070f1be3d5c3aa813f61d061c2a0fd38c2477c08 Author: Angelo Naselli <anaselli@...> Date: Sun Oct 16 12:43:49 2016 +0200 mga#15353 don't crash if re is wrong --- Commit Link: http://gitweb.mageia.org/software/rpm/perl-URPM/commit/?id=070f1be3d5c3aa813f61d061c2a0fd38c2477c08
@thierry please review it I used debug but i could not be able to test it :(
Source RPM: rpmdrake-6.15-1.mga5 => perl-URPM
Looks good to me. I'm considering just backporting future URPM-5.0.9 to mga5...
commit a31506d8123747d15346f7808e8c14bce91bcd9b Author: Angelo Naselli <anaselli@...> Date: Sun Oct 16 12:43:49 2016 +0200 mga#15353 don't crash if re is wrong --- Commit Link: http://gitweb.mageia.org/software/rpm/perl-URPM/commit/?id=a31506d8123747d15346f7808e8c14bce91bcd9b
Closing
Status: NEW => RESOLVEDResolution: (none) => FIXED
commit 49d5faf692708da20ce26dd4e0b7d6ab6da2b71f Author: Thierry Vignaud <thierry.vignaud@...> Date: Thu Oct 20 16:20:01 2016 +0200 fix crash introduced by mga#15353 fix (mga#19618) rationale: - {debug_URPM} only exists if we're in debug mode - as this is an actual error, let's just always report it bug introduced in commit 070f1be3d5c3aa813f61d061c2a0fd38c2477c08 --- Commit Link: http://gitweb.mageia.org/software/rpm/perl-URPM/commit/?id=49d5faf692708da20ce26dd4e0b7d6ab6da2b71f Bug links: Mageia https://bugs.mageia.org/15353 https://bugs.mageia.org/19618
commit 9921c980dc294b6ce31450c2160a5247d4f04e6d Author: Thierry Vignaud <thierry.vignaud@...> Date: Thu Oct 20 16:20:01 2016 +0200 fix crash introduced by mga#15353 fix (mga#19618) rationale: - {debug_URPM} only exists if we're in debug mode - as this is an actual error, let's just always report it bug introduced in commit 070f1be3d5c3aa813f61d061c2a0fd38c2477c08 (cherry picked from commit 49d5faf692708da20ce26dd4e0b7d6ab6da2b71f) --- Commit Link: http://gitweb.mageia.org/software/rpm/perl-URPM/commit/?id=9921c980dc294b6ce31450c2160a5247d4f04e6d Bug links: Mageia https://bugs.mageia.org/15353 https://bugs.mageia.org/19618
Grrr....
it happens :D