Bug 15030 - mageiawelcome: Port to GTK+3 and WebKit2
Summary: mageiawelcome: Port to GTK+3 and WebKit2
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal normal
Target Milestone: Mageia 6
Assignee: Daniel Napora
QA Contact:
URL:
Whiteboard: OK
Keywords: PATCH, Triaged
Depends on:
Blocks:
 
Reported: 2015-01-13 10:51 CET by Olav Vitters
Modified: 2015-09-25 08:20 CEST (History)
2 users (show)

See Also:
Source RPM: mageiawelcome
CVE:
Status comment:

Attachments
automatic conversion from gtk2 to gtk3 (3.47 KB, patch)
2015-09-23 14:26 CEST, Thierry Vignaud 		Details | Diff
Gdk is needed too (640 bytes, patch)
2015-09-23 14:26 CEST, Thierry Vignaud 		Details | Diff
fix automatic conversion for WebKit (741 bytes, patch)
2015-09-23 14:26 CEST, Thierry Vignaud 		Details | Diff
fix import warnings with latest gi (1.22 KB, patch)
2015-09-23 14:27 CEST, Thierry Vignaud 		Details | Diff
fix a deprecation warning (1.27 KB, patch)
2015-09-23 14:27 CEST, Thierry Vignaud 		Details | Diff
kill uneeded import (799 bytes, patch)
2015-09-23 14:28 CEST, Thierry Vignaud 		Details | Diff
workaround sizing loop issue with gtk+3 (950 bytes, patch)
2015-09-23 14:28 CEST, Thierry Vignaud 		Details | Diff
workaround sizing loop issue with gtk+3 (858 bytes, patch)
2015-09-23 14:34 CEST, Thierry Vignaud 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Description Olav Vitters 2015-01-13 10:51:30 CET 
mageiawelcome uses gtk+2.0 and webkit. It should use gtk+3.0 and webkit2. Especially usage of webkit results in a lot of extra space in the GNOME images (rest of GNOME uses webkit2).

Reproducible: 

Steps to Reproduce:
David Walser 2015-01-13 16:52:25 CET

Assignee: bugsquad => napcok

Samuel Verschelde 2015-05-21 11:56:11 CEST

Keywords: (none) => Triaged

Comment 1 Daniel Napora 2015-05-21 12:16:27 CEST 
I will try to do that for MGA6.
Daniel Napora 2015-06-05 12:03:52 CEST

Status: NEW => ASSIGNED
Whiteboard: (none) => OK

Samuel Verschelde 2015-06-06 09:47:58 CEST

Target Milestone: --- => Mageia 6

Comment 2 Thierry Vignaud 2015-09-07 13:23:18 CEST 
I've a year old WIP patches that I've sent to author.
There's signal looping issue though

CC: (none) => thierry.vignaud

Thierry Vignaud 2015-09-07 13:25:22 CEST

Keywords: (none) => PATCH

Comment 3 Thierry Vignaud 2015-09-23 14:26:27 CEST 
Created attachment 7036 [details]
automatic conversion from gtk2 to gtk3
Comment 4 Thierry Vignaud 2015-09-23 14:26:42 CEST 
Created attachment 7037 [details]
Gdk is needed too
Comment 5 Thierry Vignaud 2015-09-23 14:26:56 CEST 
Created attachment 7038 [details]
fix automatic conversion for WebKit
Comment 6 Thierry Vignaud 2015-09-23 14:27:13 CEST 
Created attachment 7039 [details]
fix import warnings with latest gi
Comment 7 Thierry Vignaud 2015-09-23 14:27:41 CEST 
Created attachment 7040 [details]
fix a deprecation warning
Comment 8 Thierry Vignaud 2015-09-23 14:28:01 CEST 
Created attachment 7041 [details]
kill uneeded import
Comment 9 Thierry Vignaud 2015-09-23 14:28:22 CEST 
Created attachment 7042 [details]
workaround sizing loop issue with gtk+3
Comment 10 Thierry Vignaud 2015-09-23 14:31:13 CEST 
I've attached my last year's patches plus more patches on top (fixing warnings with mga6's python-gi/gnome-3.1[68]

I've workarounded the sizing loop issue by adding a ScrolledWindow
Comment 11 Thierry Vignaud 2015-09-23 14:32:27 CEST 
@Daniel: do you want me to "git push" those?
Comment 12 Thierry Vignaud 2015-09-23 14:34:21 CEST 
Created attachment 7043 [details]
workaround sizing loop issue with gtk+3

(reaping an unrelated/uneeded debuging change)

Attachment 7042 is obsolete: 0 => 1

Comment 13 Daniel Napora 2015-09-23 17:38:10 CEST 
(In reply to Thierry Vignaud from comment #11)
> @Daniel: do you want me to "git push" those?

Yes please push.
Comment 14 Thierry Vignaud 2015-09-24 13:22:55 CEST 
Fixed in git
Comment 15 Thierry Vignaud 2015-09-24 17:34:53 CEST 
Now it just needs to be ported to python3 :-)

Status: ASSIGNED => RESOLVED
Resolution: (none) => FIXED

papoteur 2015-09-25 08:19:17 CEST

CC: (none) => yves.brungard_mageia

Comment 16 papoteur 2015-09-25 08:20:30 CEST 
Ok, I can take care of the port to Python 3.
Note You need to log in before you can comment on or make changes to this bug.