Description of problem: bm creates logs in format "log.pkg_name", but it's not OK. For example, if I build exe pkg I have log.exe and double click runs wine. So, good format is mirrored: "pkg_name.log" Version-Release number of selected component (if applicable): bm-2.1-233.mga5 How reproducible: always Steps to Reproduce: 1. bm -lb 2. double click on log file Reproducible: Steps to Reproduce:
Keywords: (none) => TriagedAssignee: bugsquad => shlomif
Shlomi, hi, I commited modification and tested. If OK, then please submit. http://svnweb.mageia.org/packages?view=revision&revision=804254
I am not convinced that is a real problem... and i won't be so happy for this change. 1) bm is not a tool to be used in graphical environment, so double clicking on log file is not a real problem. 2) some (or most) of us, at least I talk for myself, when use bm use also console intensively so to read log i usually type vi SPECS/log<tab> that works for almost everything, changing the name convention that is broken and I should type the project name first. Also tailing SPECS/log<tab> would be broken.
CC: (none) => anaselli
please revert your changes, i haven't seen any discussion here. You have the option if you want to change the filename! --build-log=FILE specify where to put the build log for each package
(In reply to Alex Loginov from comment #1) > Shlomi, hi, > I commited modification and tested. If OK, then please submit. > http://svnweb.mageia.org/packages?view=revision&revision=804254 I submitted the package with the fix into the repositories (before I saw Angelo's comment). Now I'll address what Angelo said.
(In reply to Angelo Naselli from comment #3) > please revert your changes, i haven't seen any discussion here. > OK, I'll revert them for now. You people please decide what to do. Regards, -- Shlomi Fish > You have the option if you want to change the filename! > --build-log=FILE specify where to put the build log for each package
Is it OK by default? - self.log = log or "$builddir/SPECS/log.$name" + self.log = log or "$builddir/SPECS/log_$name" So, we wont use dot, but fix double click and keep <tab>.
could be better and does not change most. But shouldn't be better to ask for it in mailing list? maybe some other developers would like to say their opinion. Consider also that upstream svn.mandriva.com is still log.$name
Can I close the bug for the time being?
Status: NEW => ASSIGNED
Developers have no opinion. So, the best way this patch: - self.log = log or "$builddir/SPECS/log.$name" + self.log = log or "$builddir/SPECS/log_$name"
I really don't think anything is broken so why change it?
CC: (none) => zen25000
Will you see difference if to change dot on _ for vi? No. But for GUI difference will be.
Not for me as to view/edit files in KDE I always use right-click/Edit. (Using my own service menu) It's safer than accidentally running a script or other executable by clicking it. I just wonder how many personal scripts using log.* that people have will be broken by this? To conclude that developers have no opinion because there was only one comment in response to a changelog message is unfair. Not everyone reads all changelog messages. Now Angelo has changed the subject there may be more feedback. However, for me the proposed change would not cause a problem.
Barry, thank you for your opinion. I sure my proposal (patch from comment #9) have no regress, but with progress. My the first patch was not good, because I don't use vim, so I did not know, that Angelo will have problems. I'm sorry.
Alex, I'd say you should use the option mentioned in comment #3. There is always a regression if you change something like that. If someone has configured his/her scripts to use old pattern then new pattern will break it.
CC: (none) => mageia
That could be Sander, but as said this is a developer tool, a reason to use scripts for those logs, is probably that we have also used bm in some script/cron or what else for automatically building. So i don't think this is the case for the most. But I'm curious since there is an option that (hopefully) work to change the log file name (and also another for the position) why can't be used such an option? Alex how are you using bm? i think that if you are using some menu on desktop (action/service or...) you could change "bm %f" with "bm --build-log=%f.log %f" or $f or... If you run it from console you can add an alias (not easy you have to write a function with parameters or use a fixed log file name). I mean the feature is covered, so it's not a bug or a missed feature. As said just for curiosity....
I use dolphin with F4 console. So, I see file system in GUI, but work in console together with GUI.
So do I. You may find my little add-on for dolphin useful. http://mtf.no-ip.co.uk/pub/linux/barjac/distrib/cauldron/x86_64/media/extra/release/kde-servicemenu-extras-1.0-1.2.mga5.noarch.rpm Provides right click context menu entries for Konqueror/Dolphin to: * Edit files as root using the default KDE text editor * Edit files as user using the default KDE text editor * Copy path of file/folder to clipboard * Copy name of file/folder to clipboard * Copy md5sum of file to clipboard and also display it in pop-up So rather than (double)click, Edit is in context menu. Just a thought :)
As noted, there's an easy way to set it using the command line option, which can be scripted. No need to break compatibility. so I'm resolving this as INVALID.
Resolution: (none) => INVALIDStatus: ASSIGNED => RESOLVED