install fails on 3.12.20-tmb-laptop-1.mga4 as I can see from the log, the function "create_proc_entry" is missing which causes the build of the module to fail since the default kernel uses ~30-40% more energy, I switched to a laptop kernel. I need this module to compile tp_smapi to even save more battery with these settings. Unfortunately this module is not available in mageia, so I had to add a dkms script myself. Reproducible: Steps to Reproduce:
same with recent kernel ?
yepp, as you can see from the log: DKMS make.log for acpi_call-0.1-3.mga4 for kernel 3.12.26-tmb-laptop-1.mga4 (x86_64) So 2. Nov 11:24:20 CET 2014 make: Entering directory '/usr/src/3.12.26-tmb-laptop-1.mga4' LD /var/lib/dkms/acpi_call/0.1-3.mga4/build/built-in.o CC [M] /var/lib/dkms/acpi_call/0.1-3.mga4/build/acpi_call.o /var/lib/dkms/acpi_call/0.1-3.mga4/build/acpi_call.c: In Funktion »init_acpi_call«: /var/lib/dkms/acpi_call/0.1-3.mga4/build/acpi_call.c:312:12: Fehler: Implizite Deklaration der Funktion »create_proc_entry« [-Werror=implicit-function-declaration] struct proc_dir_entry *acpi_entry = create_proc_entry("call", 0660, acpi_root_dir); ^ /var/lib/dkms/acpi_call/0.1-3.mga4/build/acpi_call.c:312:41: Warnung: Initialisierung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung [standardmäÃig aktiviert] struct proc_dir_entry *acpi_entry = create_proc_entry("call", 0660, acpi_root_dir); ^ /var/lib/dkms/acpi_call/0.1-3.mga4/build/acpi_call.c:321:15: Fehler: Dereferenzierung eines Zeigers auf unvollständigen Typen acpi_entry->write_proc = acpi_proc_write; ^ /var/lib/dkms/acpi_call/0.1-3.mga4/build/acpi_call.c:322:15: Fehler: Dereferenzierung eines Zeigers auf unvollständigen Typen acpi_entry->read_proc = acpi_proc_read; ^ cc1: Einige Warnungen werden als Fehler behandelt scripts/Makefile.build:314: recipe for target '/var/lib/dkms/acpi_call/0.1-3.mga4/build/acpi_call.o' failed make[1]: *** [/var/lib/dkms/acpi_call/0.1-3.mga4/build/acpi_call.o] Error 1 Makefile:1230: recipe for target '_module_/var/lib/dkms/acpi_call/0.1-3.mga4/build' failed make: *** [_module_/var/lib/dkms/acpi_call/0.1-3.mga4/build] Error 2 make: Leaving directory '/usr/src/3.12.26-tmb-laptop-1.mga4'
the header file /usr/src/3.12.26-tmb-laptop-1.mga4/include/linux/proc_fs.h does not declare this function!
Keywords: (none) => TriagedCC: (none) => tmbAssignee: bugsquad => remi
The log does not mean that the function is missing, but that it's declared implicitly, and gcc doesn't like that because the -Werror=implicit-function-declaration flag is declared. The dkms-acpi_call package in Mageia 4 is pretty broken, it should not have been kept in the distro (I obsoleted it in cauldron). If you really need it I would suggest to have a look at the upstream source code: https://github.com/mkottman/acpi_call After a quick look at this: http://www.thinkwiki.org/wiki/Tp_smapi I'm not sure if you really need acpi_call for tp_smapi? As far as I can tell acpi_call was imported in Mageia for bumblebee, but it has since then been superseded by bbswitch (which is available in backports_testing).
hmmm, you're right for my laptop it is not needed. Kernel module works without it, even though tlp-stat reports "tpacpi-bat = inactive (kernel module 'acpi_call' not installed)", but I can access the battery & fan parameters. :-) Maybe it would be a good idea, to add tlp/tp_smapi for thinkpad users?
Summary: install fails on laptop kernel => acpi_call: install fails on laptop kernel
Closing as WONTFIX since there seems to be a workaround, and I don't really intend to try to fix dkms-acpi_call for Mageia 4 (I already removed it from Cauldron, so it won't be in Mageia 5).
Status: NEW => RESOLVEDResolution: (none) => WONTFIX