Bug 13230 - mgaapplet-config: Config-Options text is unknowable
Summary: mgaapplet-config: Config-Options text is unknowable
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 4
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL:
Whiteboard: MGA4-64-OK advisory
Keywords: Triaged, validated_update
Depends on:
Blocks:
 
Reported: 2014-04-17 22:27 CEST by Hartmut Goebel
Modified: 2015-02-24 22:20 CET (History)
4 users (show)

See Also:
Source RPM: mgaonline-3.10-1.mga4
CVE:
Status comment:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Hartmut Goebel 2014-04-17 22:27:24 CEST 
Description of problem:

mgaapplet-config has an option
  "Check for newer 'default' releases".
This is unknowable. What does this mean? What are "'default' releases"?

This option seams to set or clear the "DO_NOT_ASK_FOR_DISTRO_UPGRADE" value in 
/etc/sysconfig/mgaapplet. So I suggest changing this option text into something like
  "Check for new Mageia distribution releases"
  "Check for Mageia distribution releases upgrades."



How reproducible: Always

Steps to Reproduce:
1. Run `LC_ALL=C mgaapplet-config`
2. Enter root-password (if asked for)
3. Message is for the last option in the window.


Reproducible: 

Steps to Reproduce:
Comment 1 Hartmut Goebel 2014-04-17 22:29:47 CEST 
Setting "Atelier" keyword, since IMHO it's a communications question how a "new Mageia distribution release" should be described.

Keywords: (none) => Atelier

Comment 2 Manuel Hiebel 2014-04-21 19:23:00 CEST 
also valid on mga4 and cauldron

it read /etc/product.id and product=Default 


But it's defined: 
http://gitweb.mageia.org/software/mgaonline/tree/mgaonline.pm#n142

Keywords: (none) => Triaged
Version: 3 => Cauldron
Assignee: bugsquad => thierry.vignaud
Whiteboard: (none) => MGA4TOO MGA3TOO
Severity: enhancement => normal

Comment 3 Rémi Verschelde 2015-02-17 19:25:46 CET 
Fixed: http://gitweb.mageia.org/software/mgaonline/commit/?id=f08f3ff5a6711cf0a8b551067933eca67d48b5f9

Keywords: Atelier => (none)
Status: NEW => RESOLVED
CC: (none) => remi
Resolution: (none) => FIXED
Assignee: thierry.vignaud => remi
Whiteboard: MGA4TOO MGA3TOO => MGA4TOO

Comment 4 Thierry Vignaud 2015-02-17 19:33:03 CET 
This break translations again...

CC: (none) => thierry.vignaud

Comment 5 Thierry Vignaud 2015-02-17 19:35:13 CET 
This also break rebranding which was an original Mga goal


At least this wouldn't gratuitously break translations:
- text => N("Check for newer \"%s\" releases", "Mageia"),
Comment 6 Thierry Vignaud 2015-02-17 19:35:56 CET 
The real fix would have to been to fix /etc/product.id...

Status: RESOLVED => REOPENED
Resolution: FIXED => (none)

Comment 7 Rémi Verschelde 2015-02-17 19:43:49 CET 
(In reply to Thierry Vignaud from comment #4)
> This break translations again...

You've already complained about this, and I've already fixed that even before you asked. Please check the log for mgaonline: http://gitweb.mageia.org/software/mgaonline/log/

Also see my answer on the dev ML: https://ml.mageia.org/l/arc/dev/2015-02/msg00600.html
Comment 8 Manuel Hiebel 2015-02-17 20:23:58 CET 
(In reply to Rémi Verschelde from comment #3)
> Fixed:
> http://gitweb.mageia.org/software/mgaonline/commit/
> ?id=f08f3ff5a6711cf0a8b551067933eca67d48b5f9

needs to fixed in mga4 if possible before mga5 is out (if a consensus is found)
Comment 9 Rémi Verschelde 2015-02-21 09:37:34 CET 
Thierry, would you be okay with me backporting this fix to Mageia 4:

text => N("Check for newer \"%s\" releases", "Mageia"),

I wouldn't touch the rest of the code needlessly, and would not break translations either.
Comment 10 Thierry Vignaud 2015-02-21 17:09:10 CET 
yes.
Comment 11 Rémi Verschelde 2015-02-22 20:48:18 CET 
Pushing this commit as an update to Mageia 4: http://gitweb.mageia.org/software/mgaonline/commit/?h=distro/mga4&id=c13a5c6711d0f2f9933404a31623d23fccbb31ea
(sorry about not splitting the commit btw, I thought I had committed my changes before bumping the version, but apparently I did not).

Suggested advisory:
===================

Updated mgaonline package fixes product name in mgaapplet-config

  Due to the fact that Mageia's product name is "Default" in /etc/product.id,
  mgaapplet-config used to propose to "Check for newer 'default' releases".

  This update fixes this by hardcoding "Mageia" as product name instead of
  looking it up in /etc/product.id (mga#13230).


References:
===========
 - https://bugs.mageia.org/show_bug.cgi?id=13230


RPM in core/updates_testing:
=============================
 - mgaonline-3.10.1-1.mga4.noarch


SRPM:
=====
 - mgaonline-3.10.1-1.mga4.src.rpm

Version: Cauldron => 4
Assignee: remi => qa-bugs
Whiteboard: MGA4TOO => (none)

Rémi Verschelde 2015-02-22 20:48:36 CET

Source RPM: mgaonline-2.81-1.mga3.src.rpm => mgaonline-3.10-1.mga4

Comment 12 Dave Hodgins 2015-02-23 20:00:43 CET 
Testing complete on Mageia 4 x86_64.

CC: (none) => davidwhodgins
Whiteboard: (none) => MGA4-64-OK

Comment 13 Dave Hodgins 2015-02-23 20:10:31 CET 
Advisory added to svn. As this is a noarch package, validating.

Someone from the sysadmin team please push 13230 to Magiea 4
Core Updates.

Whiteboard: MGA4-64-OK => MGA4-64-OK advisory validated_update

Comment 14 Dave Hodgins 2015-02-23 20:22:33 CET 
Oops. Moving the validated_update from the whiteboard to the
keywords.

Someone from the sysadmin team please push 13230.adv to Magiea 4
Core Updates.

Keywords: (none) => validated_update
Whiteboard: MGA4-64-OK advisory validated_update => MGA4-64-OK advisory
CC: (none) => sysadmin-bugs

Comment 15 Mageia Robot 2015-02-24 22:20:44 CET 
An update for this issue has been pushed to Mageia Updates repository.

http://advisories.mageia.org/MGAA-2015-0015.html

Status: REOPENED => RESOLVED
Resolution: (none) => FIXED
Note You need to log in before you can comment on or make changes to this bug.