Bug 12950 - MGA4 Remmina package is missing a desktop file
Summary: MGA4 Remmina package is missing a desktop file
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 4
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL: http://remmina.sourceforge.net/
Whiteboard: mga4-64-ok mga4-32-ok advisory
Keywords: Junior_job, Triaged, validated_update
Depends on:
Blocks:
 
Reported: 2014-03-06 14:56 CET by Davy Defaud
Modified: 2014-03-27 11:07 CET (History)
7 users (show)

See Also:
Source RPM: remmina-1.0.0-4.mga4.src.rpm
CVE:
Status comment:


Attachments
Remmina French translation update patch (59.90 KB, patch)
2014-03-26 16:13 CET, Davy Defaud
Details | Diff

Description Davy Defaud 2014-03-06 14:56:10 CET
Description of problem:
MGA4 Remmina package is missing a desktop file preventing its displaying in any menu or GNOME shell application laucher

Version-Release number of selected component (if applicable):
Cauldron, MGA4 and perhaps even MGA3.



Reproducible: 

Steps to Reproduce:
Manuel Hiebel 2014-03-09 13:59:19 CET

Keywords: (none) => Junior_job, Triaged
CC: (none) => bersuit.vera, juan.baptiste, saispo

Alfonso Vera 2014-03-10 14:53:41 CET

Assignee: bugsquad => bersuit.vera

Comment 1 Alfonso Vera 2014-03-15 10:15:27 CET
I have uploaded a patched/updated package for Mageia 4.

Suggested advisory:
========================
Updated remmina packages to fix #mga12950
This update add missing desktop entry 

References:
https://bugs.mageia.org/show_bug.cgi?id=12950
========================

Updated packages in core/updates_testing:
========================
remmina-devel-1.0.0-4.1.mga4.
remmina-plugins-common-1.0.0-4.1.mga4
remmina-plugins-gnome-1.0.0-4.1.mga4
remmina-plugins-nx-1.0.0-4.1.mga4
remmina-plugins-rdp-1.0.0-4.1.mga4
remmina-plugins-telepathy-1.0.0-4.1
remmina-plugins-vnc-1.0.0-4.1.mga4
remmina-plugins-xdmcp-1.0.0-4.1.mga4


Source RPMs: 
remmina-1.0.0-4.1.mga4.src.rpm
Comment 2 Alfonso Vera 2014-03-15 10:19:25 CET
Hi all
Juancho: Can you please, revise & push the update ? 
QA: I tested the update in mga4 x64 lxde and it's work fine
I'm working to patch cauldron ASAP
Comment 3 Manuel Hiebel 2014-03-15 22:02:32 CET
This bug isn't assigned yet to QA, a mistake ?
Comment 4 Juan Luis Baptiste 2014-03-15 22:42:54 CET
Pushed.
Alfonso Vera 2014-03-15 23:17:07 CET

Assignee: bersuit.vera => qa-bugs

Comment 5 David GEIGER 2014-03-21 18:14:24 CET
Tested mga4_64,

Testing complete for remmina-1.0.0-4.1.mga4, seems work here, I confirm the fix of bug:

Before :

$ LC_ALL=C cat /usr/share/applications/remmina.desktop
cat: /usr/share/applications/remmina.desktop: No such file or directory

$ remmina
Remmina plugin SFTP (type=Protocole) registered.
Remmina plugin SSH (type=Protocole) registered.

-----------------------------------------------------------------------------

After:

$ LC_ALL=C cat /usr/share/applications/remmina.desktop
[Desktop Entry]
Version=1.0
Name=Remmina Remote Desktop Client
Comment=Connect to remote desktops
TryExec=remmina
Exec=remmina
Icon=remmina
Terminal=false
Type=Application
Actions=
Categories=GTK;GNOME;X-GNOME-NetworkSettings;Network;

$ remmina
Remmina plugin SFTP (type=Protocole) registered.
Remmina plugin SSH (type=Protocole) registered.

CC: (none) => geiger.david68210
Whiteboard: (none) => mga4-64-ok

Comment 6 David GEIGER 2014-03-21 18:18:29 CET
Tested mga4_32,

Testing complete for remmina-1.0.0-4.1.mga4, seems work here, I confirm the fix of bug too:

Before:

$ LC_ALL=C cat /usr/share/applications/remmina.desktop
cat: /usr/share/applications/remmina.desktop: No such file or directory

$ remmina 
Remmina plugin SFTP (type=Protocole) registered.
Remmina plugin SSH (type=Protocole) registered.

--------------------------------------------------------------------------

After :

$ LC_ALL=C cat /usr/share/applications/remmina.desktop
[Desktop Entry]
Version=1.0
Name=Remmina Remote Desktop Client
Comment=Connect to remote desktops
TryExec=remmina
Exec=remmina
Icon=remmina
Terminal=false
Type=Application
Actions=
Categories=GTK;GNOME;X-GNOME-NetworkSettings;Network;

$ remmina 
Remmina plugin SFTP (type=Protocole) registered.
Remmina plugin SSH (type=Protocole) registered.

Whiteboard: mga4-64-ok => mga4-64-ok mga4-32-ok

Comment 7 Dave Hodgins 2014-03-23 21:41:49 CET
Advisory uploaded to svn. Validating the update.

Someone from the sysadmin team please push 12950.adv to updates.

Keywords: (none) => validated_update
Whiteboard: mga4-64-ok mga4-32-ok => mga4-64-ok mga4-32-ok advisory
CC: (none) => davidwhodgins, sysadmin-bugs

Comment 8 Davy Defaud 2014-03-24 01:05:42 CET
Are you sure about the way you fixed the build?
Name and Comment entries are supposed to be translated. I'm the author of the French translation that I've just updated (it would be nice to grab it from upstream...).
You should have at least those 2 more lines in the desktop file:

Name[fr]=Visionneur de bureaux distants Remmina
Comment[fr]=Connectez-vous à des bureaux distants
Comment 9 Thomas Backlund 2014-03-24 08:42:31 CET

Update pushed:
http://advisories.mageia.org/MGAA-2014-0087.html

Status: NEW => RESOLVED
CC: (none) => tmb
Resolution: (none) => FIXED

Comment 10 David GEIGER 2014-03-24 23:45:29 CET
(In reply to Davy Defaud from comment #8)
> Are you sure about the way you fixed the build?
> Name and Comment entries are supposed to be translated. I'm the author of
> the French translation that I've just updated (it would be nice to grab it
> from upstream...).
> You should have at least those 2 more lines in the desktop file:
> 
> Name[fr]=Visionneur de bureaux distants Remmina
> Comment[fr]=Connectez-vous à des bureaux distants

Indeed you are right it really missing translations for the desktop file.

it is now fixed and submitted on Cauldron (.mga5) :

http://svnweb.mageia.org/packages?view=revision&revision=607866


I'll open a new bug (probably tomorrow) and fix it for mga4 too.
Comment 11 Davy Defaud 2014-03-26 16:13:37 CET
Created attachment 5076 [details]
Remmina French translation update patch
Comment 12 Davy Defaud 2014-03-26 16:19:11 CET
(In reply to David GEIGER from comment #10)
> I'll open a new bug (probably tomorrow) and fix it for mga4 too.

Thanks! :-)

May I ask you to make an ultimate build with the attached patch containing the updated French translation (that I already sent to upstream)?

TIA
Comment 13 David GEIGER 2014-03-26 17:26:36 CET
Hi,

This bug is closed, 

can you attached your patch in this one : bug 13085 , please.

Thanks ! :)
Comment 14 Davy Defaud 2014-03-27 10:44:58 CET
OK. Done!
Davy Defaud 2014-03-27 11:07:12 CET

Attachment 5076 is obsolete: 0 => 1


Note You need to log in before you can comment on or make changes to this bug.