Bug 12694 - LXDE packages provide untranslated and duplicate register.desktop file
Summary: LXDE packages provide untranslated and duplicate register.desktop file
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 4
Hardware: All Linux
Priority: Normal minor
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL:
Whiteboard: MGA4-64-OK MGA4-32-OK advisory
Keywords: Triaged, validated_update
Depends on:
Blocks: 12667
  Show dependency treegraph
 
Reported: 2014-02-09 23:03 CET by Atilla ÖNTAŞ
Modified: 2014-02-12 19:15 CET (History)
5 users (show)

See Also:
Source RPM: mageia-lxde-config-Default, lxde-common
CVE:
Status comment:


Attachments

Description Atilla ÖNTAŞ 2014-02-09 23:03:31 CET
Root of the original bug:
I'm looking at lxde and mate related packages.(In reply to Alex Loginov from comment #0)
> Description of problem:
> register.desktop was in desktop-common-data before only, but now in 3
> packages, and I see different register.desktop, and all are with i18n
> problems.
> 
> In all register.desktop must be:
> Name[ru]=СообÑеÑÑво Mageia
> 
> There is no commit in desktop-common-data:
> http://gitweb.mageia.org/software/desktop/common-data/commit/
> ?id=82a6d795fc02f2a93136fb4628ec6f9d74497e6b
> and there is old translation in desktop-common-data-3.5-2.mga4.noarch.rpm.
> 
> In mageia-lxde-config-Default, mate-session-manager no:
> Name[ru]=СообÑеÑÑво Mageia
> 
> Version-Release number of selected component (if applicable):
> mageia-lxde-config-Default-0.6.2-5.mga4.noarch.rpm
> desktop-common-data-3.5-2.mga4.noarch.rpm
> mate-session-manager-1.6.1-6.mga4.i586.rpm
> 
> How reproducible: always
> 
> 
> Steps to Reproduce:
> 1. Install KDE, MATE, LXDE in Russian
> 2. See the Desktop
> 3. In KDE - old translation
> 4. In MATE and LXDE - no Russian translation

This bug report addresses LXDE packages. mageie-lxde-config provides additional register.desktop file and lxde-common needs that. This is wrong. Only desktop-common-data should provide that file. 

Updated lxde-common and mageia-lxde-config packages already submitted to Cauldron.
Atilla ÖNTAŞ 2014-02-09 23:18:50 CET

CC: (none) => loginov_alex

Comment 1 Atilla ÖNTAŞ 2014-02-10 00:23:43 CET
I have uploaded updated mageia-lxde-config-Default-0.6.2-5.1.mga4 and  lxde-common-0.5.5-19.1.mga4 packages for Mageia 4.

Suggested advisory:
========================

Updated mageia-lxde-config-Default-0.6.2-5.1.mga4 and lxde-common-0.5.5-19.1.mga4 fixes:

Currently register.desktop file which displayed by default at all DE's desktop; provided by desktop-common-data with full translations support through our i18n team work.

mageia-lxde-config-Default package was providing another register.desktop file which have no translations at all and lxde-common package was using that file to provide lxde desktop icons.

This update removes register.desktop file from mageia-lxde-config-Default package and makes lxde-common to use register.destop file provided by desktop-common-data package.

Of course, with this update also desktop-common-package is listed as Requires for lxde-common package.
========================

Updated packages in core/updates_testing:
========================
mageia-lxde-config-Default-0.6.2-5.1.mga4
lxde-common-0.5.5-19.1.mga4

Source RPMs: 
========================
lxde-common-0.5.5-19.1.mga4.src.rpm
mageia-lxde-config-0.6.2-5.1.mga4.src.rpm

Assignee: tarakbumba => qa-bugs

Comment 2 Shlomi Fish 2014-02-11 14:55:38 CET
Hi Atilla,

I'd like to work on this bug, but I don't speak or read Russian (I only recognise the pronunciation of a small subset of the Cyrillic alphabet, and don't know the meaning of most of what I can read). Can I just test the LXDE interface in English to see that it is still working properly, or is a more elaborate testing procedure required? I can also test in Hebrew (which I'm not sure has a usable localisation for LXDE, but may work), and maybe Arabic, French, German and Spanish.

Regards,

-- Shlomi Fish

CC: (none) => shlomif

Comment 3 Atilla ÖNTAŞ 2014-02-11 15:31:37 CET
(In reply to Shlomi Fish from comment #2)
> Hi Atilla,
> 
> I'd like to work on this bug, but I don't speak or read Russian (I only
> recognise the pronunciation of a small subset of the Cyrillic alphabet, and
> don't know the meaning of most of what I can read). Can I just test the LXDE
> interface in English to see that it is still working properly, or is a more
> elaborate testing procedure required? I can also test in Hebrew (which I'm
> not sure has a usable localisation for LXDE, but may work), and maybe
> Arabic, French, German and Spanish.
> 
> Regards,
> 
> -- Shlomi Fish
Hi Shlomi, register.desktop file translations is another issue which is related with bug#12667

You can test LXDE related packages updated here by:
1- Remove your home.desktop, trash.desktop and register.desktop from your Desktop
2- Remove or rename your $HOME/.config/openbox/lxde-rc.xml file
3- Install both mageia-lxde-config and lxde-common packages from updates/testing
4- Test if destop files, especially register.desktop is created after logout and login again.

These updates have one logic, do not provide a common file if it is already provided by another package. In our case this file is register.desktop.

Thanks and good luck at your tests!
Comment 4 Shlomi Fish 2014-02-11 15:55:39 CET
(In reply to Atilla ÃNTAÅ from comment #3)
> (In reply to Shlomi Fish from comment #2)
> > Hi Atilla,
> > 
> > I'd like to work on this bug, but I don't speak or read Russian (I only
> > recognise the pronunciation of a small subset of the Cyrillic alphabet, and
> > don't know the meaning of most of what I can read). Can I just test the LXDE
> > interface in English to see that it is still working properly, or is a more
> > elaborate testing procedure required? I can also test in Hebrew (which I'm
> > not sure has a usable localisation for LXDE, but may work), and maybe
> > Arabic, French, German and Spanish.
> > 
> > Regards,
> > 
> > -- Shlomi Fish
> Hi Shlomi, register.desktop file translations is another issue which is
> related with bug#12667
> 
> You can test LXDE related packages updated here by:
> 1- Remove your home.desktop, trash.desktop and register.desktop from your
> Desktop
> 2- Remove or rename your $HOME/.config/openbox/lxde-rc.xml file
> 3- Install both mageia-lxde-config and lxde-common packages from
> updates/testing
> 4- Test if destop files, especially register.desktop is created after logout
> and login again.
> 
> These updates have one logic, do not provide a common file if it is already
> provided by another package. In our case this file is register.desktop.
> 
> Thanks and good luck at your tests!

Thanks, I think I'll just create a new user for that.

Regards,

-- Shlomi Fish
Comment 5 Shlomi Fish 2014-02-11 16:45:55 CET
Hi Atilla,

(In reply to Atilla ÃNTAÅ from comment #3)
> (In reply to Shlomi Fish from comment #2)
> > Hi Atilla,
> > 
> > I'd like to work on this bug, but I don't speak or read Russian (I only
> > recognise the pronunciation of a small subset of the Cyrillic alphabet, and
> > don't know the meaning of most of what I can read). Can I just test the LXDE
> > interface in English to see that it is still working properly, or is a more
> > elaborate testing procedure required? I can also test in Hebrew (which I'm
> > not sure has a usable localisation for LXDE, but may work), and maybe
> > Arabic, French, German and Spanish.
> > 
> > Regards,
> > 
> > -- Shlomi Fish
> Hi Shlomi, register.desktop file translations is another issue which is
> related with bug#12667
> 
> You can test LXDE related packages updated here by:
> 1- Remove your home.desktop, trash.desktop and register.desktop from your
> Desktop
> 2- Remove or rename your $HOME/.config/openbox/lxde-rc.xml file
> 3- Install both mageia-lxde-config and lxde-common packages from
> updates/testing
> 4- Test if destop files, especially register.desktop is created after logout
> and login again.
> 
> These updates have one logic, do not provide a common file if it is already
> provided by another package. In our case this file is register.desktop.
> 
> Thanks and good luck at your tests!

I installed them both on my x86-64 Duo Core laptop - everything seems fine in a new user.

Regards,

-- Shlomi Fish
Shlomi Fish 2014-02-11 16:58:06 CET

Whiteboard: (none) => MGA4-64-OK

Comment 6 Alex Loginov 2014-02-12 12:56:26 CET
MGA4-32-OK: file register.desktop was used from desktop-common-data package in LXDE.
Atilla, thank you for fast fixing.

Whiteboard: MGA4-64-OK => MGA4-64-OK MGA4-32-OK

Comment 7 Rémi Verschelde 2014-02-12 16:54:16 CET
Validating update.

Advisory uploaded, could a sysadmin push to 4 core/updates?

Keywords: (none) => validated_update
Whiteboard: MGA4-64-OK MGA4-32-OK => MGA4-64-OK MGA4-32-OK advisory
CC: (none) => remi, sysadmin-bugs

Comment 8 Thomas Backlund 2014-02-12 19:15:54 CET
Update pushed:
http://advisories.mageia.org/MGAA-2014-0039.html

Status: NEW => RESOLVED
CC: (none) => tmb
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.