Bug 12670 - Update request: lightdm
Summary: Update request: lightdm
Status: RESOLVED INVALID
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 4
Hardware: All Linux
Priority: Normal normal
Target Milestone: ---
Assignee: Jani Välimaa
QA Contact:
URL:
Whiteboard: MGA3TOO has_procedure MGA3-32-OK mga4...
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-08 20:01 CET by Jani Välimaa
Modified: 2015-03-07 19:36 CET (History)
7 users (show)

See Also:
Source RPM: lightdm
CVE:
Status comment:


Attachments

Description Jani Välimaa 2014-02-08 20:01:52 CET
New lightdm releases for mga3 [1] and mga4 [2] in core/updates_testing fixes (according to upstream) "Correctly invoke PAM to change authentication token" issue.

Mga3 version jumps directly from 1.4.4 to 1.4.6, but changes in 1.4.5 [3] is irrelevant to us and new files are removed during the build.

Steps to reproduce fixed issues are descripbed in debian bug tracker:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=735670#27

[1] lightdm-1.4.6-1.mga3
[2] lightdm-1.8.7-1.mga4
[3] http://lists.freedesktop.org/archives/lightdm/2013-October/000460.html

Reproducible: 

Steps to Reproduce:
Jani Välimaa 2014-02-08 20:02:07 CET

Whiteboard: (none) => MGA3TOO

Manuel Hiebel 2014-02-08 22:54:31 CET

Whiteboard: MGA3TOO => MGA3TOO mga4-64-ok

Comment 1 Rémi Verschelde 2014-02-10 15:38:28 CET
I'll test Mageia 4 i586 in a few hours, unless it's already been done until then.

CC: (none) => remi

Rémi Verschelde 2014-02-10 19:00:56 CET

Whiteboard: MGA3TOO mga4-64-ok => MGA3TOO mga4-64-ok has_procedure

Comment 2 Rémi Verschelde 2014-02-10 19:17:53 CET
RPMs:
* mga3 - lightdm-1.4.6-1.mga3
       - liblightdm-gobject1_0-1.4.6-1.mga3
* mga4 - lightdm-1.8.7-1.mga4
       - liblightdm-gobject1_0-1.8.7-1.mga4
Comment 3 Rémi Verschelde 2014-02-10 19:43:47 CET
Tested lightdm 1.8.7 Mageia 4 i586.

I could reproduce the issue following the procedure linked in comment 0.
The update candidate fixes this issue, but the behaviour is so counter-intuitive that I'm not sure it's not a regression.

When one should change his password, here are the following paths that a user might try in comparison to what he is supposed to do:
1. Type in your actual password, validate.
2. Lightdm displays: "Change password for $user."
  2.1 Type in a new (strong) password, validate. Lightdm answers: "Incorrect password, please try again"
  2.2 Start again with 1., then guesse (!) that you have to type in your former password a second time! (though the message is "Change password for $user.") Validate.
3. Lightdm shows nothing. Type in your new (strong) password, validate.
4. Lightdm still shows nothing. Type in your new (strong) password again, validate. You're now logging in.

Jani, can you test wether this issue comes from your package/from the upstream release/was always there?

Whiteboard: MGA3TOO mga4-64-ok has_procedure => MGA3TOO mga4-64-ok has_procedure feedback

Comment 4 Jani Välimaa 2014-02-10 20:00:48 CET
Same fix was pushed to 1.2, 1.4 and 1.8 series, so it's been there for some time.
Comment 5 Rémi Verschelde 2014-02-26 14:18:39 CET
Testing again on Mageia 4 x86_64/

Behaviour in lightdm-1.8.6-1.mga4:
When the user has to change her password, the prompt in lightdm is as follows:

1. Type in your old password
2. Lightdm displays: "You are required to change your password immediately."
3. Type in your new password
4. It is changed without confirmation, and you can now type in the new password to log in


Behaviour in lightdm-1.8.7-1.mga4:
As reported in comment 3.

I think the behaviour with lightdm-1.8.6-1.mga4 was better (though not optimal either), so I'm not sure we should go on with this update candidate. Better wait for upstream to *really* fix this.
Comment 6 Jani Välimaa 2014-02-26 14:55:30 CET
IIUC the point is that without this new version user can change passwd to one which doesn't pass checks, like length and simplicity, because UNIX__IAMROOT pam flag is mistakenly set and being root by-passes checks.

See also:
https://bugs.launchpad.net/lightdm/+bug/869501
Comment 7 Rémi Verschelde 2014-02-26 15:06:06 CET
That's what I understood too, and the update candidate does fix it. But IMO it introduces a regression which isn't particularly better as the bug it fixes.

Well security-wise, it might be better, but if you're not too astute, you can just end up not being able to log in again :)

We can assume people having set up a password expiration time can find their way through a counter-intuitive DM.

BTW I don't know much about lightdm's usptream, but is it normal that https://bugs.launchpad.net/lightdm/+bug/869501 is tagged as released for Debian but not for the whole project?

Whiteboard: MGA3TOO mga4-64-ok has_procedure feedback => MGA3TOO mga4-32-ok mga4-64-ok has_procedure feedback

Comment 8 Jani Välimaa 2014-02-26 15:12:19 CET
(In reply to Rémi Verschelde from comment #7)
> That's what I understood too, and the update candidate does fix it. But IMO
> it introduces a regression which isn't particularly better as the bug it
> fixes.
> 

Then you should consider to reporting it directly to upstream.
Comment 9 Rémi Verschelde 2014-02-26 15:33:53 CET
https://bugs.launchpad.net/lightdm/+bug/869501/comments/9
Comment 10 Samuel Verschelde 2014-02-26 17:10:02 CET
According to comment #6, this seems to fix a security issue (admin sets password checks and users don't need to respect them), so while I agree that there's a regression regarding users, I think we could want to push it.

But my real position is: let's wait for a few days if upstream answers Rémi's bug report with a comment and/or a fix. It would be even better to have a version that fixes both the PAM issue and user experience.

Could be interesting to test with an english locale, too, maybe it's just a bad misleading translation.

CC: (none) => stormi

Comment 11 Rémi Verschelde 2014-03-10 19:24:41 CET
Let's proceed with this update, since upstream does not react to my comment. Testing needing on Mageia 3.

Whiteboard: MGA3TOO mga4-32-ok mga4-64-ok has_procedure feedback => MGA3TOO mga4-32-ok mga4-64-ok has_procedure

Dave Hodgins 2014-03-23 21:46:21 CET

CC: (none) => davidwhodgins
Whiteboard: MGA3TOO mga4-32-ok mga4-64-ok has_procedure => MGA3TOO mga4-32-ok mga4-64-ok has_procedure mga3too

Comment 12 William Kenney 2014-04-05 19:04:43 CEST
In VirtualBox, M3, KDE, 32-bit

Package(s) under test:
lightdm

The test proceedure reads as follows:

1) install lightdm ( OK done )
2) create a new test user (call it "giulio", set password "giulio")
# adduser giulio ( OK done )
3) login with giulio and try to change the account password
giulio$ passwd ( and how do you "login with giulio" in lightdm)

There is no choice for lighdm in the login menu and there is no
choice for lightdm in MCC -> System -> Manage users on system

How do you login to giulio using the lightdm GUI?

CC: (none) => wilcal.int

Comment 13 James Kerr 2014-04-05 22:12:28 CEST
I've never used lightdm, but I would have expected that if you set lightdm as the DM in MCC/Boot/Set up display manager, then you should be able to login as any user.
Comment 14 William Kenney 2014-04-05 22:39:34 CEST
(In reply to James Kerr from comment #13)

> I've never used lightdm, but I would have expected that if you set lightdm
> as the DM in MCC/Boot/Set up display manager, then you should be able to
> login as any user.

I agree and that does not appear to be the case.
Or I do not understand something.
Comment 15 Dave Hodgins 2014-04-06 01:09:12 CEST
Just checked. While it seems to default to the last logged in user, the
user selection button is a drop down menu (note the down arrow at the
end of the user name), so if you click on that button, it does present
the list of available users (including "other", where you can type in
the user, such as root).  Also note the icons at the top right, where
you can select which desktop manager to use, etc.
Comment 16 Dave Hodgins 2014-04-06 01:13:29 CEST
I should also add, that to use lightdm, run mcc, select boot, then "Set
up the display manager", and select lightdm. Note that lightdm must be
installed before it will show up as a selectable option.
Comment 17 William Kenney 2014-04-17 19:55:16 CEST
In VirtualBox, M3, KDE, 32-bit

Package(s) under test:
lightdm

The test proceedure reads as follows:

1) install lightdm ( OK done )
2) create a new test user (call it "giulio", set password "giulio")
3) reboot system

Repeated trys there is no choice for lighdm in the login menu and there
is no choice for lightdm in MCC -> System -> Manage users on system.
Comment 18 Rémi Verschelde 2014-04-17 20:02:46 CEST
(In reply to William Kenney from comment #17)
> Repeated trys there is no choice for lighdm in the login menu and there
> is no choice for lightdm in MCC -> System -> Manage users on system.

LightDM is a display manager, i.e. it _is_ the login menu. You are currently using another display manager, probably KDM since you installed the KDE version of Mageia.

To change the display manager, you need to go to: MCC > Boot > Set up display manager. There you should be able to select LightDM.
Comment 19 William Kenney 2014-04-17 20:55:50 CEST
(In reply to Rémi Verschelde from comment #18)

> To change the display manager, you need to go to: MCC > Boot > Set up
> display manager. There you should be able to select LightDM.

I agree that is the way it should work but for me on Vbox M3 it does not.
Comment 20 Rémi Verschelde 2014-04-17 21:03:12 CEST
In comment 17 you wrote about "MCC > System > Manage users on system", but the DM has to be configured in "MCC > Boot > Set up display manager". Are you sure you checked the latter? If so, could you give the output of "rpm -qa | grep lightdm"?
Comment 21 Guillaume 2014-04-21 12:02:30 CEST
All is working for me. i586 with KDE.
Should we first push the update to 4/core/updates instead of waiting tests for Mageia 3 ?

CC: (none) => filorin.mageia

Comment 22 Carolyn Rowse 2014-05-05 11:23:54 CEST
Confirm bug fixed for Mga3 32-bit using real hw.

Unable to test Mga3 64-bit.

Carolyn

CC: (none) => cmrisolde
Whiteboard: MGA3TOO mga4-32-ok mga4-64-ok has_procedure mga3too => MGA3TOO mga4-32-ok mga4-64-ok has_procedure mga3too MGA3-32-OK

Comment 23 Carolyn Rowse 2014-05-05 16:43:52 CEST
Well, I've now got Mga3 64-bit installed again, but on testing this update it doesn't appear to have fixed the bug for this arch, lightdm is still allowing me to choose a very short password for my test user such as "g" or "h".

Carolyn
Comment 24 claire robinson 2014-05-06 14:48:48 CEST
Thanks Carolyn, adding 'feedback' whiteboard marker

Whiteboard: MGA3TOO mga4-32-ok mga4-64-ok has_procedure mga3too MGA3-32-OK => MGA3TOO has_procedure feedback MGA3-32-OK mga4-32-ok mga4-64-ok

Comment 25 Rémi Verschelde 2014-05-12 23:58:19 CEST
Confirming comment 23, the issue is not fixed by the update candidate on mga3 64bit, unless I'm missing something. I could set a one-letter password without any issue.
Comment 26 Rémi Verschelde 2014-05-13 00:05:15 CEST
For the record I did install both lightdm and lib64lightdm-gobject1_0 from core/updates_testing.
Comment 27 claire robinson 2014-05-23 13:23:01 CEST
Assigning back to you for now Jani. Please reassign when you're ready. Thanks.

CC: (none) => qa-bugs
Assignee: qa-bugs => jani.valimaa
Whiteboard: MGA3TOO has_procedure feedback MGA3-32-OK mga4-32-ok mga4-64-ok => MGA3TOO has_procedure MGA3-32-OK mga4-32-ok mga4-64-ok

Comment 28 Jani Välimaa 2015-03-07 19:36:21 CET
Closing as INVALID as lightdm pkgs were removed from mga4 core/updates_testing.

Status: NEW => RESOLVED
Resolution: (none) => INVALID


Note You need to log in before you can comment on or make changes to this bug.