If someone makes a commit in git and includes "mga#123" in the commit message, a comment should be added to the bug to reference the commit. Reproducible: Steps to Reproduce:
Testing 123
Testing 456
commit f3a394aa05a757a8fea7852fe787665da0c4712c Author: Colin Guthrie <colin@mageia.org> Date: Sat Dec 14 18:32:22 2013 +0000 Test bugzilla integration mga#11987 --- Commit Link: http://gitweb.mageia.org/software/test/commit/?id=f3a394aa05a757a8fea7852fe787665da0c4712c Bug links: Mageia https://bugs.mageia.org/show_bug.cgi?id=11987 README | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/README b/README new file mode 100644 index 0000000..29092d9 --- /dev/null +++ b/README @@ -0,0 +1 @@ +This is just a test README file.
commit f3a394aa05a757a8fea7852fe787665da0c4712c Author: Colin Guthrie <colin@mageia.org> Date: Sat Dec 14 18:32:22 2013 +0000 Test bugzilla integration mga#11987 --- Commit Link: http://gitweb.mageia.org/software/test/commit/?id=f3a394aa05a757a8fea7852fe787665da0c4712c Bug links: Mageia https://bugs.mageia.org/show_bug.cgi?id=11987
commit f3a394aa05a757a8fea7852fe787665da0c4712c Author: Colin Guthrie <colin@...> Date: Sat Dec 14 18:32:22 2013 +0000 Test bugzilla integration mga#11987 --- Commit Link: http://gitweb.mageia.org/software/test/commit/?id=f3a394aa05a757a8fea7852fe787665da0c4712c Bug links: Mageia https://bugs.mageia.org/show_bug.cgi?id=11987
is this needed ? (In reply to Mageia Robot from comment #7) > > Bug links: > Mageia > https://bugs.mageia.org/show_bug.cgi?id=11987
(In reply to Manuel Hiebel from comment #8) > is this needed ? > > (In reply to Mageia Robot from comment #7) > > > > Bug links: > > Mageia > > https://bugs.mageia.org/show_bug.cgi?id=11987 Not directly, but in git you can also reference both multiple internal bugs (i.e. mga#123 mga#456) and external bugs (e.g. fdo#123, rhbz#123) in which case I think it's nice to include the full bug links. I will try and add support to strip this out if only one bug is referenced.
commit 7c03a0f17401edaf41c27dda3bd108b944a027f2 Author: Colin Guthrie <colin@...> Date: Sat Dec 14 21:15:27 2013 +0000 Test bugzilla integration some more again. mga#11987 --- Commit Link: http://gitweb.mageia.org/software/test/commit/?id=7c03a0f17401edaf41c27dda3bd108b944a027f2 Bug links:
oki make sense btw, bugzilla convert bug 123 as an url
or bug#123
There we go! Fixed! (I've fixed the off-by-one error I had in the above test!) And yeah I'm aware of the magic bug linking in bugzilla, but this is the same code that generates the emails too (it's practically the same message, just truncated) so I'm not going to spend time formatting it specially when the code that generates bug links is generic for all bug trackers we may want to reference, not just our own. A full URL is fine for this IMO
Seeing as this is now committed to puppet and deployed manually too, this should be implemented now.
Status: NEW => RESOLVEDResolution: (none) => FIXED
Depends on: (none) => 13859