Bug 11531 - oxygen-gtk3 truncates emacs windows
Summary: oxygen-gtk3 truncates emacs windows
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: Cauldron
Hardware: x86_64 Linux
Priority: Normal normal
Target Milestone: ---
Assignee: Mageia Bug Squad
QA Contact:
URL:
Whiteboard:
Keywords: NEEDINFO
: 10706 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-10-24 18:33 CEST by Chris Denice
Modified: 2013-12-23 22:43 CET (History)
4 users (show)

See Also:
Source RPM: oxygen-gtk3-1.2.0-3.mga4.src.rpm
CVE:
Status comment:


Attachments
adwaita theme, full screen (36.51 KB, image/png)
2013-12-01 19:46 CET, Chris Denice
Details
adwaita max vertical (34.90 KB, image/png)
2013-12-01 19:48 CET, Chris Denice
Details
adwaita normal (32.69 KB, image/png)
2013-12-01 19:48 CET, Chris Denice
Details
oxygen-gtk3 full screen (33.36 KB, image/png)
2013-12-01 19:49 CET, Chris Denice
Details
oxygen-gtk3 max vertical (35.54 KB, image/png)
2013-12-01 19:49 CET, Chris Denice
Details
oxygen-gtk3 normal (nice rounded corners) (40.38 KB, image/png)
2013-12-01 19:50 CET, Chris Denice
Details
proposed patch (2.08 KB, patch)
2013-12-02 10:48 CET, Hugo Pereira Da Costa
Details | Diff

Description Chris Denice 2013-10-24 18:33:37 CEST
Description of problem:

oxygen-gtk3 theme renders emacs windows unextendable verically as it truncates its lower part


Steps to Reproduce:
1. Go under fvwm2 or icewm, or openbox, lxde, something which is not gnome; but with oxygen-gtk3 installed.

2 .Open an "emacs" windows (in a terminal, just type emacs)

3. Look how funny it is. It has round corners, but if you try to maximize it, either by clicking on the button maximize or with the mouse, you end up with a translucent unusable extra space.

Remove oxygen-gtk3:

As root:
urpme oxygen-gtk3

Try again, and everything works fine.

Cheers.




Reproducible: 

Steps to Reproduce:
Comment 1 Manuel Hiebel 2013-10-24 23:14:14 CEST
hugo, something for you ?

CC: (none) => hugo

Comment 2 Bit Twister 2013-11-18 20:57:01 CET
(In reply to Chris Denice from comment #0)
> 
> Steps to Reproduce:
> 1. Go under fvwm2 or icewm, or openbox, lxde, something which is not gnome;
> but with oxygen-gtk3 installed.

I confirm the problem on kde beta 1, and I have desktop effects disabled.
Running with the Oxygen desktop theme.

CC: (none) => junknospam

Comment 3 David Walser 2013-11-22 19:01:23 CET
*** Bug 10706 has been marked as a duplicate of this bug. ***

CC: (none) => pierre-malo.denielou

Comment 4 Hugo Pereira Da Costa 2013-11-25 10:53:53 CET
Very strange.

widget style should not affect the presence of window decoration in any way.
Did you try using another gtk3 theme ? (Adwaita) ? 
If problem persists, it must be a gtk3 bug (or an emacs + gtk3)

Also, you say:
without gtk3, then gtk2 should be used and it the look ugly.
Can you post screenshot ? 
emacs should work (and look nice) with oxygen-gtk2. 
(otherwise, means more problems again with emacs)

Finally: I don't have mageia4 here yet. Can you post versions of 
- emacs
- gtk3
- oxygen-gtk3 

?

Thanks !
Comment 5 Hugo Pereira Da Costa 2013-11-25 10:59:11 CET
In fact, I can reproduce here
Also happen with any gtk3 widget theme (including: "emacs" !)
So: definitly either a gtk3 bug, or an emacs bug.
Not oxygen-gtk. Sorry. My bet is actually emacs, setting weird X11 size hints and flags to the window manager, which confuse the window manager.

Should be reported to them directly.

Hugo
Comment 6 Thierry Vignaud 2013-11-30 12:00:24 CET
Please report that bug upstream at https://bugs.kde.org/ (Product=Oxygen
Component=gtk3-engine) and put the bug report URL in the URL field above

Keywords: (none) => NEEDINFO
CC: (none) => thierry.vignaud

Comment 7 Hugo Pereira Da Costa 2013-11-30 14:06:33 CET
@Thierry
As per comment #5
This is _not_ an oxygen-gtk3 bug, and should not be reported there
it is an emacs bug and should be reported to emacs.
Comment 8 Chris Denice 2013-12-01 18:45:37 CET
Hi guys,
I don't understand how it can be an emacs bug, the fact that emacs and others program interact with X11 how deep they want is perfectly fine. The job of gtk is to correcly override this to add its decorations no?

Nonetheless, I am pretty sure it *is* an oxygen-gtk theme issue [and that would not be the first time...]

First of all it seems very difficult to change theme under gtk3, gtk-chtheme only affects gtk2 themes. Googling around, I managed to find this trick:

0) with oxygen-gtk3 installed, check that starting emacs is screwed as described above.

1) create ~/.config/gtk-3.0

2) create a files "settings.ini" containing:
[Settings]
gtk-theme-name=Adwaita

(assuming the Adwaita-gtk3 theme is installed)

3) start emacs; everything works fine.

4) Edit the same file to:
[Settings]
gtk-theme-name=oxygen-gtk

5) start emacs; everything is screwed


cheers,
chris.
Comment 9 Hugo Pereira Da Costa 2013-12-01 18:47:56 CET
@Chris, 
well, here, with Adwaita (and Raleigh) things are screwed too.
I'll double check later on then.
For the record, oxygen-gtk has nothing to do with the window decoration
(this is handled by the window manager and depends whether you use kde, gnome, etc.)
Comment 10 Hugo Pereira Da Costa 2013-12-01 18:49:13 CET
As for comments like: "[and that would not be the first time...]"
These are non constructive, demotivating, and you are still free to use whatever suits you best. 
So, please ...
(also, feel free to contribute to make things better when they are not. That is actually how I started working on oxygen-gtk)
Comment 11 Hugo Pereira Da Costa 2013-12-01 18:56:56 CET
http://wstaw.org/m/2013/12/01/plasma-desktopxx3395.png
Screenshot with maximized truncated emacs window using Adwaita widget theme.
I have the same issue issue with oxygen-gtk3 here, and any other gtk3 theme.

Now, maybe this is not the same issue as what you are reporting, which is hard to tell since you did not post a screenshot.
Comment 12 Chris Denice 2013-12-01 19:46:59 CET
Created attachment 4554 [details]
adwaita theme, full screen
Comment 13 Chris Denice 2013-12-01 19:48:21 CET
Created attachment 4555 [details]
adwaita max vertical
Comment 14 Chris Denice 2013-12-01 19:48:41 CET
Created attachment 4556 [details]
adwaita normal
Comment 15 Chris Denice 2013-12-01 19:49:04 CET
Created attachment 4557 [details]
oxygen-gtk3 full screen
Comment 16 Chris Denice 2013-12-01 19:49:27 CET
Created attachment 4558 [details]
oxygen-gtk3 max vertical
Comment 17 Chris Denice 2013-12-01 19:50:20 CET
Created attachment 4559 [details]
oxygen-gtk3 normal (nice rounded corners)
Comment 18 Chris Denice 2013-12-01 19:50:38 CET
Sorry, I did not mean to be rude; I just wanted to stress that on a probabilistic basis, and in the absence of other informations, the bug has more chances to be on the theme rather than on emacs.

I am happy to help you, please tell me anything I can test. I can also report the bug upstream, but that would be nice first if we could agree on what it is, emacs or oxygen, or gtk.

For the screenshots, here they are! (under fvwm2)

cheers,
chris.
Comment 19 Hugo Pereira Da Costa 2013-12-01 19:58:16 CET
ok. Thanks for the screenshot, this is definitly different from the issues I am having.

In fact the so-called nice round corners (sic) should not be there.
This probably means that for some reason the emacs window is interpreted as a "menu" window (which would be an emacs bug), 

which tells oxygen-gtk to round the corners (as it does for menu) and probably indeed result in the incorrect maximizing. (and masking)

I'll investigate further (why the window is falsely recognized as a menu)


Finally: Thierry is right, now that I know better about the issue, it should better be reported to https://bugs.kde.org

best regards,

Hugo
Comment 20 Bit Twister 2013-12-01 20:37:08 CET
(In reply to Chris Denice from comment #8)
 
> 1) create ~/.config/gtk-3.0
> 2) create a files "settings.ini" containing:
> [Settings]
> gtk-theme-name=Adwaita

Thank you for sharing. 
That tweak solves the "round corners" problem on my KDE 64 bit install.
Comment 21 Thierry Vignaud 2013-12-02 07:39:13 CET
(In reply to Chris Denice from comment #8)
> First of all it seems very difficult to change theme under gtk3, gtk-chtheme
> only affects gtk2 themes. Googling around, I managed to find this trick:

just use gnome-tweak-tool
Comment 22 Hugo Pereira Da Costa 2013-12-02 10:47:31 CET
"Fixed" (that is: worked around) in git master. (both gtk3 and gtk3-1.2 branches)
Comment 23 Hugo Pereira Da Costa 2013-12-02 10:48:17 CET
Created attachment 4564 [details]
proposed patch
Comment 24 Chris Denice 2013-12-23 22:43:29 CET
Well done!

just tested with the fresh
oxygen-gtk3-1.3.1-2.mga4.src.rpm

and emacs works fine, only the menu gets rounded as expected. I am closing the bug then.

thanks for the work Hugo!

Cheers,
Chris.

Status: NEW => RESOLVED
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.