11237 – Enable uuid for RAID

Bug 11237 - Enable uuid for RAID

Summary: Enable uuid for RAID

Status:	NEEDINFO

Alias:	None

Product:	Mageia
Classification:	Unclassified
Component:	Installer (show other bugs)
Version:	Cauldron
Hardware:	i586 Linux

Priority:	Normal Severity: normal
Target Milestone:	---
Assignee:	Thierry Vignaud
QA Contact:

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:

Reported:	2013-09-16 09:51 CEST by Nicolas Lécureuil
Modified:	2021-03-06 14:27 CET (History)
CC List:	1 user (show)

See Also:
Source RPM:
CVE:
Status comment:

Attachments
enable UUIDs for /dev/mdX devices (347 bytes, patch) 2016-07-01 16:15 CEST, Thierry Vignaud	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Description Nicolas Lécureuil 2013-09-16 09:51:19 CEST

this patch allow to enable uuid for raid ( dmraid/mdadm ) :



diff --git a/perl-install/devices.pm b/perl-install/devices.pm
index 01e6662..4653792 100644
--- a/perl-install/devices.pm
+++ b/perl-install/devices.pm
@@ -230,7 +230,7 @@ sub prefix_for_dev {
 
 sub should_prefer_UUID {
     my ($dev) = @_;
-    $dev =~ /^((?:[hsv]|xv)d)/;
+    $dev =~ /^((?:[hsvm]|xv)d)|^(mapper)/;
 }
 
 sub symlink_now_and_register {


Reproducible: 

Steps to Reproduce:

Nicolas Lécureuil 2013-09-16 09:51:40 CEST

Assignee: bugsquad => thierry.vignaud

Comment 1 Thierry Vignaud 2013-09-17 18:07:31 CEST

Have you actually tested my patch?

Keywords: (none) => NEEDINFO

Comment 2 Nicolas Lécureuil 2013-10-03 00:47:06 CEST

i will this week.

As i couldn't i just pasted my co worker patch. He told me that w/o (mapper) there was no dmraid support. but i couldn't verify yet.

Comment 3 Nicolas Lécureuil 2013-10-08 11:07:45 CEST

but after testing, to have uuid in grub i need the attached patch, your seems to work only if we install with mdadm directly.

Comment 4 Thierry Vignaud 2013-10-08 19:46:27 CEST

Which attachment?

Comment 5 Nicolas Lécureuil 2013-10-08 22:17:57 CEST

i mean the one in the initial bugreport. I tried yours but grub wasn't using UUID then.

I think this is because our installer use dmraid by default ( i think we should migrate our installer to make use of mdadm by default instead )

Comment 6 Dick Gevers 2014-12-03 16:31:20 CET

@tv and @mageia@nicolaslecureuil.fr

It is not clear from this BR who is waiting for whom to give more info since 14 months. Please review if still current or if otherwise: close please. Thanks

Thierry Vignaud 2015-04-28 07:17:30 CEST

Keywords: (none) => PATCH

Comment 7 Thierry Vignaud 2015-04-28 12:24:56 CEST

I'll work on switching from dmraid to mdadm for ISW in mga6.
That mean quite some work:
- supporting partionable arrays
- detecting containers
- changing the way we write /etc/mdadm.conf
- using UUIDs for RAID
- ...

Comment 8 Thierry Vignaud 2016-07-01 16:15:41 CEST

Created attachment 8101 [details]
enable UUIDs for /dev/mdX devices

Comment 9 Marja Van Waes 2021-03-06 14:24:26 CET

(In reply to Thierry Vignaud from comment #8)
> Created attachment 8101 [details]
> enable UUIDs for /dev/mdX devices


Currently, that parts reads:

sub should_prefer_UUID {
    my ($dev) = @_;
    $dev =~ /^((?:[hsv]|xv)d|mmcblk|nvme)/;


but the "hsv" wasn't replaced by "hmsv", like in your patch. Should that still be done?

Keywords: NEEDINFO => (none)
CC: (none) => marja11
Status: NEW => NEEDINFO

Comment 10 Nicolas Lécureuil 2021-03-06 14:27:45 CET

i don't have the hardware at all btw so i can't do any tests.

Note You need to log in before you can comment on or make changes to this bug.