Created attachment 4222 [details] Specfile for The Legend of Edgar I packaged The Legend of Edgar (edgar) for Cauldron, based on a Fedora RPM-Fusion spec file, and would like it to be reviewed. There were in the past license issues with edgar, since some sounds and music files were badly licensed (see https://bugzilla.redhat.com/show_bug.cgi?id=816565#c2). The latest release of the game fixes that, since now all content is CC0, CC-BY or CC-BY-SA.
Whiteboard: (none) => apprentice
For the reference, from #mageia-mentoring on Freenode: <malo> Akien: I'm looking at your spec <malo> Akien: the %post and %postun and %posttrans are not useful in mageia <malo> Akien: the gtk cache is handled automatically <malo> Akien: make %{?_smp_mflags} should be just %make <malo> Akien: Description should not just be the story, I think <malo> Akien: if you are importing from somewhere, it is customary to first import an untouched src.rpm with the original changelog included <malo> and only then to modify it. It better preserves the credit. <malo> Akien: BuildRequires: gettext is not useful (it's there by default) <malo> same for desktop-file-utils <malo> Akien: otherwise it looks good (without having tried to build and install the thing)
Assignee: bugsquad => remi
Version 1.12 pushed by Stormi: http://mageia.madb.org/package/show/release/cauldron/application/0/name/edgar
Status: NEW => RESOLVEDResolution: (none) => FIXED