Bug 103 - do not give choice (or disable) to install category, not present (on selected media)
Summary: do not give choice (or disable) to install category, not present (on selected...
Status: RESOLVED OLD
Alias: None
Product: Mageia
Classification: Unclassified
Component: Installer (show other bugs)
Version: Cauldron
Hardware: All Linux
Priority: Normal enhancement
Target Milestone: ---
Assignee: Thierry Vignaud
QA Contact:
URL: https://wiki.mageia.org/en/Feature:Dy...
Whiteboard: 3alpha2
Keywords: NEEDINFO, PATCH, Triaged
: 649 808 5773 (view as bug list)
Depends on:
Blocks: 5140
  Show dependency treegraph
 
Reported: 2011-02-19 09:53 CET by AL13N
Modified: 2015-02-06 09:10 CET (History)
11 users (show)

See Also:
Source RPM: meta-task
CVE:
Status comment:


Attachments
compssUsers.patch (3.26 KB, patch)
2012-10-03 21:44 CEST, Derek Jennings
Details | Diff
less ugly patch (2.32 KB, patch)
2013-01-13 16:12 CET, Thierry Vignaud
Details | Diff
revised less ugly patch (5.20 KB, patch)
2013-01-15 16:01 CET, Derek Jennings
Details | Diff
screen shot of patched dual-cd (220.05 KB, image/png)
2013-01-15 16:04 CET, Derek Jennings
Details

Description AL13N 2011-02-19 09:53:58 CET
Description of problem:

I have no exact example in mageia, but i remember that this was in mandriva a problem.

during installation, especially if you have a very small media (and no update media selected), you can experience that you can choose KDE, but KDE isn't available...

Reproducible: 

Steps to Reproduce:
D Morgan 2011-02-19 14:57:25 CET

CC: (none) => dmorganec
Assignee: bugsquad => ahmadsamir3891

D Morgan 2011-02-19 14:58:35 CET

Assignee: ahmadsamir3891 => bugsquad

Comment 1 Ahmad Samir 2011-02-25 00:38:36 CET
This problem only manifests when installing from the dual arch ISO, as KDE is an available option in the installer regardless of the fact that the user has selected to add online sources; as without online sources KDE/GNOME can't be installed as they're not on the ISO.
Ahmad Samir 2011-02-25 00:38:41 CET

Keywords: (none) => Triaged

Comment 2 AL13N 2011-02-25 19:55:05 CET
actually this is more than just dual arch ISO. it's an example of a bigger problem underneath.

it depends on what exactly is on the ISO. eg: if we'd have a separate Gnome or KDE iso, it would have the same thing, it does depend on how we package things, but tbh, if it would be "fixed" underneath, it wouldn't matter, and there'd be an easy way of detecting if the release is flawed because a category is unavailable.

if something is not available on the release for some reason, it shouldn't be selectable or you should be warned about it, given the choice to get more media, and that is just too complex...
Comment 3 Nicolas Vigier 2011-02-26 00:54:47 CET
(In reply to comment #0)
> 
> I have no exact example in mageia, but i remember that this was in mandriva a
> problem.

But this is not mandriva bugzilla.

CC: (none) => boklm

Comment 4 AL13N 2011-02-26 08:56:34 CET
that is true, however that bug is still there, even if we didn't do any small ISOs yet...
Comment 5 Rémy CLOUARD (shikamaru) 2011-02-26 12:40:36 CET
Not a bug, remember that users can add other medias like ftp, http, so if these categories are not there, it would render the above feature useless.

Iâm not sure categories could be added or removed dynamically to these lists, I would be in favor of closing the bug.

CC: (none) => shikamaru

Comment 6 AL13N 2011-02-26 13:36:08 CET
well, if i have some time, i would like to disable the checkbox dependant on which media is there and/or added.
Comment 7 Sébastien Chopin 2011-03-16 21:51:56 CET
I 've installed Mageia Alpha2 with Dual CD 64 bits. During the installation, i've checked "Game", "LXDE", "KDE" and "Gnome". But only "LXDE" packages seems to be present after installation.

CC: (none) => contact

Comment 8 AL13N 2011-03-16 22:24:05 CET
yeah, this is exactly the problem that need fixing, only lxde is actually on the disc, so we need to find a way to disable the checkboxes for it, unless the user also requested online media as well...
Ahmad Samir 2011-03-22 05:20:09 CET

Source RPM: (none) => drakx-installer-stage2
Severity: major => enhancement

Comment 9 AL13N 2011-04-05 23:56:54 CEST
a secondary idea to fix this more rapidly:

if selected feature is not present on the media in question, remember it and if they user updates later on, we can install those missing rpms at that time.
Comment 10 Ahmad Samir 2011-04-06 00:50:46 CEST
*** Bug 649 has been marked as a duplicate of this bug. ***
Comment 11 Sébastien Chopin 2011-04-06 17:33:03 CEST
I 've installed Mageia Beta1 with Dual CD 64 bits. During the installation,
i've checked "Game", "LXDE", "KDE" and "Gnome". But only "LXDE" packages seems
to be present after installation.
Comment 12 Ahmad Samir 2011-04-14 03:17:46 CEST
*** Bug 808 has been marked as a duplicate of this bug. ***

CC: (none) => LpSolit

Comment 13 Frédéric "LpSolit" Buclin 2011-04-14 03:24:50 CEST
(In reply to comment #5)
> Not a bug, remember that users can add other medias like ftp, http, so if these
> categories are not there, it would render the above feature useless.
> 
> Iâm not sure categories could be added or removed dynamically to these lists, I
> would be in favor of closing the bug.

I strongly disagree with both this comment and the fact that the bug moved from major to enhancement. You offer the dual arch CD as a valid media to install Mageia, and then you say the user just has to add other medias to make things work. This is not acceptable. It's like saying "the user should know", which is definitely not true, and generates a very bad experience (especially if the user formatted his HD and has no way to google the web to know what's wrong).

Please reconsider.

CC: (none) => ahmadsamir3891

Comment 14 AL13N 2011-04-14 09:11:41 CEST
Several people are of the opinion that the dual arch CD is not for regular users.

I personally don't care how it's marketed, but i still want it, mostly for server installs and double rescue modes on 1 CD.

however, i stand by my comment, we should find something quick and easy to fix the missing packages later, I'm willing to spend some time on this to get this fixed, but i can't at the moment. and i'm not sure if this modification would make it in time... with the rigorous overviewing such a patch would receive.

but i'll try, somewhere next week...
Comment 15 Barry Jackson 2011-04-14 12:48:50 CEST
May I suggest adding options at the "Updates are available" page in the installer *if* a DE has been selected that is not on the CD.

Something like "You selected KDE desktop which is not on the CD, would you like to download it now?"

Easy to suggest I know :-/

Barry

CC: (none) => zen25000

Comment 16 Ahmad Samir 2011-04-15 00:14:02 CEST
(In reply to comment #13)
> (In reply to comment #5)
> > Not a bug, remember that users can add other medias like ftp, http, so if these
> > categories are not there, it would render the above feature useless.
> > 
> > Iâm not sure categories could be added or removed dynamically to these lists, I
> > would be in favor of closing the bug.
> 
> I strongly disagree with both this comment and the fact that the bug moved from
> major to enhancement. You offer the dual arch CD as a valid media to install
> Mageia, 

Ideally with a big fat banner that says "this CD ISO can be used to install 32bit or 64bit Mageia, and only includes LXDE on the ISO". That should be done before final release anyway, an explanation of what each ISO is/can-do.
Comment 17 Ahmad Samir 2011-04-15 00:15:03 CEST
(In reply to comment #15)
> May I suggest adding options at the "Updates are available" page in the
> installer *if* a DE has been selected that is not on the CD.
> 
> Something like "You selected KDE desktop which is not on the CD, would you like
> to download it now?"
> 
> Easy to suggest I know :-/
> 
> Barry

Yeah, needs the installer to be reworked, I think.

CC: (none) => mageia, pterjan, thierry.vignaud

Comment 18 Samuel Verschelde 2011-10-01 00:37:37 CEST
Assigning to maintainer now that our maintainer's database has an entry for this package. Please assign back to bugsquad@mageia.org in case of a mistake from me.

Assignee: bugsquad => thierry.vignaud

AL13N 2011-10-30 11:41:05 CET

Blocks: (none) => 1994

Manuel Hiebel 2012-03-20 14:30:34 CET

Blocks: 1994 => (none)

Manuel Hiebel 2012-03-27 23:02:31 CEST

Blocks: (none) => 5140

Comment 19 Manuel Hiebel 2012-05-07 02:29:16 CEST
*** Bug 5773 has been marked as a duplicate of this bug. ***

CC: (none) => derekjenn

Comment 20 Marja Van Waes 2012-05-26 13:06:17 CEST
Hi,

This bug was filed against cauldron, but we do not have cauldron at the moment.

Please report whether this bug is still valid for Mageia 2.

Thanks :)

Cheers,
marja

Keywords: (none) => NEEDINFO

Manuel Hiebel 2012-06-12 21:21:30 CEST

Keywords: NEEDINFO => (none)
URL: (none) => https://wiki.mageia.org/en/Feature:DynamicPackageChoice

Manuel Hiebel 2012-09-05 15:35:04 CEST

Whiteboard: (none) => 3alpha1

Comment 21 Derek Jennings 2012-10-03 21:44:46 CEST
Created attachment 2911 [details]
compssUsers.patch

Attached patch will suppress any package group from the install page if the first 'required' package in the group is not present in the available media.

This will have the effect of removing KDE and Gnome from the selection in a dual-cd install as well as many groups.

As a side effect it also adds XFCE to the list of desktop environments see bug 3718
Comment 22 Manuel Hiebel 2012-10-05 15:19:48 CEST
some if are iirc useless as we don't use all label, but it seems a enough to me

Keywords: (none) => PATCH
Source RPM: drakx-installer-stage2 => drakx-installer-stage2, meta-task
Whiteboard: 3alpha1 => 3alpha2

Comment 23 Manuel Hiebel 2013-01-12 22:50:09 CET
so any other review ?

CC: (none) => ennael1

Comment 24 AL13N 2013-01-12 23:07:09 CET
for database: 'postgresql9.1' is too specific, have something with no version in it, so that next years it will not be forgotten to change... eg: 'mariadb'


One more question, what happens when you're using a dual arch CD, but add additional sources (from internet), will those choices appear? or not?
Comment 25 AL13N 2013-01-12 23:09:28 CET
thinking about this, i was hoping for a patch that actually checked the dependencies of the packages it's listing on a lower level.

or the name of the label could be a task-* package provide and having the task-* on the hardware medium could set these...
Comment 26 Derek Jennings 2013-01-13 03:58:41 CET
(In reply to comment #24)
> for database: 'postgresql9.1' is too specific, have something with no version
> in it, so that next years it will not be forgotten to change... eg: 'mariadb'
> 

You are correct. The package selected should represent the 'core' of the group so if the package is absent then the group is effectively absent. mariadb would be a better choice.

> 
> One more question, what happens when you're using a dual arch CD, but add
> additional sources (from internet), will those choices appear? or not?

Yes I believe so.


For sure this bug could be fixed more elegantly. I just went for a solution that was easy to implement.
Comment 27 AL13N 2013-01-13 08:12:15 CET
and i definately appreciate it

for me, this kind of patch is sufficient (even though i haven't tested it),

i say we commit this and release it, so it can be tested.
Comment 28 Thierry Vignaud 2013-01-13 16:12:17 CET
Created attachment 3360 [details]
less ugly patch

First, next time, use diff -u instead.

Secondly, this is little bit ugly, I would prefer to add a 'required' member to the hashes, then checking.
Eg, something like this (untested)
Comment 29 Derek Jennings 2013-01-13 21:36:05 CET
I tried out patch from attachment 3360 [details] without success. :-(

Testing method was to mount the i586 folder from a dual CD file system on  an NFS server, patch compssUsers.pl and then boot a vbox using boot.iso

The group selection screen was unchanged.
Using the command line I checked /tmp/compssUsers.pl was correctly patched.
Comment 30 Derek Jennings 2013-01-15 16:01:31 CET
Created attachment 3369 [details]
revised less ugly patch

I found the problem with attachment 3360 [details].

Here is a revised patch.
It works for me.

Attachment 2911 is obsolete: 0 => 1
Attachment 3360 is obsolete: 0 => 1

Comment 31 Derek Jennings 2013-01-15 16:04:11 CET
Created attachment 3370 [details]
screen shot of patched dual-cd

Here is a screen shot of a dual-CD install with attachment 3369 [details]
Comment 32 Thierry Vignaud 2013-01-15 18:39:28 CET
Fixed in SVN

Resolution: (none) => FIXED
Status: NEW => RESOLVED

Comment 33 Adam H 2013-05-09 20:54:27 CEST
Hi,

I'm a basic-to-intermediate Linux user, and I tried out the M3 RC Installer CD (700MB) dual arch, and the software selection still allows choices that aren't actually on the CD.

Here is a forum post I made about trying the RC:
https://forums.mageia.org/en/viewtopic.php?f=15&t=4844

In particular, a reproducible effect is to choose the first item "Game Station" and then see that the installed system has zero files under /usr/games/.

Also to note, my test system was installed with no internet access provided at the time.  This may have prevented downloading of selected extra packages, however the bug in that scenario is that the installer makes no mention which packages need to be downloaded, and later, no warning message for disconnected internet.

(All the drop-down menu items on this bug report are available to me, but since I don't consider myself a developer, I'm not changing any of them.  I would have expected more restricted privileges of sorts?)

CC: (none) => acf49.2

Comment 34 AL13N 2013-05-10 01:08:24 CEST
i wonder if this got broken when implementing the changes wrt to nonfree/tainted.

btw: about network, are you speaking of bug #199 ?


PS: everyone is a contributor to mageia, even users; and packaging team isn't more important than others, so by that rationale, use common sense and set to what you think is right (plus, there's history)

Status: RESOLVED => REOPENED
Resolution: FIXED => (none)

Comment 35 AL13N 2013-05-10 01:10:19 CEST
setting temporarily as release_blocker to wake up people to see if this can easily get fixed before release, if not, then feel free to drop back to normal.

Priority: Normal => release_blocker

Comment 36 Manuel Hiebel 2013-05-10 17:08:20 CEST
it is not "broken again" as this one was never reporter and fixed and

Status: REOPENED => RESOLVED
Priority: release_blocker => Normal
Resolution: (none) => FIXED

Comment 37 AL13N 2013-05-10 17:21:03 CEST
@leuhmanu: how do you mean? did i read this report wrong?

i read comment 32 that it's been fixed in SVN and this has been released in the mean time...

and in comment 33 that person specifically says that it's not working?

if i read this wrong, please tell me...
Comment 38 AL13N 2013-05-11 10:27:19 CEST
ok, so Manuel tells me that some categories are fixed, but others aren't yet. and that needs to be fixed in compssuser.pl .

Status: RESOLVED => REOPENED
Resolution: FIXED => (none)

Comment 39 Derek Jennings 2013-05-11 12:42:47 CEST
(In reply to AL13N from comment #38)
> ok, so Manuel tells me that some categories are fixed, but others aren't
> yet. and that needs to be fixed in compssuser.pl .

You can blame me for that :)
The patch works by testing if one or more essential packages are on the install media.
It was not obvious to me for some categories which packages(s) might be considered essential when referring to the categories in the rpmsrate file.

For example in the CONFIG category *none* of the packages in rpmsrate appear to be essential

For the GAMES category I suppose we could test for the presence of pysol or similar.
Comment 40 Manuel Hiebel 2013-05-11 12:46:34 CEST
pysol is not in the dvd iso, so maybe more fortune-mod

Source RPM: drakx-installer-stage2, meta-task => meta-task

Frédéric "LpSolit" Buclin 2013-05-11 12:50:59 CEST

CC: LpSolit => (none)

Nicolas Vigier 2014-03-24 10:52:25 CET

CC: boklm => (none)

Comment 41 Dick Gevers 2014-11-15 05:51:31 CET
Looks like this could be closed as OLD? Reporter/commentor please do uf you can.

Keywords: (none) => NEEDINFO

Comment 42 Thierry Vignaud 2015-02-06 09:10:25 CET
I think so.
We now filter the package categories according to some package presence

Status: REOPENED => RESOLVED
Resolution: (none) => OLD


Note You need to log in before you can comment on or make changes to this bug.