Bug 10103 - openl2tp don't work, don't start when booting
Summary: openl2tp don't work, don't start when booting
Status: RESOLVED FIXED
Alias: None
Product: Mageia
Classification: Unclassified
Component: RPM Packages (show other bugs)
Version: 4
Hardware: All Linux
Priority: High critical
Target Milestone: ---
Assignee: QA Team
QA Contact:
URL:
Whiteboard: advisory MGA4-64-OK MGA4-32-OK
Keywords: Triaged, validated_update
Depends on:
Blocks: 3454
  Show dependency treegraph
 
Reported: 2013-05-15 09:17 CEST by Alex Loginov
Modified: 2014-04-15 20:13 CEST (History)
6 users (show)

See Also:
Source RPM: openl2tp
CVE:
Status comment:


Attachments
Current boot log (91.71 KB, application/octet-stream)
2014-02-21 07:37 CET, Alex Loginov
Details
Boot log with "Restart=always" (90.88 KB, application/octet-stream)
2014-02-21 07:55 CET, Alex Loginov
Details

Description Alex Loginov 2013-05-15 09:17:40 CEST
Description of problem: openl2tp don't work


Version-Release number of selected component (if applicable): openl2tp-1.8-6


How reproducible: always


Steps to Reproduce:
1. service openl2tp start
2. to see logs: /var/log/messages:
"Invalid executable path in command line, ignoring killproc"
"rpcbind terminating on signal."
"Unable to register UDP RPC program"

Reproducible: 

Steps to Reproduce:
Alex Loginov 2013-05-15 09:32:48 CEST

Hardware: i586 => All
Source RPM: openl2tp => openl2tp rpcbind

Manuel Hiebel 2013-05-24 23:25:08 CEST

Keywords: (none) => Triaged
Assignee: bugsquad => dlucio

Comment 1 Alex Loginov 2013-06-11 10:26:04 CEST
How to use Mageia 3 if half provides in Commonwealth of Independent States works with VPN L2TP? It's critical bug.
Now VPN L2TP works fine only in Mageia 2 with openl2tp from Mageia Russian Community repo. Users don't want to use Mageia 3, because without Internet it's a bad distro.

Priority: Normal => High
Severity: normal => critical

Comment 2 Buchan Milne 2013-06-16 12:32:31 CEST
It looks like the rpcbind service was not enabled/started;

# systemctl start rpcbind
# systemctl start openl2tp

To ensure you do't run into this after next boot:
# systemctl enable rpcbind

If openl2tp is so important, why has no-one requested any improvements?

I must say that of the linux desktop users I know, not one requires openl2tp, so this is quite a region-specific feature it seems, and I wouldn't judge any distro based on L2TP support (many distros don't even ship openl2tp).

CC: (none) => bgmilne

Comment 3 Alex Loginov 2013-06-16 13:23:24 CEST
There is openl2tp in MRC repo always. Mandriva had openl2tp in EduMandriva repo. Rosa haves openl2tp, xl2tpd, networkmanager-l2tp (now will be networkmanager-l2tp in Rosa distro, I think). All Russian distros haves VPN L2TP. Yes, it's region-specific.
Comment 4 Alex Loginov 2013-06-22 15:22:19 CEST
rpcbind service is enabled by default in distro.
If to run first, then openl2tp service can not start (no openl2tp in processes) and creates empty /var/run/openl2tpd.pid. If to run second, then openl2tp service can not start, because there is file /var/run/openl2tpd.pid.
Comment 5 Daniel Lucio 2013-06-22 17:24:18 CEST
i will check this,
Comment 6 Alex Loginov 2013-06-22 18:05:27 CEST
No killproc in Mageia, no absolute paths in ExecStop=, it's critical for systemd, but problems are not only with killproc.
Main problem, if to fix killproc, with loading plugin /usr/lib/openl2tp/ppp_unix.so and with auto loading kernel module l2tp_ppp (it's in /etc/init.d/openl2tpd, but no in systemd module).
I don't understand why service was named openl2tp instead openl2tpd. Will you rename?
Comment 7 Alex Loginov 2014-01-19 22:17:44 CET
Now openl2tp works in Mageia 4 RC, but no killproc in Mageia.
Please write mudules for systemd right.
Alex Loginov 2014-02-06 23:05:59 CET

Blocks: (none) => 3454

Alex Loginov 2014-02-20 20:18:27 CET

Summary: openl2tp don't work => openl2tp don't work, don't start when booting

Comment 8 Alex Loginov 2014-02-21 07:37:56 CET
Created attachment 4997 [details]
Current boot log

It's current boot log. You can see openl2tpd does not start when booting usually or starts randomly (I saw success very rarely).
Comment 9 Alex Loginov 2014-02-21 07:55:36 CET
Created attachment 4998 [details]
Boot log with "Restart=always"

If to add
Restart=always
in /usr/lib/systemd/system/openl2tp.service, then openl2tp starts when booting realy always.
You can see in log: "openl2tp.service holdoff time over, scheduling restart." and openl2tp starts not from the first time, but from the second time.
Comment 10 Alex Loginov 2014-02-22 08:12:40 CET
Current fix for openl2tp.service:
- move ExecStop=killproc openl2tpd
- add ExecStartPre=/sbin/modprobe -q l2tp_ppp
- add Restart=always (?)
Alex Loginov 2014-02-22 08:14:59 CET

Source RPM: openl2tp rpcbind => openl2tp
Whiteboard: (none) => NEEDHELP

Comment 11 Alex Loginov 2014-03-10 21:37:57 CET
Fixed in Cauldron openl2tp-1.8-8.mga5. "Restart=always" is while WONTFIX, in waiting for better solution.
Comment 12 Alex Loginov 2014-03-18 17:59:17 CET
Suggested advisory:
========================

Updated openl2tp package fix:

- move killproc, which non exists for Mageia, and systemd can stop openl2tp service without additional command
- preload kernel module l2tp_ppp with according /etc/rc.d/init.d/openl2tpd
- openl2tp is realy forking type service, not simple, and after fix openl2tp works better, more success after booting system.

Please test also:
ps -A|grep openl2tp
some times after booting system
One tester tested 100% success, but I tested only 50% success after booting system. In any case it's better, then before fix.

========================

Updated packages in updates_testing:
========================
openl2tp-1.8-7.1.mga4.i586.rpm
openl2tp-1.8-7.1.mga4.x86_64.rpm
openl2tp-devel-1.8-7.1.mga4.i586.rpm
openl2tp-devel-1.8-7.1.mga4.x86_64.rpm

Source RPMs: 
openl2tp-1.8-7.1.mga4.src.rpm

Version: Cauldron => 4
QA Contact: (none) => qa-bugs
Whiteboard: NEEDHELP => (none)

Alex Loginov 2014-03-18 18:00:01 CET

Assignee: luis.daniel.lucio => qa-bugs
QA Contact: qa-bugs => (none)

Comment 13 Yuri Galitsky 2014-03-19 15:07:08 CET
Tested openl2tp-1.8-9.mga5.x86_64.rpm from cauldron on my desktop PC and Virtualbox.

1. openl2tp starts successfully every time when booting mga4 on my PC.

2. openl2tp doesn't start when booting mga4 installed at Virtualbox.

It seems to me, it because of rpcbind doesn't start properly while openl2tp starts. openl2tp and rpcbind starts simultaneously, but wnen booting in Virtualbox (and maybe slow PC too) rpcbind takes more time to start. For example on my PC openl2tp starts during 13ms, rpcbind starts during 5ms, on Virtualbox openl2tp starts during 198ms, rpcbind starts during 216ms.
If to add into the After= rpcbind.target in openl2tp.service i.e. "After=network.target remote-fs.target nss-lookup.target rpcbind.target", then openl2tp start when booting at Virtualbox for me too.

CC: (none) => ugal12v

Comment 14 Alex Loginov 2014-03-20 05:13:24 CET
Yuri, thank you for test and report.
Commited, waiting submit.

Assignee: qa-bugs => loginov_alex

Comment 15 Alex Loginov 2014-03-21 09:43:27 CET
Suggested advisory:
========================

Updated openl2tp package fix:

- move killproc, which non exists for Mageia, and systemd can stop openl2tp service without additional command
- preload kernel module l2tp_ppp with according /etc/rc.d/init.d/openl2tpd
- openl2tp is realy forking type service, not simple, and after fix openl2tp works better, more success after booting system.
- add rpcbind.target, because openl2tp must wait rpcbind service

Please test also:
ps -A|grep openl2tp
some times after booting system
I tested on Vmware Player 10 times after reboot - 100% success now for me after booting system.

========================

Updated packages in updates_testing:
========================
openl2tp-1.8-7.2.mga4.i586.rpm
openl2tp-1.8-7.2.mga4.x86_64.rpm
openl2tp-devel-1.8-7.2.mga4.i586.rpm
openl2tp-devel-1.8-7.2.mga4.x86_64.rpm

Source RPMs: 
openl2tp-1.8-7.2.mga4.src.rpm

Assignee: loginov_alex => qa-bugs

Comment 16 Lewis Smith 2014-03-24 18:05:21 CET
Testing MGA4 64-bit on real hardware.
If I understand the bug correctly (not being able to see the wood for the trees), it boils down to the fact that openl2tp did not get started correctly at boot.
Also, that rpcbind needs to be installed & started also.

CAUTION: when I installed openl2tp from Release media, it installed OK even though rpcbind was *not* installed (I added it subsequently). Since rpcbind seems to be a dependancy of openl2tp, has this been taken care of in the update of the latter?

Before update
-------------
With Release rpcbind & openl2tp, booting the system started rpcbind but *not* openl2tp, which needed starting manually as described:
 # systemctl start openl2tp

After update (openl2tp-1.8-7.2.mga4)
------------
Re-booting the system gave:
$ ps ax | grep rpcbind
 1838 ?        Ss     0:00 /sbin/rpcbind -w 
$ ps ax | grep openl2tp
 1894 ?        S      0:00 /usr/sbin/openl2tpd
which seems to resolve the essence of the bug.

If this is deemed OK, please add MGA4-64-OK to the Whiteboard field.

CC: (none) => lewyssmith

Comment 17 Alex Loginov 2014-03-24 18:38:40 CET
Requires: rpcbind
It was before updates and no changes after updates.
Comment 18 Lewis Smith 2014-03-25 19:38:01 CET
Re comment 16 & comment 17:
Sorry Alex, you are right. My note about having to specifically add rpcbind was untrue. I removed both packages (& their libs), and re-installed just openl2tp from Core Release. It did indeed pull in:
 lib64tirpc1
 libtirpc
 openl2tp
 rpcbind
So assuming you have implicitly agreed the simple test in Comment 16, this is OK for MGA4 64-bit.

Whiteboard: (none) => MGA4-64-OK

Comment 19 claire robinson 2014-03-27 18:42:32 CET
Anyone involved able to test the fix i586 please?
Comment 20 Yuri Galitsky 2014-04-02 07:32:04 CEST
Tested openl2tp-1.8-7.2.mga4.i586.rpm package on Virtualbox with Mageia-4.1-test3-i586-DVD.iso image installed. After reboot openl2tp started 100% successfully.

$ ps -A |grep openl2tp
 1481 ?        00:00:00 openl2tpd

$ systemctl status openl2tp
openl2tp.service - The open L2TP implementation
   Loaded: loaded (/usr/lib/systemd/system/openl2tp.service; enabled)
   Active: active (running) since Ð¡Ñ 2014-04-02 12:02:19 NOVT; 18min ago
  Process: 1473 ExecStart=/usr/sbin/openl2tpd $OPENL2TPDARGS (code=exited, status=0/SUCCESS)
  Process: 1470 ExecStartPre=/sbin/modprobe -q l2tp_ppp (code=exited, status=0/SUCCESS)
 Main PID: 1481 (openl2tpd)
   CGroup: /system.slice/openl2tp.service
           ââ1481 /usr/sbin/openl2tpd

I tested 10 times after reboot and it starts OK for me.
Comment 21 Arnaud Vacquier 2014-04-13 16:51:54 CEST
Hi,

I tested from LiveDVD4.0KDE i586 after install testing and reboot; it is okay 

$ systemctl status openl2tp
openl2tp.service - The open L2TP implementation
   Loaded: loaded (/usr/lib/systemd/system/openl2tp.service; enabled)
   Active: active (running) since dim. 2014-04-13 16:22:00 CEST; 1min 53s ago
  Process: 1432 ExecStart=/usr/sbin/openl2tpd $OPENL2TPDARGS (code=exited, status=0/SUCCESS)
  Process: 1402 ExecStartPre=/sbin/modprobe -q l2tp_ppp (code=exited, status=0/SUCCESS)
 Main PID: 1440 (openl2tpd)
   CGroup: /system.slice/openl2tp.service
           ââ1440 /usr/sbin/openl2tpd

Okay afer 3 reboot on virtualbox, i think it is ok for MGA4-32-OK

CC: (none) => inster.css

Alex Loginov 2014-04-13 17:45:24 CEST

Whiteboard: MGA4-64-OK => MGA4-64-OK MGA4-32-OK

Comment 22 claire robinson 2014-04-14 15:36:38 CEST
Thanks everybody.

Validating. Advisory uploaded.

Could sysadmin please push to 4 updates

Thanks

Keywords: (none) => validated_update
Whiteboard: MGA4-64-OK MGA4-32-OK => advisory MGA4-64-OK MGA4-32-OK
CC: (none) => sysadmin-bugs

Comment 23 Damien Lallement 2014-04-15 20:13:26 CEST
http://advisories.mageia.org/MGAA-2014-0101.html

Status: NEW => RESOLVED
CC: (none) => mageia
Resolution: (none) => FIXED


Note You need to log in before you can comment on or make changes to this bug.