| Summary: | Add new rpm of Boomaga (a virtual printer) which depends on snappy | ||
|---|---|---|---|
| Product: | Mageia | Reporter: | Dimitrios Glentadakis <dglent> |
| Component: | New RPM package request | Assignee: | Dimitrios Glentadakis <dglent> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Normal | CC: | fundawang, jani.valimaa, oliver.bgr, pavelfric, shlomif |
| Version: | Cauldron | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Source RPM: | CVE: | ||
| Status comment: | |||
| Attachments: | Spec file of Boomaga | ||
|
Description
Dimitrios Glentadakis
2013-04-14 13:20:56 CEST
Dimitrios Glentadakis
2013-04-14 13:22:33 CEST
CC:
(none) =>
oliver.bgr Import boomaga http://svnweb.mageia.org/packages/cauldron/boomaga/current/?view=log Import snappy http://svnweb.mageia.org/packages/cauldron/snappy/current/?view=log The snappy spec file i took it directly from fedora. Oliver or anyelse, could you please have an eye too to see if it fits the mageia package policy too ? Thanks Looked at snappy a bit and biggest problem is currently it doesn't follow our library policy [1]. This is pretty normal "problem" when importing pkgs with libraries from Fedora. There're also other minor things needing some cleaning. At least these: 1) unneeded %post and %postun 2) macro available for 'make' and 'make install' 3) normally we should use %configure2_5x macro instead of %configure 4) groups doesn't fit to our group policy [1] https://wiki.mageia.org/en/Libraries_policy CC:
(none) =>
jani.valimaa Thanks for look at it, i did some changes: http://svnweb.mageia.org/packages?view=revision&revision=412779 For snappy, theoretically speaking, src.rpm is a noarch package, so we tend to not use %{_lib}gtest-devel as buildrequires. Instead, we use its virtual provides gtest-devel as buildrequires.
As for the devel sub package, as the %{_libdir}/libsnappy.so is a symlink to %{_libdir}/libsnappy.so.%{major}, only 'Requires: %{name}' is not so enough. Because libsnappy1 will also satisfy it in an 64-bit environment, where is should be lib64snappy1. So I would suggest that the Requires become %{libname}.
Regarding boomaga, the only problem is that there are postun scriptlet to run. I guess the virtual printer should be deleted before the package being removed rather than after. So, the scriptlet should be preun. If i'm wrong, please correct me. Another problem is, `lpadmin` belongs to cups-common package, so there should be a "Requires(preun): cups-common" in the spec file, so that cups-common will not be removed before boomaga. If there are other requirements in installPrinter.sh, those should be put into Requires(post).CC:
(none) =>
fundawang I updated the spec with the version 0.3.0: http://svnweb.mageia.org/packages?view=revision&revision=556717 CC:
(none) =>
shlomif Updated also the snappy to 1.1.1 http://svnweb.mageia.org/packages?view=revision&revision=556733 I will submit both the next days Submitted, thanks very much for the help http://pkgsubmit.mageia.org/uploads/done/cauldron/core/release/20131215070033.dglent.valstar.24662 Status:
NEW =>
RESOLVED |