Bug 9431

That would mean stripping grub2 from its recommends on grub2-mageia-theme then using the attached patch

Keywords: (none) => PATCH
CC: (none) => thierry.vignaud, zen25000
Blocks: (none) => 416

Created attachment 6486 [details]
add support for grub2-text (untested)

I tested by patching bootloader.pm locally and running drakboot...

The "drakboot" program has crashed with the following error:

  undefined value for mandatory argument 'text' encountered at /usr/lib/libDrakX/ugtk3.pm line 1430.
  	...propagated at /usr/libexec/drakboot line 64.

Created attachment 6489 [details]
add support for grub2-text (untested)

s/grub2-menu/grub2/

BTW in case the grub2 theme is already installed, I guess we should alter some value in /etc/default/grub ?

Attachment 6486 is obsolete: 0 => 1

(In reply to Thierry Vignaud from comment #4)
> Created attachment 6489 [details]
> add support for grub2-text (untested)
> 
> s/grub2-menu/grub2/

Gets a lot further now:

The "drakboot" program has crashed with the following error:

  Undefined subroutine &bootloader::get_grub2_append called at /usr/lib/libDrakX/any.pm line 621.
  	...propagated at /usr/libexec/drakboot line 64.

> 
> BTW in case the grub2 theme is already installed, I guess we should alter
> some value in /etc/default/grub ?

Yes it needs the GRUB_THEME= line either removing or commenting followed by update-grub.

Your error is b/c you're not up to date (16.92+ for all of drakxtools*)

Created attachment 6500 [details]
add support for grub2-text

This works smoothly for me

modulo screen is no more translated as the following is no more inserted:
    set locale_dir=...
    set lang=...
    insmode gettext

Attachment 6489 is obsolete: 0 => 1

That's because grub2-mkconfig explicitly run "export LANG=C" if GRUB_TERMINAL_OUTPUT is neither gfxterm nor invalid

Yes that works to go to grub2-text, but on changing back to graphical using drakboot, it offers to edit the menu entries which it did not do when setting up the text bootloader.

I just confirmed that the unpatched bootloader.pm does not offer to edit the menu when installing the graphical so this looks a regression caused by the patch.

We just need to use:
    main_method($bootloader->{method})
instead of:
    $bootloader->{method}

in any.pm

Created attachment 6501 [details]
do use new 2nd screen for both grub2 & grub2-graphic

any.pm?? Sorry you lost me

/usr/lib/libDrakX/any.pm
/usr/lib/libDrakX/fs/any.pm
/usr/lib/libDrakX/resize_fat/any.pm

?? none of the above seem relevant

The first one is the one.
All patches are to be applied in /usr/lib/libDrakX

Thanks

Yes that now works fine - you are on a roll! :-)

BTW could the installer uninstall/not install the theme if grub2-text is selected, so someone doing a minimal installation can avoid the overhead of have a useless theme installed? Maybe something for Mga6.

If it's for Mageia 6 or later, better create a bug report so that it's not forgotten.

Minimal install enables to unselect recommends.
But as I wrote, those patches will land at the same time we remove the recommends
 on grub2-mageia-theme from grub2

commit 205198fbd2e4802d9faf079e46d132aee63d0380
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Mon May 11 04:41:05 2015 -0400

    add support for grub2-text too (mga#9431)
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=205198fbd2e4802d9faf079e46d132aee63d0380

Fixed

Status: ASSIGNED => RESOLVED
Resolution: (none) => FIXED

commit ec8ad5d9c776f8e064e2478561f5bc0d02112aa3
Author: Thierry Vignaud <thierry.vignaud@...>
Date:   Wed Feb 10 23:28:04 2016 +0100

    do use new 2nd screen for both grub2(|-graphic)
    
    see mga#9431
---
 Commit Link:
   http://gitweb.mageia.org/software/drakx/commit/?id=ec8ad5d9c776f8e064e2478561f5bc0d02112aa3